Skip to contentSkip to conversation

Allow OMAP2 boards to setup GPMC chipselects.

PATCH New Mark Jackson 2 participants 4 messages Feb 11, 2013 – Feb 12, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow OMAP2 boards to setup GPMC chipselects.

Expose the enable_gpmc_cs_config() function so OMAP2 boards can register GPMC chipselects.

---
 arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-am33xx/sys_proto.h +2 -0
index 588d8de..97ab60d 100644
@@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
  void sdelay(unsigned long);
 void gpmc_init(void);
+void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
+			u32 size);
 void omap_nand_switch_ecc(int);
 #endif
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Allow OMAP2 boards to setup GPMC chipselects.

Quoted 13 lines · Mark Jackson

Expose the enable_gpmc_cs_config() function so OMAP2 boards can register GPMC chipselects.

---
 arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-am33xx/sys_proto.h +0 -0
index 588d8de..97ab60d 100644

arch/arm/include/asm/arch-am33xx/sys_proto.h void ddr_pll_config(unsigned int ddrpll_M); · line 40

Quoted 6 lines
arch/arm/include/asm/arch-am33xx/sys_proto.h +2 -0
@@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
  void sdelay(unsigned long);
 void gpmc_init(void);
+void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
+			u32 size);
 void omap_nand_switch_ecc(int);
 #endif

Can you please correct the description? You're exposing the function for am33xx not omap2. Otherwise fine with me, and I assume you need this on a custom board (aside: the function already exists/is used in arch/arm/cpu/armv7/am33xx/mem.c). Are you planning to submit that support as well? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130212/62c17920/attachment.pgp>
#2 lore raw

PATCH 1/1 Allow OMAP2 boards to setup GPMC chipselects.

Quoted 19 lines · Tom Rini
Quoted 17 lines · Mark Jackson

Expose the enable_gpmc_cs_config() function so OMAP2 boards can register GPMC chipselects.

---
  arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
  1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-am33xx/sys_proto.h +2 -0
index 588d8de..97ab60d 100644
@@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
   void sdelay(unsigned long);
  void gpmc_init(void);
+void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
+			u32 size);
Quoted 8 lines

arch/arm/include/asm/arch-am33xx/sys_proto.h void ddr_pll_config(unsigned int ddrpll_M); · line 40

Quoted 2 lines
arch/arm/include/asm/arch-am33xx/sys_proto.h +0 -0
  void omap_nand_switch_ecc(int);
  #endif

Can you please correct the description? You're exposing the function for am33xx not omap2. Otherwise fine with me, and I assume you need this on a custom board (aside: the function already exists/is used in arch/arm/cpu/armv7/am33xx/mem.c). Are you planning to submit that support as well? Thanks!

Sure ... I'll repost with the comment changed.

Yes ... I've not written my own version, I'm using the existing code.

And, yes, I've a new CPU board I'm working on, which I'll submit later (once we've done a hardware re-spin).

Cheers
Mark J.

#3 lore raw

PATCH 1/1 Allow OMAP2 boards to setup GPMC chipselects.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 27 lines · Mark Jackson
Quoted 9 lines · Tom Rini
Quoted 7 lines · Mark Jackson

Expose the enable_gpmc_cs_config() function so OMAP2 boards can register GPMC chipselects.

arch/arm/include/asm/arch-am33xx/sys_proto.h | 2 ++ 1 file
changed, 2 insertions(+)

Quoted 16 lines
Quoted 10 lines
(quoted diff) +0 -0

b/arch/arm/include/asm/arch-am33xx/sys_proto.h index 588d8de..97ab60d 100644 --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M); void sdelay(unsigned long); void gpmc_init(void); +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs
*cs, u32 base, + u32 size); void
omap_nand_switch_ecc(int); #endif

Can you please correct the description? You're exposing the function for am33xx not omap2. Otherwise fine with me, and I assume you need this on a custom board (aside: the function already exists/is used in arch/arm/cpu/armv7/am33xx/mem.c). Are
you planning to submit that support as well? Thanks!

Quoted 1 line

Sure ... I'll repost with the comment changed.

Thanks.

Quoted 5 lines

Yes ... I've not written my own version, I'm using the existing code.

And, yes, I've a new CPU board I'm working on, which I'll submit later (once we've done a hardware re-spin).

Looking forward to it!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRGpzgAAoJENk4IS6UOR1WZh8P+gOPjlJmQi5ZRJSR3fE8gIUu it1T5VDXWiWLLHRDkCsdK5DkamrLwQwYdOpSqVWqN48gqPJJasgSIf36+H5kXArR lkyE1HzmGsP8v31deY/6wIAPy0g3JTCac9IhCmvLkkNwGJzlfdTtoCHyd20oxDmh gzCo9y7PuDfdVnONlyGwuKdefqH/u9gq5nbKdw15DpTgGITUaXfOpRj/4wKOMx0t KzaGXNcKrs30gKJoTEO0R8voRi6s0sEn9uSFBxBp3EXrrQNC8Ee1AKL+RCXfH28Y L3PB1T1eRAAnG5erZOh4EoYzpSwzARJ9vEUOu96m4dLUihDH6ShD+0LSYfTLr0cm wpt2ivzN7Ede9kGg2bZ9l+eL0c5/+V+ZkBqv1m4nT//qxKj/AweuUxexXWnxmVsF XotwUVNPpb2AhDnqRShC56zEM+0CFyNPlSSvp93CO6V/jB4W+RRd9IoKw7AHWmvS KldbC75kDwxncxlCelc3BqDrlh7NZ6yJGVeHfNHm1BNWlg7CCn36IDXUNQ7UAOKE BQ+8u4liYkhGw+EJS0f7o7TD0d1o4qOj/IB5e7sAhhgTeOw/A2jP78HzAvKhGamQ ETJSAzr0M8a1B2Y7YjRM8HG9f0drGWXuektF9y9/vmGaGSOxfYMjLq/Jbe6Pifnv Mi6lmINkleLKmto50Ppf
=KvZG
-----END PGP SIGNATURE-----