V4 unmount causes a GETATTR
Subsystems (2)
Hello,
I have not tracked down as to the exact reason, but it appears umount of v4 file system cause the directory to be revalidating causing the GETATTR.
Is this revalidation really necessary on an unmount?
tia,
steved.
Quoted 7 lines · Steve Dickson
Hello,
I have not tracked down as to the exact reason, but it appears umount of v4 file system cause the directory to be revalidating causing the GETATTR.
Is this revalidation really necessary on an unmount?
I don't know, maybe not. But even if it's not, there are other things (like cleaning up state) that the client will likely try to do on unmount. In the presence of delegations it could have dirty data that it's required to write back even if applications don't currently hold any open files.
So I don't think we can promise umount will work without the network.
--b.
Quoted 7 lines · J. Bruce Fields
Quoted 6 lines · Steve Dickson
Hello,
I have not tracked down as to the exact reason, but it appears umount of v4 file system cause the directory to be revalidating causing the GETATTR.
Quoted 7 lines
Quoted 1 line
Is this revalidation really necessary on an unmount?
I don't know, maybe not. But even if it's not, there are other things (like cleaning up state) that the client will likely try to do on unmount. In the presence of delegations it could have dirty data that it's required to write back even if applications don't currently hold any open files.
Understood with dirty data... but what I as seeing was a v4 mount and then a reboot with no activity on the mount point...
Quoted 2 lines
So I don't think we can promise umount will work without the network.
Again with open files (aka activity on the mount point) I agree but with no activity or open files, I'm think that GETATTR is simply not necessary...
steved.
Quoted 25 lines
-----Original Message-----
From: [email protected] [mailto:linux-nfs- [email protected]] On Behalf Of Steve Dickson
Sent: Friday, February 15, 2013 4:46 PM
To: J. Bruce Fields
Cc: [email protected]
Subject: Re: V4 unmount causes a GETATTRQuoted 7 lines · J. Bruce Fields
Quoted 6 lines · Steve Dickson
Hello,
I have not tracked down as to the exact reason, but it appears umount of v4 file system cause the directory to be revalidating causing the GETATTR.
Quoted 7 lines
Quoted 1 line
Is this revalidation really necessary on an unmount?
I don't know, maybe not. But even if it's not, there are other things (like cleaning up state) that the client will likely try to do on unmount. In the presence of delegations it could have dirty data that it's required to write back even if applications don't currently hold any open files.
Quoted 7 lines
Understood with dirty data... but what I as seeing was a v4 mount and then a reboot with no activity on the mount point...
Quoted 2 lines
So I don't think we can promise umount will work without the network.
Again with open files (aka activity on the mount point) I agree but with no activity or open files, I'm think that GETATTR is simply not necessary...
You'd need to add a lookup intent specifically for umount. Otherwise the filesystem will not be able distinguish between path lookups for umount and other activity.
Also note that "no activity or open files" is no guarantee that you won't be holding delegations or pNFS layouts to return; you may still see hangs.
Cheers,
Trond
Quoted 29 lines · Trond
Quoted 29 lines
-----Original Message-----
From: [email protected] [mailto:linux-nfs- [email protected]] On Behalf Of Steve Dickson
Sent: Friday, February 15, 2013 4:46 PM
To: J. Bruce Fields
Cc: [email protected]
Subject: Re: V4 unmount causes a GETATTRQuoted 7 lines · J. Bruce Fields
Quoted 6 lines · Steve Dickson
Hello,
I have not tracked down as to the exact reason, but it appears umount of v4 file system cause the directory to be revalidating causing the GETATTR.
Quoted 7 lines
Quoted 1 line
Is this revalidation really necessary on an unmount?
I don't know, maybe not. But even if it's not, there are other things (like cleaning up state) that the client will likely try to do on unmount. In the presence of delegations it could have dirty data that it's required to write back even if applications don't currently hold any open files.
Understood with dirty data... but what I as seeing was a v4 mount and then a reboot with no activity on the mount point...
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
So I don't think we can promise umount will work without the network.
Again with open files (aka activity on the mount point) I agree but with no activity or open files, I'm think that GETATTR is simply not necessary...
You'd need to add a lookup intent specifically for umount. Otherwise the filesystem will not be able distinguish between path lookups for umount and other activity.
Also note that "no activity or open files" is no guarantee that you won't be holding delegations or pNFS layouts to return; you may still see hangs.
I've also noticed force mounts this clean up does not happen (aka the GETATTR is not sent)... which is the price of doing forced mounts...
steved.