Skip to contentSkip to conversation

Allow AM33xx boards to setup GPMC chipselects.

PATCH Superseded Mark Jackson 2 participants 3 messages Feb 18, 2013 Arm (32-bit)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Allow AM33xx boards to setup GPMC chipselects.

Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects.

Changes in V3:
- Fix line wrapping

Changes in V2:
- Indicate this is for AM33xx (not OMAP2)

---
 arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-am33xx/sys_proto.h +2 -0
index 588d8de..97ab60d 100644
@@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
  void sdelay(unsigned long);
 void gpmc_init(void);
+void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
+            u32 size);
 void omap_nand_switch_ecc(int);
 #endif
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/1 Allow AM33xx boards to setup GPMC chipselects.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Jackson <[email protected]> writes:

Mark> Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects. Mark> Changes in V3:
Mark> - Fix line wrapping

Mark> Changes in V2:
Mark> - Indicate this is for AM33xx (not OMAP2)

Mark> Signed-off-by: Mark Jackson <[email protected]> Mark> ---

 Mark>  arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++

Mark> 1 file changed, 2 insertions(+)

Mark> diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h Mark> index 588d8de..97ab60d 100644
Mark> --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
Mark> +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
Mark> @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
Mark> void sdelay(unsigned long);
Mark> void gpmc_init(void);
Mark> +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
Mark> + u32 size);

Checkpatch still complains. How about wrapping after *cs, and properly aligning the next line?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v3 1/1 Allow AM33xx boards to setup GPMC chipselects.

Quoted 24 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Jackson <[email protected]> writes:

Mark> Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects. Mark> Changes in V3:
Mark> - Fix line wrapping

Mark> Changes in V2:
Mark> - Indicate this is for AM33xx (not OMAP2)

Mark> Signed-off-by: Mark Jackson <[email protected]> Mark> ---

 Mark>  arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++

Mark> 1 file changed, 2 insertions(+)

Mark> diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h Mark> index 588d8de..97ab60d 100644
Mark> --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
Mark> +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
Mark> @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
Mark> void sdelay(unsigned long);
Mark> void gpmc_init(void);
Mark> +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
Mark> + u32 size);

Quoted 3 lines

Checkpatch still complains. How about wrapping after *cs, and properly aligning the next line?

Grrrr ... stupid mailer programs !!

Hopefully v4 is now correct ...

Mark J.