Skip to contentSkip to conversation

patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection

bug Shaohua Li 2 participants 2 messages Feb 19, 2013

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

This patch in linux-next breaks numa detection. numa_init() will zero numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will have no memory numa info.

Thanks,
Shaohua

#1 lore raw
Quoted 4 lines · Shaohua Li

This patch in linux-next breaks numa detection. numa_init() will zero numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will have no memory numa info.

Hum, yes, I missed this one. :)

Briefly seeing the code, I think moving the following code to early_parse_srat() will fix it, right? :)

	memset(&numa_meminfo, 0, sizeof(numa_meminfo));

I'll send a patch to fix it.

Thanks. :)