Skip to contentSkip to conversation

i2c: ocores: Fix pointer to integer cast warning

PATCH Applied Jayachandran C 4 participants 4 messages Feb 19, 2013 – Feb 21, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: ocores: Fix pointer to integer cast warning

After commit a000b8c1 [i2c: ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg function], compiling i2c-ocores.c for 64-bit gives the following warning:

drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe':
drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size

Fix it by casting the pointer to long.

---
 drivers/i2c/busses/i2c-ocores.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-ocores.c +1 -1
index a873d0a..6afa02d 100644
@@ -331,7 +331,7 @@ static int ocores_i2c_of_probe(struct platform_device *pdev,
 				&i2c->reg_io_width);
 
 	match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
-	if (match && (int)match->data == TYPE_GRLIB) {
+	if (match && (long)match->data == TYPE_GRLIB) {
 		dev_dbg(&pdev->dev, "GRLIB variant of i2c-ocores\n");
 		i2c->setreg = oc_setreg_grlib;
 		i2c->getreg = oc_getreg_grlib;
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1361259199-24709-1-git-send-email-jchandra-dY08KVG/lbpWk0Htik3J/[email protected]

#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jayachandran" == Jayachandran C <jchandra-dY08KVG/lbpWk0Htik3J/[email protected]> writes:

Jayachandran> After commit a000b8c1 [i2c: ocores: Add support for the Jayachandran> GRLIB port of the controller and use function pointers Jayachandran> for getreg and setreg function], compiling i2c-ocores.c Jayachandran> for 64-bit gives the following warning:

Jayachandran> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe':
Jayachandran> drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size

Jayachandran> Fix it by casting the pointer to long.

I've CC'ed Andreas who made the change.

Jayachandran> Signed-off-by: Jayachandran C <jchandra-dY08KVG/lbpWk0Htik3J/[email protected]> Jayachandran> ---

 Jayachandran>  drivers/i2c/busses/i2c-ocores.c |    2 +-

Jayachandran> 1 file changed, 1 insertion(+), 1 deletion(-)

Jayachandran> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c Jayachandran> index a873d0a..6afa02d 100644
Jayachandran> --- a/drivers/i2c/busses/i2c-ocores.c
Jayachandran> +++ b/drivers/i2c/busses/i2c-ocores.c
Jayachandran> @@ -331,7 +331,7 @@ static int ocores_i2c_of_probe(struct platform_device *pdev,
Jayachandran> &i2c->reg_io_width);

Jayachandran> match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
Jayachandran> - if (match && (int)match->data == TYPE_GRLIB) {
Jayachandran> + if (match && (long)match->data == TYPE_GRLIB) {
Jayachandran> dev_dbg(&pdev->dev, "GRLIB variant of i2c-ocores\n");
i2c-> setreg = oc_setreg_grlib;
i2c-> getreg = oc_getreg_grlib;
Jayachandran> --
Jayachandran> 1.7.9.5

Jayachandran> --
Jayachandran> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in Jayachandran> the body of a message to [email protected] Jayachandran> More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Bye, Peter Korsgaard

A message that is not in the archive (sent off-list or not yet received): 87liakiu20.fsf-D6SC8u56vOOJDPpyT6T3/[email protected]

#4 lore raw
Quoted 7 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jayachandran" == Jayachandran C <jchandra-dY08KVG/lbpWk0Htik3J/[email protected]> writes:

Jayachandran> After commit a000b8c1 [i2c: ocores: Add support for the Jayachandran> GRLIB port of the controller and use function pointers Jayachandran> for getreg and setreg function], compiling i2c-ocores.c Jayachandran> for 64-bit gives the following warning:

Quoted 8 lines

Jayachandran> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe':
Jayachandran> drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size

Jayachandran> Fix it by casting the pointer to long.

I've CC'ed Andreas who made the change.

Thanks!

Applied
#5 lore raw
In reply to a message not in the archive
Quoted 10 lines · Jayachandran C

After commit a000b8c1 [i2c: ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg function], compiling i2c-ocores.c for 64-bit gives the following warning:

drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe':
drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size

Fix it by casting the pointer to long.

Applied, thanks!