libibumad/umad.c: In resolve_ca_port, skip ethernet link layer ports

Signed-off-by Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

src/umad.c +8 -1

index 8f817d2..8ab5e80 100644
@@ -256,6 +256,11 @@ static int resolve_ca_port(char *ca_name, int *port)
 			ret = -1;
 			goto Exit;
 		}
+		if (strcmp(ca.ports[*port]->link_layer, "InfiniBand") &&
+		    strcmp(ca.ports[*port]->link_layer, "IB")) {
+			ret = -1;
+			goto Exit;
+		}
 		if (ca.ports[*port]->state == 4) {
 			ret = 1;
 			goto Exit;

@@ -270,6 +275,9 @@ static int resolve_ca_port(char *ca_name, int *port)
 		DEBUG("checking port %d", i);
 		if (!ca.ports[i])
 			continue;
+		if (strcmp(ca.ports[i]->link_layer, "InfiniBand") &&
+		    strcmp(ca.ports[i]->link_layer, "IB"))
+			continue;
 		if (up < 0 && ca.ports[i]->phys_state == 5)
 			up = *port = i;
 		if (ca.ports[i]->state == 4) {
--

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

What about QP1? It was my understanding that CM was still required for RoCE.

Ira

Quoted 1 line

What about QP1? It was my understanding that CM was still required for RoCE.

Yes, RoCE requires CM support but AFAIK CM doesn't use/require these interfaces to get send or receive it's MADs.

RoCE is a weird animal in terms of IB management as SM/QP0 is not used/deprecated and QP1 is only required for CM with most other QP1 things beyond the spec with the exception of SA which is also not used/deprecated.

Quoted 6 lines · Ira Weiny

Quoted 1 line

What about QP1? It was my understanding that CM was still required for RoCE.

Yes, RoCE requires CM support but AFAIK CM doesn't use/require these interfaces to get send or receive it's MADs.

Quoted 4 lines

RoCE is a weird animal in terms of IB management as SM/QP0 is not used/deprecated and QP1 is only required for CM with most other QP1 things beyond the spec with the exception of SA which is also not used/deprecated.

Does the kernel expose QP1 for RoCE to user space?