Skip to contentSkip to conversation

iio: chemical: select IRQ_WORK for ATLAS ph sensor

PATCH In review Arnd Bergmann 3 participants 3 messages Feb 2, 2016 – Feb 6, 2016 IIO

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 iio: chemical: select IRQ_WORK for ATLAS ph sensor

The newly added atlas-ph-sensor driver uses irq_work_queue, which may not always be enabled:

ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!

This adds a 'select' statement to Kconfig to ensure it's there when we need it.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
drivers/iio/chemical/Kconfig +1 -0
index ce7cd1370f74..f73290f84c90 100644
@@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
 	select REGMAP_I2C
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
+	select IRQ_WORK
 	help
 	 Say Y here to build I2C interface support for the Atlas
 	 Scientific OEM pH-SM sensor.
Reviewed-by on v1 1/1
#1 lore raw
Reviewed-by Matt Ranostay <[email protected]>
Quoted 24 lines · Arnd Bergmann

The newly added atlas-ph-sensor driver uses irq_work_queue, which may not always be enabled:

ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!

This adds a 'select' statement to Kconfig to ensure it's there when we need it.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
drivers/iio/chemical/Kconfig +1 -0
index ce7cd1370f74..f73290f84c90 100644
@@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
        select REGMAP_I2C
        select IIO_BUFFER
        select IIO_TRIGGERED_BUFFER
+       select IRQ_WORK
        help
         Say Y here to build I2C interface support for the Atlas
         Scientific OEM pH-SM sensor.
maintainer
#2 lore raw
Quoted 14 lines · Matt Ranostay
Reviewed-by Matt Ranostay <[email protected]>
Quoted 11 lines · Arnd Bergmann

The newly added atlas-ph-sensor driver uses irq_work_queue, which may not always be enabled:

ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!

This adds a 'select' statement to Kconfig to ensure it's there when we need it.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to fail to spot and IRQ_WORK related issues ;)

Thanks,

Jonathan

Quoted 18 lines

drivers/iio/chemical/Kconfig config ATLAS_PH_SENSOR · line 16

Quoted 13 lines
drivers/iio/chemical/Kconfig +1 -0
index ce7cd1370f74..f73290f84c90 100644
@@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
        select REGMAP_I2C
        select IIO_BUFFER
        select IIO_TRIGGERED_BUFFER
+       select IRQ_WORK
        help
         Say Y here to build I2C interface support for the Atlas
         Scientific OEM pH-SM sensor.

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html