Skip to contentSkip to conversation

soc: mediatek: mtk-pm-domains: Allow mt8186 ADSP default power on

PATCH In review Tinghan Shen 3 participants 7 messages Oct 12, 2022 – Dec 16, 2022 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: mediatek: mtk-pm-domains: Allow mt8186 ADSP default power on

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

---
 drivers/soc/mediatek/mt8186-pm-domains.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/mediatek/mt8186-pm-domains.h +1 -3
index 108af61854a3..fce86f79c505 100644
@@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 		.ctl_offs = 0x9FC,
 		.pwr_sta_offs = 0x16C,
 		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
 	},
 	[MT8186_POWER_DOMAIN_ADSP_INFRA] = {
 		.name = "adsp_infra",
@@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 		.ctl_offs = 0x9F8,
 		.pwr_sta_offs = 0x16C,
 		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
 	},
 	[MT8186_POWER_DOMAIN_ADSP_TOP] = {
 		.name = "adsp_top",
@@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 				MT8186_TOP_AXI_PROT_EN_3_CLR,
 				MT8186_TOP_AXI_PROT_EN_3_STA),
 		},
-		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP,
+		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP,
 	},
 };
 
Signature · 1 line
2.18.0
#2 lore raw
In reply to Tinghan Shen

Hi Matthias,

Gently ping for this patch.
May I know this patch current status? It seems is under your reviewing state?

Best regards,
TingHan

Quoted 38 lines · Tinghan Shen

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

---
 drivers/soc/mediatek/mt8186-pm-domains.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/mediatek/mt8186-pm-domains.h +1 -3
index 108af61854a3..fce86f79c505 100644
@@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 		.ctl_offs = 0x9FC,
 		.pwr_sta_offs = 0x16C,
 		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
 	},
 	[MT8186_POWER_DOMAIN_ADSP_INFRA] = {
 		.name = "adsp_infra",
@@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 		.ctl_offs = 0x9F8,
 		.pwr_sta_offs = 0x16C,
 		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
 	},
 	[MT8186_POWER_DOMAIN_ADSP_TOP] = {
 		.name = "adsp_top",
@@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
 				MT8186_TOP_AXI_PROT_EN_3_CLR,
 				MT8186_TOP_AXI_PROT_EN_3_STA),
 		},
-		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP,
+		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP,
 	},
 };
 
maintainer
#3 lore raw
In reply to Tinghan Shen
Quoted 5 lines · Tinghan Shen

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

Do we need a fixes tag here?
My bet is:

Fixes 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")

Or is this not yet a problem but needed to be able to implement access permission configuration in the ADSP driver?

Regards,
Matthias

Quoted 33 lines
---
  drivers/soc/mediatek/mt8186-pm-domains.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/mediatek/mt8186-pm-domains.h +1 -3
index 108af61854a3..fce86f79c505 100644
@@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9FC,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_INFRA] = {
  		.name = "adsp_infra",
@@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9F8,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_TOP] = {
  		.name = "adsp_top",
@@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  				MT8186_TOP_AXI_PROT_EN_3_CLR,
  				MT8186_TOP_AXI_PROT_EN_3_STA),
  		},
-		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP,
+		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP,
  	},
  };
 
#4 lore raw
Quoted 10 lines · Matthias Brugger
Quoted 5 lines · Tinghan Shen

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

Do we need a fixes tag here?
My bet is:

Quoted 7 lines
Fixes 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")

Or is this not yet a problem but needed to be able to implement access permission configuration in the ADSP driver?

Regards,
Matthias

This patch is needed to fix a warning when implementing the ADSP access permission configuration in preloader.

	[    0.334154] mtk-power-controller 10006000.syscon:power-controller: /soc/syscon@10006000/power-controller/power-domain@18/power-domain@19/power-domain@20: A default off power domain has been
ON
	[    0.334246] ------------[ cut here ]------------
	[    0.334252] top_adsp_bus already disabled
	[    0.334274] WARNING: CPU: 5 PID: 113 at drivers/clk/clk.c:969 clk_core_disable+0x90/0xb0

If not for this case, the pm-domain works fine.

Best regards,
TingHan

Quoted 34 lines
Quoted 34 lines
---
  drivers/soc/mediatek/mt8186-pm-domains.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/mediatek/mt8186-pm-domains.h +1 -3
index 108af61854a3..fce86f79c505 100644
@@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9FC,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_INFRA] = {
  		.name = "adsp_infra",
@@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9F8,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_TOP] = {
  		.name = "adsp_top",
@@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  				MT8186_TOP_AXI_PROT_EN_3_CLR,
  				MT8186_TOP_AXI_PROT_EN_3_STA),
  		},
-		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP,
+		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP,
  	},
  };
 
#5 lore raw

Hi Matthias,

Quoted 27 lines · TingHan Shen
Quoted 10 lines · Matthias Brugger
Quoted 5 lines · Tinghan Shen

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

Do we need a fixes tag here?
My bet is:

Quoted 7 lines
Fixes 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")

Or is this not yet a problem but needed to be able to implement access permission configuration in the ADSP driver?

Regards,
Matthias

This patch is needed to fix a warning when implementing the ADSP access permission configuration in preloader.

	[    0.334154] mtk-power-controller 10006000.syscon:power-controller: /soc/syscon@10006000/power-controller/power-domain@18/power-domain@19/power-domain@20: A default off power domain has been
ON
	[    0.334246] ------------[ cut here ]------------
	[    0.334252] top_adsp_bus already disabled
	[    0.334274] WARNING: CPU: 5 PID: 113 at drivers/clk/clk.c:969 clk_core_disable+0x90/0xb0
Quoted 5 lines

If not for this case, the pm-domain works fine.

Best regards,
TingHan

gentle ping for this.
from above descriptions, should I add the fixes tag to this patch?

Best regards,
TingHan

Quoted 37 lines
Quoted 35 lines
Quoted 35 lines

---
  drivers/soc/mediatek/mt8186-pm-domains.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/mediatek/mt8186-pm-domains.h +1 -3
index 108af61854a3..fce86f79c505 100644
@@ -304,7 +304,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9FC,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_INFRA] = {
  		.name = "adsp_infra",
@@ -312,7 +311,6 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  		.ctl_offs = 0x9F8,
  		.pwr_sta_offs = 0x16C,
  		.pwr_sta2nd_offs = 0x170,
-		.caps = MTK_SCPD_KEEP_DEFAULT_OFF,
  	},
  	[MT8186_POWER_DOMAIN_ADSP_TOP] = {
  		.name = "adsp_top",
@@ -332,7 +330,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8186[] = {
  				MT8186_TOP_AXI_PROT_EN_3_CLR,
  				MT8186_TOP_AXI_PROT_EN_3_STA),
  		},
-		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_ACTIVE_WAKEUP,
+		.caps = MTK_SCPD_SRAM_ISO | MTK_SCPD_ACTIVE_WAKEUP,
  	},
  };
 
Signature · 2 lines
Best regards,
TingHan
maintainer
#6 lore raw
Quoted 29 lines · TingHan Shen (沈廷翰)

Hi Matthias,

Quoted 26 lines · TingHan Shen
Quoted 8 lines · Matthias Brugger
Quoted 5 lines · Tinghan Shen

In the use case of configuring the access permissions of the ADSP core, the mt8186 SoC ADSP power will be switched on in the bootloader because the permission control registers are located in the ADSP subsys.

Quoted 8 lines

Do we need a fixes tag here?
My bet is:

Fixes 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")

Or is this not yet a problem but needed to be able to implement access permission configuration in the ADSP driver?

Regards,
Matthias

This patch is needed to fix a warning when implementing the ADSP access permission configuration in preloader.

[    0.334154] mtk-power-controller 10006000.syscon:power-controller: /soc/syscon@10006000/power-controller/power-domain@18/power-domain@19/power-domain@20: A default off power domain has been
ON
[    0.334246] ------------[ cut here ]------------
[    0.334252] top_adsp_bus already disabled
[    0.334274] WARNING: CPU: 5 PID: 113 at drivers/clk/clk.c:969 clk_core_disable+0x90/0xb0
Quoted 9 lines
Quoted 5 lines

If not for this case, the pm-domain works fine.

Best regards,
TingHan

gentle ping for this.
from above descriptions, should I add the fixes tag to this patch?

No that's not needed in this case. Applied now.

Matthias