arm: mvebu: Reduce reg-io-width with UARTs
PATCH 1/1 arm: mvebu: Reduce reg-io-width with UARTs
Setting the reg-io-width to 1 byte represents more accurate description of the HW.
This will fix an issue where UART driver causes kernel panic during bootup. Gregory CLEMENT traced the issue to autoconfig() in 8250.c, where the existence of FIFO is checked from UART_IIR register. The register is now read as 32-bit value as the reg-io-width is set to 4-bytes. The retuned value seems to contain bogus data for bits 31:8, causing the issue.
--- arch/arm/boot/dts/armada-370-xp.dtsi | 4 ++-- arch/arm/boot/dts/armada-xp.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/armada-370-xp.dtsi +2 -2
@@ -54,7 +54,7 @@ reg = <0xd0012000 0x100>; reg-shift = <2>; interrupts = <41>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012100 {
@@ -62,7 +62,7 @@ reg = <0xd0012100 0x100>; reg-shift = <2>; interrupts = <42>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };
arch/arm/boot/dts/armada-xp.dtsi +2 -2
@@ -46,7 +46,7 @@ reg = <0xd0012200 0x100>; reg-shift = <2>; interrupts = <43>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012300 {
@@ -54,7 +54,7 @@ reg = <0xd0012300 0x100>; reg-shift = <2>; interrupts = <44>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };
Signature · 1 line
1.7.10.4
PATCH 1/1 arm: mvebu: Reduce reg-io-width with UARTs
Quoted 10 lines · Heikki Krogerus
Setting the reg-io-width to 1 byte represents more accurate description of the HW.
This will fix an issue where UART driver causes kernel panic during bootup. Gregory CLEMENT traced the issue to
autoconfig()in 8250.c, where the existence of FIFO is checked fromUART_IIRregister. The register is now read as 32-bit value as the reg-io-width is set to 4-bytes. The retuned value seems to contain bogus data for bits 31:8, causing the issue.
I have tested this patch on the Armada XP based board DB-MV784MP-GP, and it fixed the issue. I had few doubts on the fact it worked, but with this test you can add my:
and also my
as co-maintainer of the mvebu subsystem.
Thanks for your patch.
Quoted 54 lines
Signed-off-by Heikki Krogerus <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Masami Hiramatsu <[email protected]>--- arch/arm/boot/dts/armada-370-xp.dtsi | 4 ++-- arch/arm/boot/dts/armada-xp.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/armada-370-xp.dtsi +2
-2@@ -54,7 +54,7 @@ reg = <0xd0012000 0x100>; reg-shift = <2>; interrupts = <41>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012100 {@@ -62,7 +62,7 @@ reg = <0xd0012100 0x100>; reg-shift = <2>; interrupts = <42>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };arch/arm/boot/dts/armada-xp.dtsi +2
-2@@ -46,7 +46,7 @@ reg = <0xd0012200 0x100>; reg-shift = <2>; interrupts = <43>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012300 {@@ -54,7 +54,7 @@ reg = <0xd0012300 0x100>; reg-shift = <2>; interrupts = <44>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 arm: mvebu: Reduce reg-io-width with UARTs
In reply to Heikki KrogerusQuoted 11 lines · Heikki Krogerus
Setting the reg-io-width to 1 byte represents more accurate description of the HW.
This will fix an issue where UART driver causes kernel panic during bootup. Gregory CLEMENT traced the issue to
autoconfig()in 8250.c, where the existence of FIFO is checked fromUART_IIRregister. The register is now read as 32-bit value as the reg-io-width is set to 4-bytes. The retuned value seems to contain bogus data for bits 31:8, causing the issue.
Quoted 3 lines
Signed-off-by Heikki Krogerus <[email protected]>Cc Gregory CLEMENT <[email protected]>Cc Masami Hiramatsu <[email protected]>
I've tested this patch on Armada-XP based OpenBlocks AX3/4 and fixed the issue.
Thank you!
Quoted 50 lines
--- arch/arm/boot/dts/armada-370-xp.dtsi | 4 ++-- arch/arm/boot/dts/armada-xp.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/armada-370-xp.dtsi +2
-2@@ -54,7 +54,7 @@ reg = <0xd0012000 0x100>; reg-shift = <2>; interrupts = <41>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012100 {@@ -62,7 +62,7 @@ reg = <0xd0012100 0x100>; reg-shift = <2>; interrupts = <42>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };arch/arm/boot/dts/armada-xp.dtsi +2
-2@@ -46,7 +46,7 @@ reg = <0xd0012200 0x100>; reg-shift = <2>; interrupts = <43>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; }; serial at d0012300 {@@ -54,7 +54,7 @@ reg = <0xd0012300 0x100>; reg-shift = <2>; interrupts = <44>; - reg-io-width = <4>; + reg-io-width = <1>; status = "disabled"; };
Signature · 4 lines
Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt at hitachi.com