Skip to contentSkip to conversation

b43: HT-PHY: make it BCMA-only

PATCH New Rafał Miłecki 3 participants 5 messages Mar 2, 2013 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: HT-PHY: make it BCMA-only

HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is reallly unlikely we will ever see HT-PHY on SSB thus make the whole code BCMA specific. This will allow us to call various BCMA-specific functions directly (without extra checks).

---
 drivers/net/wireless/b43/Kconfig  |    2 +-
 drivers/net/wireless/b43/phy_ht.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/b43/Kconfig +1 -1
index 7a28d21..09d315d 100644
@@ -131,7 +131,7 @@ config B43_PHY_LP
 
 config B43_PHY_HT
 	bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
-	depends on B43 && EXPERIMENTAL
+	depends on B43 && B43_BCMA && EXPERIMENTAL
 	---help---
 	  Support for the HT-PHY.
 
drivers/net/wireless/b43/phy_ht.c +5 -0
index 7416c5e..3719a88 100644
@@ -346,6 +346,11 @@ static int b43_phy_ht_op_init(struct b43_wldev *dev)
 	u16 tmp;
 	u16 clip_state[3];
 
+	if (dev->dev->bus_type != B43_BUS_BCMA) {
+		b43err(dev->wl, "HT-PHY is supported only on BCMA bus!\n");
+		return -EOPNOTSUPP;
+	}
+
 	b43_phy_ht_tables_init(dev);
 
 	b43_phy_mask(dev, 0x0be, ~0x2);
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 b43: HT-PHY: make it BCMA-only

Quoted 16 lines · On Sat, 2 Mar 2013 02:14:25 +0100 Rafa? Mi?ecki <[email protected]> wrote:

HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is reallly unlikely we will ever see HT-PHY on SSB thus make the whole code BCMA specific. This will allow us to call various BCMA-specific functions directly (without extra checks).

---
 drivers/net/wireless/b43/Kconfig  |    2 +-
 drivers/net/wireless/b43/phy_ht.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/b43/Kconfig +0 -0
index 7a28d21..09d315d 100644

drivers/net/wireless/b43/Kconfig config B43_PHY_LP · line 134

Quoted 5 lines
drivers/net/wireless/b43/Kconfig +1 -1
@@ -131,7 +131,7 @@ config B43_PHY_LP
 
 config B43_PHY_HT
 	bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
-	depends on B43 && EXPERIMENTAL
+	depends on B43 && B43_BCMA && EXPERIMENTAL

Makes sense.
What about removing EXPERIMENTAL? This flag is mostly useless these days.

Quoted 19 lines
drivers/net/wireless/b43/Kconfig +0 -0
 	---help---
 	  Support for the HT-PHY.
 
drivers/net/wireless/b43/phy_ht.c +5 -0
index 7416c5e..3719a88 100644
@@ -346,6 +346,11 @@ static int b43_phy_ht_op_init(struct b43_wldev *dev)
 	u16 tmp;
 	u16 clip_state[3];
 
+	if (dev->dev->bus_type != B43_BUS_BCMA) {
+		b43err(dev->wl, "HT-PHY is supported only on BCMA bus!\n");
+		return -EOPNOTSUPP;
+	}
+
 	b43_phy_ht_tables_init(dev);
 
 	b43_phy_mask(dev, 0x0be, ~0x2);
Signature · 8 lines
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20130302/fbfe56cf/attachment.sig>
#2 lore raw

PATCH 1/1 b43: HT-PHY: make it BCMA-only

2013/3/2 Michael B?sch <[email protected]>:

Quoted 20 lines
Quoted 17 lines · On Sat, 2 Mar 2013 02:14:25 +0100 Rafa? Mi?ecki <[email protected]> wrote:

HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is reallly unlikely we will ever see HT-PHY on SSB thus make the whole code BCMA specific. This will allow us to call various BCMA-specific functions directly (without extra checks).

---
 drivers/net/wireless/b43/Kconfig  |    2 +-
 drivers/net/wireless/b43/phy_ht.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/b43/Kconfig +0 -0
index 7a28d21..09d315d 100644
@@ -131,7 +131,7 @@ config B43_PHY_LP
 
Quoted 7 lines

drivers/net/wireless/b43/Kconfig config B43_PHY_LP · line 134

Quoted 4 lines
drivers/net/wireless/b43/Kconfig +1 -1
 config B43_PHY_HT
      bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
-     depends on B43 && EXPERIMENTAL
+     depends on B43 && B43_BCMA && EXPERIMENTAL

Makes sense.
What about removing EXPERIMENTAL? This flag is mostly useless these days.

A little later, I've plan for some minor improvement :)

Signature · 1 line
Rafa?
#3 lore raw

PATCH 1/1 b43: HT-PHY: make it BCMA-only

Quoted 29 lines · Rafa? Mi?ecki

2013/3/2 Michael B?sch <[email protected]>:

Quoted 20 lines
Quoted 17 lines · On Sat, 2 Mar 2013 02:14:25 +0100 Rafa? Mi?ecki <[email protected]> wrote:

HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is reallly unlikely we will ever see HT-PHY on SSB thus make the whole code BCMA specific. This will allow us to call various BCMA-specific functions directly (without extra checks).

---
 drivers/net/wireless/b43/Kconfig  |    2 +-
 drivers/net/wireless/b43/phy_ht.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/b43/Kconfig +0 -0
index 7a28d21..09d315d 100644
@@ -131,7 +131,7 @@ config B43_PHY_LP
 
Quoted 7 lines

drivers/net/wireless/b43/Kconfig config B43_PHY_LP · line 134

Quoted 4 lines
drivers/net/wireless/b43/Kconfig +1 -1
 config B43_PHY_HT
      bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
-     depends on B43 && EXPERIMENTAL
+     depends on B43 && B43_BCMA && EXPERIMENTAL

Makes sense.
What about removing EXPERIMENTAL? This flag is mostly useless these days.

Quoted 1 line

A little later, I've plan for some minor improvement :)

There is already a patch [0] in Linus tree removing EXPERIMENTAL.

Hauke

[0]:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=afd19ef0b1a98f420ddcfc619182fd589034577f

#4 lore raw

PATCH 1/1 b43: HT-PHY: make it BCMA-only

2013/3/2 Hauke Mehrtens <[email protected]>:

Quoted 30 lines · Rafa? Mi?ecki
Quoted 29 lines

2013/3/2 Michael B?sch <[email protected]>:

Quoted 27 lines
Quoted 16 lines · On Sat, 2 Mar 2013 02:14:25 +0100 Rafa? Mi?ecki <[email protected]> wrote:

HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is reallly unlikely we will ever see HT-PHY on SSB thus make the whole code BCMA specific. This will allow us to call various BCMA-specific functions directly (without extra checks).

---
 drivers/net/wireless/b43/Kconfig  |    2 +-
 drivers/net/wireless/b43/phy_ht.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/b43/Kconfig +0 -0
index 7a28d21..09d315d 100644

drivers/net/wireless/b43/Kconfig config B43_PHY_LP · line 134

Quoted 5 lines
drivers/net/wireless/b43/Kconfig +1 -1
@@ -131,7 +131,7 @@ config B43_PHY_LP
 
 config B43_PHY_HT
      bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
-     depends on B43 && EXPERIMENTAL
+     depends on B43 && B43_BCMA && EXPERIMENTAL

Makes sense.
What about removing EXPERIMENTAL? This flag is mostly useless these days.

Quoted 8 lines
Quoted 1 line

A little later, I've plan for some minor improvement :)

There is already a patch [0] in Linus tree removing EXPERIMENTAL.

Hauke

[0]:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=afd19ef0b1a98f420ddcfc619182fd589034577f

Glad there was a b43-dev Cc...

John please drop this patch. I'll wait for you merging Linus's tree and re-submit it rebased.

Signature · 1 line
Rafa?