Skip to contentSkip to conversation

ARM: tegra: don't unlock MMIO access to DBGLAR

PATCH New Joseph Lo 2 participants 2 messages Feb 19, 2013 – Mar 6, 2013

Subsystems (3)
lore
Share & tools
lore

Joseph Lo

author
#0 lore raw

PATCH 1/1 ARM: tegra: don't unlock MMIO access to DBGLAR

There is no need to unlock MMIO access to the DBGLAR all the time. Doing so may even cause problems if a SW bug causes writes to that MMIO region.

Cortex-A15 processors do not support the CP14 register write the code currently uses to unlock the DBGLAR; the instruction throws an undefined instruction exceptions. This prevents tegra_secondary_startup() from executing on Tegra114, and hence prevents SMP.

Remove the code that unlocks this access.

---
 arch/arm/mach-tegra/headsmp.S       | 3 ---
 arch/arm/mach-tegra/reset-handler.S | 3 ---
 2 files changed, 6 deletions(-)
arch/arm/mach-tegra/headsmp.S +0 -3
index fd473f2..045c16f 100644
@@ -7,8 +7,5 @@
 
 ENTRY(tegra_secondary_startup)
         bl      v7_invalidate_l1
-	/* Enable coresight */
-	mov32	r0, 0xC5ACCE55
-	mcr	p14, 0, r0, c7, c12, 6
         b       secondary_startup
 ENDPROC(tegra_secondary_startup)
arch/arm/mach-tegra/reset-handler.S +0 -3
index 54382ce..68b8bfc 100644
@@ -41,9 +41,6 @@
  */
 ENTRY(tegra_resume)
 	bl	v7_invalidate_l1
-	/* Enable coresight */
-	mov32	r0, 0xC5ACCE55
-	mcr	p14, 0, r0, c7, c12, 6
 
 	cpu_id	r0
 	cmp	r0, #0				@ CPU0?
Signature · 1 line
1.8.1.1
#1 lore raw

PATCH 1/1 ARM: tegra: don't unlock MMIO access to DBGLAR

Quoted 9 lines · Joseph Lo

There is no need to unlock MMIO access to the DBGLAR all the time. Doing so may even cause problems if a SW bug causes writes to that MMIO region.

Cortex-A15 processors do not support the CP14 register write the code currently uses to unlock the DBGLAR; the instruction throws an undefined instruction exceptions. This prevents tegra_secondary_startup() from executing on Tegra114, and hence prevents SMP.

Remove the code that unlocks this access.

I have applied this to Tegra's for-3.10/fixes branch.