Skip to contentSkip to conversation

ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

PATCH New Joseph Lo 2 participants 4 messages Feb 27, 2013 – Mar 6, 2013

Subsystems (4)
lore
Share & tools
lore

Joseph Lo

author
#0 lore raw

PATCH v2 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

The PMC HW is not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

---
V2:
* fix the typo and the chip order in DT match table

---
 arch/arm/mach-tegra/pmc.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-tegra/pmc.c +2 -0
index d4fdb5f..5d79d34 100644
@@ -36,6 +36,8 @@ static inline void tegra_pmc_writel(u32 val, u32 reg)
 
 #ifdef CONFIG_OF
 static const struct of_device_id matches[] __initconst = {
+	{ .compatible = "nvidia,tegra114-pmc" },
+	{ .compatible = "nvidia,tegra30-pmc" },
 	{ .compatible = "nvidia,tegra20-pmc" },
 	{ }
 };
Signature · 1 line
1.8.1.1
author
#1 lore raw

PATCH v2 2/2 ARM: dts: tegra: fix the PMC compatible string

The PMC HW is not 100% compatible across all Tegra series. We need to specify them in DT.

---
V2:
* fix typo

---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 arch/arm/boot/dts/tegra30.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra114.dtsi +1 -1
index 1dfaf28..e4ddedd 100644
@@ -99,7 +99,7 @@
 	};
 
 	pmc {
-		compatible = "nvidia,tegra114-pmc", "nvidia,tegra30-pmc";
+		compatible = "nvidia,tegra114-pmc";
 		reg = <0x7000e400 0x400>;
 	};
 
arch/arm/boot/dts/tegra30.dtsi +1 -1
index 767803e..6ae82e7 100644
@@ -422,7 +422,7 @@
 	};
 
 	pmc {
-		compatible = "nvidia,tegra20-pmc", "nvidia,tegra30-pmc";
+		compatible = "nvidia,tegra30-pmc";
 		reg = <0x7000e400 0x400>;
 	};
 
Signature · 1 line
1.8.1.1
#2 lore raw

PATCH v2 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

In reply to Joseph Lo
Quoted 2 lines · Joseph Lo

The PMC HW is not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

Seems reasonable. I plan to apply for 3.10 when I can.

#3 lore raw

PATCH v2 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

In reply to Joseph Lo
Quoted 2 lines · Joseph Lo

The PMC HW is not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

I have applied these two patches to Tegra's for-3.10/cleanup branch.