Skip to contentSkip to conversation

upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver:

DISCUSSION Linda Walsh 1 participant 1 message Mar 7, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I am *not* seeing the bug in 3.8.2 with the 2nd patch applied (in addition to the first)...

Quoted 28 lines · Michael Wang

And both bond_enslave() and bond_mii_monitor() are using bond_update_speed_duplex() with preempt disabled.

Along with the changes in bond_enslave(), I think you also need this (untested):

drivers/net/bonding/bond_main.c +2 -0
index 11d01d6..9af143a 100644
@@ -2373,7 +2373,9 @@ static void bond_miimon_commit(struct bonding *bond)
                                bond_set_backup_slave(slave);
                        }
 
+                       read_unlock(&bond->lock);
                        bond_update_speed_duplex(slave);
+                       read_lock(&bond->lock);
 
                        pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n",
                                bond->dev->name, slave->dev->name,

Regards,
Michael Wang