Skip to contentSkip to conversation

firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler().

RFC In review YOSHIFUJI Hideaki 1 participant 1 message Mar 8, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC 1/11 firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler().

fwnet_broadcast_start() try to register address handler at first if it was not registered yet; dev->local_fifo == FWNET_NO_FIFO_ADDR.

Since dev->local_info not changed if fw_core_add_address_hander() has failed, we do not need to set dev->local_info to FWNET_NO_FIFO_ADDR.

---
 drivers/firewire/net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firewire/net.c +1 -1
index 2b27bff..a7a0e82 100644
@@ -1220,8 +1220,8 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
 	dev->broadcast_rcv_context = NULL;
  failed_context_create:
 	fw_core_remove_address_handler(&dev->handler);
- failed_initial:
 	dev->local_fifo = FWNET_NO_FIFO_ADDR;
+ failed_initial:
 
 	return retval;
 }
Signature · 1 line
1.7.9.5