Skip to contentSkip to conversation

firewire net: Release broadcast/fifo resources on ifdown.

RFC In review YOSHIFUJI Hideaki 1 participant 1 message Mar 8, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC 11/11 firewire net: Release broadcast/fifo resources on ifdown.

Since those resources are allocated on ifup, relsase them on ifdown.

---
 drivers/firewire/net.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/firewire/net.c +4 -4
index ca41446..c1898ad 100644
@@ -1295,9 +1295,12 @@ out:
 /* ifdown */
 static int fwnet_stop(struct net_device *net)
 {
+	struct fwnet_device *dev = netdev_priv(net);
+
 	netif_stop_queue(net);
 
-	/* Deallocate iso context for use by other applications? */
+	fwnet_broadcast_stop(dev);
+	fwnet_fifo_stop(dev);
 
 	return 0;
 }
@@ -1638,9 +1641,6 @@ static int fwnet_remove(struct device *_dev)
 	if (list_empty(&dev->peer_list)) {
 		unregister_netdev(net);
 
-		fwnet_fifo_stop(dev);
-		fwnet_broadcast_stop(dev);
-
 		for (i = 0; dev->queued_datagrams && i < 5; i++)
 			ssleep(1);
 		WARN_ON(dev->queued_datagrams);
Signature · 1 line
1.7.9.5