Skip to contentSkip to conversation

perf recipe update

PATCH In review [email protected] 5 participants 8 messages Mar 8, 2013 – Mar 12, 2013

lore
Share & tools
lore
#0 lore raw

cover perf recipe update

From: Tom Zanussi <[email protected]>

With the 3.8 kernel update, we need a new perf recipe to match. Well,
not really, because there's nothing 3.4-specific about the current one, and there's nothing tying it to a specific version of the kernel.

This acknowledges that by getting rid fo the version number. It also adds a minor cleanup to rename the current include file to something more appropriate.

The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:

core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0

Tom Zanussi (2):
perf: rename perf.inc to perf-features.inc
perf: rename perf_3.4 to perf

 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)
Signature · 1 line
1.7.11.4
#1 lore raw

PATCH 1/2 perf: rename perf.inc to perf-features.inc

From: Tom Zanussi <[email protected]>

The contents of perf.inc are really specific to perf features and shouldn't use the generic perf.inc name, which implies common recipe code. It's always confusing to open up this file and find out that's not what it is.

---
 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/perf_3.4.bb                     | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
meta/recipes-kernel/perf/perf-features.inc renamed from meta/recipes-kernel/perf/perf.inc +0 -0
similarity index 100%
rename from meta/recipes-kernel/perf/perf.inc
rename to meta/recipes-kernel/perf/perf-features.inc
meta/recipes-kernel/perf/perf_3.4.bb +1 -1
index 22feb46..3c49922 100644
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
 PR = "r8"
 
-require perf.inc
+require perf-features.inc
 
 BUILDPERF_libc-uclibc = "no"
 
Signature · 1 line
1.7.11.4
#2 lore raw

PATCH 2/2 perf: rename perf_3.4 to perf

From: Tom Zanussi <[email protected]>

There's nothing kernel-version-specific about the perf_3.4 recipe, so it's actually misnamed and misleading now that it also gets used with the 3.8 kernel.

Since the recipe isn't tied to a specific PV, and simply uses whatever's in STAGING_KERNEL_DIR, there's no reason to add anything else either to the bare PN, so just use that as the recipe name.

---
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (100%)
meta/recipes-kernel/perf/perf.bb renamed from meta/recipes-kernel/perf/perf_3.4.bb +0 -0
similarity index 100%
rename from meta/recipes-kernel/perf/perf_3.4.bb
rename to meta/recipes-kernel/perf/perf.bb
Signature · 1 line
1.7.11.4
#3 lore raw

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

Quoted 10 lines · On 03/07/2013 04:39 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>

There's nothing kernel-version-specific about the perf_3.4 recipe, so it's actually misnamed and misleading now that it also gets used with the 3.8 kernel.

Since the recipe isn't tied to a specific PV, and simply uses whatever's in STAGING_KERNEL_DIR, there's no reason to add anything else either to the bare PN, so just use that as the recipe name.

This did not quite work out correctly, since the package name has now gone backwards since the default PV for a recipe is 1.0 when nothing is set on the recipe file name.

Is there a way to sort this out such that it picks up an incrementing PV from the kernel recipe?

As it stands now, the PV has gone from 3.4 -> 1.0.

Thanks for looking after this.

Sau!

Quoted 11 lines
---
  meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} | 0
  1 file changed, 0 insertions(+), 0 deletions(-)

rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (100%)

meta/recipes-kernel/perf/perf.bb renamed from meta/recipes-kernel/perf/perf_3.4.bb +0 -0
similarity index 100%
rename from meta/recipes-kernel/perf/perf_3.4.bb
rename to meta/recipes-kernel/perf/perf.bb
#4 lore raw

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

Quoted 15 lines · Saul Wold
Quoted 10 lines · On 03/07/2013 04:39 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>

There's nothing kernel-version-specific about the perf_3.4 recipe, so it's actually misnamed and misleading now that it also gets used with the 3.8 kernel.

Since the recipe isn't tied to a specific PV, and simply uses whatever's in STAGING_KERNEL_DIR, there's no reason to add anything else either to the bare PN, so just use that as the recipe name.

This did not quite work out correctly, since the package name has now gone backwards since the default PV for a recipe is 1.0 when nothing is set on the recipe file name.

Quoted 6 lines

Is there a way to sort this out such that it picks up an incrementing PV from the kernel recipe?

As it stands now, the PV has gone from 3.4 -> 1.0.

Thanks for looking after this.

As a hint on how to do this we need to read the kernel version and then set PKGV just prior to or at the start of do_package time.

The logs will show 1.0 as the version but the final packages will have the kernel version.

Cheers,

Richard

#5 lore raw

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

In reply to Saul Wold
Quoted 15 lines · Saul Wold
Quoted 10 lines · On 03/07/2013 04:39 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>

There's nothing kernel-version-specific about the perf_3.4 recipe, so it's actually misnamed and misleading now that it also gets used with the 3.8 kernel.

Since the recipe isn't tied to a specific PV, and simply uses whatever's in STAGING_KERNEL_DIR, there's no reason to add anything else either to the bare PN, so just use that as the recipe name.

This did not quite work out correctly, since the package name has now gone backwards since the default PV for a recipe is 1.0 when nothing is set on the recipe file name.

Quoted 6 lines

Is there a way to sort this out such that it picks up an incrementing PV from the kernel recipe?

As it stands now, the PV has gone from 3.4 -> 1.0.

Thanks for looking after this.

This is what PE is for right? Sounds like we need an epoch bump.

--
Darren hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Acked-by on the v1 series
#6 lore raw
In reply to [email protected]
Quoted 9 lines · On Thu, Mar 7, 2013 at 7:38 PM, <[email protected]> wrote:

From: Tom Zanussi <[email protected]>

With the 3.8 kernel update, we need a new perf recipe to match. Well,
not really, because there's nothing 3.4-specific about the current one, and there's nothing tying it to a specific version of the kernel.

This acknowledges that by getting rid fo the version number. It also adds a minor cleanup to rename the current include file to something more appropriate.

Looks good Tom. Thanks for taking care of this.

Quoted 28 lines

The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:

core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0

Tom Zanussi (2):
perf: rename perf.inc to perf-features.inc
perf: rename perf_3.4 to perf

 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)

--
1.7.11.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
Acked-by
#7 lore raw
Quoted 7 lines · Bruce Ashfield
Quoted 6 lines · On Thu, Mar 7, 2013 at 7:38 PM, <[email protected]> wrote:

From: Tom Zanussi <[email protected]>

With the 3.8 kernel update, we need a new perf recipe to match. Well,
not really, because there's nothing 3.4-specific about the current one, and there's nothing tying it to a specific version of the kernel.

Quoted 7 lines
Quoted 3 lines

This acknowledges that by getting rid fo the version number. It also adds a minor cleanup to rename the current include file to something more appropriate.

Looks good Tom. Thanks for taking care of this.

Quoted 32 lines
Quoted 29 lines

The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:

core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0

Tom Zanussi (2):
perf: rename perf.inc to perf-features.inc
perf: rename perf_3.4 to perf

 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)

--
1.7.11.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel