moving package divine from autotools-package to generic-package

Buildroot Carsten Schoenert 2 participants 4 messages Mar 8, 2013 – Mar 10, 2013

Share & tools

Carsten Schoenert

author

2013-03-08 21:08 UTC #0 lore raw

Hello,

we want to try ilixi [1] on a SetTopBox.
To be able to use it I have to solve the dependency on directfb 1.6.3, that was not a big problem. So for now I'm not knowing if we can use the input driver for raw input via a virtual input device that's provided by DiVine [2]. So thought I bumping the package also to 1.6.3, that was also easy.

But, the archive on directfb.org is broken, inside the archive in the lib/ directory the Header idivine.h is missing. Inside the Git Repo everything is fine. I wrote up the maintainer and describe the issue but until now no response from there.
So I tried to change package divine from a autotools-package to a generic package because the Git Repo just shipped a file autogen.sh for package preparation.

The build works so far but I'm not very familiar with the voodoo of the generic-package mechanism. So I want to ask if you can please take a look at my work before go further and prepare a patch.

This is the file package/divine/divine.mk looks like now.

Quoted 34 lines

#############################################################
#

# divine
#
#############################################################

# tagged version 1.6.3
DIVINE_VERSION = 83cafc257a42b9465cd9d6185bf66b8c1b7ed704
DIVINE_SITE = git://git.directfb.org/git/directfb/extras/DiVine.git
DIVINE_LICENSE = LGPLv2.1+
DIVINE_LICENSE_FILE = COPYING
DIVINE_INSTALL_STAGING = YES
DIVINE_DEPENDENCIES = directfb
DIVINE_CONFIG_SCRIPTS = divine-config

DIVINE_CONF_OPTS = $(TARGET_CONFIGURE_OPTS) \
                   $(TARGET_CONFIGURE_ARGS) \
                   --target=$(GNU_TARGET_NAME) \
                   --host=$(GNU_TARGET_NAME) \
                   --prefix="$(HOST_DIR)/usr"

define DIVINE_CONFIGURE_CMDS

	(cd $(@D) && \
          ACLOCAL_FLAGS="-I $(ACLOCAL_DIR)" \
          PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig" \
          ./autogen.sh $(DIVINE_CONF_OPTS))

endef

define DIVINE_BUILD_CMDS

	$(MAKE) -C $(@D)

endef

define DIVINE_INSTALL_STAGING_CMDS

	DESTDIR=$(STAGING_DIR)/usr $(MAKE) -C $(@D) install

Quoted 8 lines

endef
define DIVINE_INSTALL_TARGET_CMDS
	DESTDIR=$(TARGET_DIR)/usr $(MAKE) -C $(@D) install
endef
$(eval $(generic-package))
$(eval $(host-generic-package))

I think the --prefix option can be left, the destdir is given by the install commands.
Are the directory all correct or is there something more improvable? The call of the two macros at the end is needed as far as I understand.

I tested the build only for my ARM based SetTopBox, maybe other platforms need enhancements.

Thanks for feedback!
Regards
Carsten

[1] http://www.ilixi.org/
[2] http://directfb.org/downloads/Extras/README.DiVine

Thomas Petazzoni

2013-03-09 09:13 UTC #1 lore raw

Dear Carsten Schoenert,

Quoted 7 lines · Carsten Schoenert

But, the archive on directfb.org is broken, inside the archive in the lib/ directory the Header idivine.h is missing. Inside the Git Repo everything is fine. I wrote up the maintainer and describe the issue but until now no response from there.
So I tried to change package divine from a autotools-package to a generic package because the Git Repo just shipped a file autogen.sh for package preparation.

No, no, it should continue to be an autotools-package. It has a configure.in, and Makefile.am, it is autotools based, so it should remain an autotools-package.

Now, since you're getting it from git instead of a tarball, the configure script and Makefile.in are not pre-generated, so we have to get them generated.

Can you just try to do:

DIVINE_AUTORECONF = YES

in the package recipe?

Looking at what the autogen.sh script does, I think our autoreconf logic should work. Otherwise, we will just add a hook in the package recipe in order to call autogen.

But clearly, converting to generic-package is the wrong way to go.

Best regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Carsten Schoenert

author

2013-03-10 08:59 UTC #2 lore raw

Hello Thomas,

Am 09.03.2013 10:13, schrieb Thomas Petazzoni:

Quoted 3 lines

No, no, it should continue to be an autotools-package. It has a configure.in, and Makefile.am, it is autotools based, so it should remain an autotools-package.

O.K. In short, if a package is comprised a file 'autogen.sh' and this generate the whole autotool stuff the package has to be a autotools-package.

Quoted 9 lines

Now, since you're getting it from git instead of a tarball, the configure script and Makefile.in are not pre-generated, so we have to get them generated.
Can you just try to do:
DIVINE_AUTORECONF = YES
in the package recipe?

Yes this works, but I get some warnings! Maybe the AUTORECONF things has to be a little reworked. I don't know there to look to solve thees warnings. The package divine doesn't have a macro AC_LANG_CONFTEST in use.

Quoted 27 lines

carsten at wheezy:~/gitprojects/buildroot [ubi-arm-directfb] $ make divine-dirclean
rm -Rf /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 carsten at wheezy:~/gitprojects/buildroot [ubi-arm-directfb] $ make divine
Quoted 1 line
Quoted 1 line
Quoted 1 line
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Extracting
gzip -d -c /home/carsten/gitprojects/buildroot/dl/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704.tar.gz | tar --strip-components=1 -C /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 -xf -
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Patching package//divine divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Updating config.sub and config.guess
for file in config.guess config.sub; do for i in $(find /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 -name $file); do cp support/gnuconfig/$file $i; done; done
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Patching libtool divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Autoreconfiguring
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:1084: _LT_SYS_MODULE_PATH_AIX is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:4207: _LT_LINKER_SHLIBS is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:5339: _LT_LANG_C_CONFIG is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:143: _LT_SETUP is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:69: LT_INIT is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:108: AM_PROG_LIBTOOL is expanded from... configure.in:56: the top level
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:4207: _LT_LINKER_SHLIBS is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:5339: _LT_LANG_C_CONFIG is expanded from...

Quoted 8 lines

/home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:143: _LT_SETUP is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:69: LT_INIT is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:108: AM_PROG_LIBTOOL is expanded from... configure.in:56: the top level
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from... ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...

...

At the end the output is installed to the target directory.

Quoted 1 line

But clearly, converting to generic-package is the wrong way to go.

I understand, maybe this can be more precise highlighted in the manual.

So now I will rework my work to prepare some patches. Thanks for reviewing!

Regards
Carsten

Thomas Petazzoni

2013-03-10 09:27 UTC #3 lore raw

Dear Carsten Schoenert,

Quoted 7 lines · Carsten Schoenert

Am 09.03.2013 10:13, schrieb Thomas Petazzoni:
Quoted 3 lines
No, no, it should continue to be an autotools-package. It has a configure.in, and Makefile.am, it is autotools based, so it should remain an autotools-package.
O.K. In short, if a package is comprised a file 'autogen.sh' and this generate the whole autotool stuff the package has to be a autotools-package.

Yes, unless there are some specific issues, all packages that use autoconf/automake should use the autotools-package infrastructure.

Quoted 38 lines

Yes this works, but I get some warnings! Maybe the AUTORECONF things has to be a little reworked. I don't know there to look to solve thees warnings. The package divine doesn't have a macro AC_LANG_CONFTEST in use.
Quoted 27 lines
carsten at wheezy:~/gitprojects/buildroot [ubi-arm-directfb] $ make divine-dirclean
rm -Rf /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 carsten at wheezy:~/gitprojects/buildroot [ubi-arm-directfb] $ make divine
Quoted 1 line
Quoted 1 line
Quoted 1 line
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Extracting
gzip -d -c /home/carsten/gitprojects/buildroot/dl/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704.tar.gz | tar --strip-components=1 -C /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 -xf -
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Patching package//divine divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Updating config.sub and config.guess
for file in config.guess config.sub; do for i in $(find /home/carsten/gitprojects/buildroot/output/build/divine-83cafc257a42b9465cd9d6185bf66b8c1b7ed704 -name $file); do cp support/gnuconfig/$file $i; done; done
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Patching libtool divine 83cafc257a42b9465cd9d6185bf66b8c1b7ed704 Autoreconfiguring
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:1084: _LT_SYS_MODULE_PATH_AIX is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:4207: _LT_LINKER_SHLIBS is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:5339: _LT_LANG_C_CONFIG is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:143: _LT_SETUP is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:69: LT_INIT is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:108: AM_PROG_LIBTOOL is expanded from... configure.in:56: the top level
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:4207: _LT_LINKER_SHLIBS is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:5339: _LT_LANG_C_CONFIG is expanded from...
Quoted 8 lines
/home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:143: _LT_SETUP is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:69: LT_INIT is expanded from... /home/carsten/gitprojects/buildroot/output/host/usr/share/aclocal/libtool.m4:108: AM_PROG_LIBTOOL is expanded from... configure.in:56: the top level
configure.in:56: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from... ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...

Quoted 1 line

...

Yes. I am not an expert in autoconf/automake, but there are often some warnings due to slight changes in the autoconf/automake languages, and the corresponding configure.ac/Makefile.am in the project not being updated accordingly.

Quoted 3 lines

Quoted 1 line
But clearly, converting to generic-package is the wrong way to go.
I understand, maybe this can be more precise highlighted in the manual.

Hum, ok. About the generic-package infrastructure, the manual says:

By packages with specific build systems we mean all the packages whose build system is not one of the standard ones, such as autotools or CMake. This typically includes packages whose build system is based on hand-written Makefiles or shell scripts.

Maybe this wording is not explicit enough?

Quoted 1 line

So now I will rework my work to prepare some patches. Thanks for reviewing!

You're welcome, thanks for contributing!

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com