Skip to contentSkip to conversation

ARM: davinci: Add support for configuring DA8XX_REMOTEPROC

PATCH New Sergei Shtylyov 5 participants 5 messages Mar 9, 2013 – Mar 12, 2013 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH v8 3/7 ARM: davinci: Add support for configuring DA8XX_REMOTEPROC

Hello.

Quoted 11 lines · Robert Tivy

Also fix REMOTEPROC config to select FW_LOADER (instead of FW_CONFIG).

---
  drivers/remoteproc/Kconfig |   26 +++++++++++++++++++++++++-
  1 file changed, 25 insertions(+), 1 deletion(-)
drivers/remoteproc/Kconfig +0 -0
index 96ce101..21d04f1 100644

[...]

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 52

Quoted 13 lines
drivers/remoteproc/Kconfig +9 -0
@@ -41,4 +41,28 @@ config STE_MODEM_RPROC
  	  This can be either built-in or a loadable module.
  	  If unsure say N.
 
+config DA8XX_REMOTEPROC
+	tristate "DA830/OMAPL137 & DA850/OMAPL138 remoteproc support (EXPERIMENTAL)"
+	depends on ARCH_DAVINCI_DA8XX
+	select REMOTEPROC
+	select RPMSG
+	select CMA
+	default n
+	help
+	  Say y here to support DA830/OMAPL137 & DA850/OMAPL138 remote

Naming nit: they're OMAP-L13x. Here and above.

WBR, Sergei

#3 lore raw

PATCH v8 3/7 ARM: davinci: Add support for configuring DA8XX_REMOTEPROC

In reply to a message not in the archive
Quoted 1 line · Robert Tivy

Also fix REMOTEPROC config to select FW_LOADER (instead of FW_CONFIG).

It is preferable to have the patch description make sense standalone even when read without the subject line.

Quoted 2 lines

Please follow the subject line conventions of the subsystem the patch is touching. This is not an ARM patch so the "ARM: davinci: " prefix in subject is surely wrong.

And I think I mentioned this once before but we want to see Kconfig/Makefile changes along with driver addition in the same patch.

Quoted 18 lines
---
 drivers/remoteproc/Kconfig |   26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
drivers/remoteproc/Kconfig +1 -1
index 96ce101..21d04f1 100644
@@ -5,7 +5,7 @@ config REMOTEPROC
 	tristate
 	depends on EXPERIMENTAL
 	depends on HAS_DMA
-	select FW_CONFIG
+	select FW_LOADER
 	select VIRTIO
 
 config OMAP_REMOTEPROC

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 49

Quoted 9 lines
drivers/remoteproc/Kconfig +6 -0
@@ -41,4 +41,28 @@ config STE_MODEM_RPROC
 	  This can be either built-in or a loadable module.
 	  If unsure say N.
 
+config DA8XX_REMOTEPROC
+	tristate "DA830/OMAPL137 & DA850/OMAPL138 remoteproc support (EXPERIMENTAL)"
+	depends on ARCH_DAVINCI_DA8XX
+	select REMOTEPROC
+	select RPMSG
+	select CMA

Its nice to keep the selects sorted. It helps avoid duplicates.

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 50

Quoted 1 line
drivers/remoteproc/Kconfig +1 -0
+	default n

No need of this I think, it should default to no already.

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 63

Quoted 13 lines
drivers/remoteproc/Kconfig +13 -0
+	help
+	  Say y here to support DA830/OMAPL137 & DA850/OMAPL138 remote
+	  processors via the remote processor framework.
+
+	  You want to say y here in order to enable AMP
+	  use-cases to run on your platform (multimedia codecs are
+	  offloaded to remote DSP processors using this framework).
+
+	  This module controls the name of the firmware file that gets
+	  loaded on the DSP.  This file must reside in the /lib/firmware
+	  directory.  It can be specified via the module parameter
+	  da8xx_fw_name=<filename>, and if not specified will default to
+	  "rproc-dsp-fw".

I hope running modinfo gives these details as well.

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 66

Quoted 3 lines
drivers/remoteproc/Kconfig +3 -0
+
+	  It's safe to say n here if you're not interested in multimedia
+	  offloading or just want a bare minimum kernel.

I think this is misleading a bit since just selecting 'n' here will not result in a "bare minimum kernel" - better to just avoid mention of it.

Thanks,
Sekhar

#4 lore raw

PATCH v8 3/7 ARM: davinci: Add support for configuring DA8XX_REMOTEPROC

Quoted 13 lines · Sekhar Nori
Quoted 12 lines · Robert Tivy
drivers/remoteproc/Kconfig +1 -1
index 96ce101..21d04f1 100644
@@ -5,7 +5,7 @@ config REMOTEPROC
 	tristate
 	depends on EXPERIMENTAL
 	depends on HAS_DMA
-	select FW_CONFIG
+	select FW_LOADER
 	select VIRTIO
 
Quoted 1 line

drivers/remoteproc/Kconfig config REMOTEPROC · line 11

Quoted 1 line
drivers/remoteproc/Kconfig +0 -0
 config OMAP_REMOTEPROC

This fixes the typo introduced in the typo introduced in (one line) commit e121aefa7d9f10eee5cf26ed47129237a05d940b ("remoteproc: fix missing CONFIG_FW_LOADER configurations"). That seems a separate issue. Can't it be submitted as a separate (one line) patch?

That would probably make it easier to get it into stable. Ohad has already stated that this would be a good idea.

Paul Bolle

#5 lore raw

PATCH v8 3/7 ARM: davinci: Add support for configuring DA8XX_REMOTEPROC

In reply to Sekhar Nori
Quoted 10 lines

-----Original Message-----
From: Nori, Sekhar
Sent: Monday, March 11, 2013 4:49 AM

Quoted 1 line · Robert Tivy

Also fix REMOTEPROC config to select FW_LOADER (instead of

FW_CONFIG).

It is preferable to have the patch description make sense standalone even when read without the subject line.

Will fix.

Quoted 8 lines
Quoted 3 lines

Please follow the subject line conventions of the subsystem the patch is
touching. This is not an ARM patch so the "ARM: davinci: " prefix in subject is surely wrong.

So even though it is a driver for just DA8XX, it should not get the "ARM: davinci:" prefix?

Is that mandated by the fact that it's in a general "driver" subdirectory?

Quoted 3 lines

And I think I mentioned this once before but we want to see Kconfig/Makefile changes along with driver addition in the same patch.

Yeah, I was confusing Ohad's feedback about the "fix" to Kconfig being in a separate patch. I will therefore put the "fix" (FW_CONFIG -> FW_LOADER) into its own patch, and group the driver's Kconfig additions with the driver and its Makefile.

Quoted 25 lines
Quoted 19 lines
---
 drivers/remoteproc/Kconfig |   26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
drivers/remoteproc/Kconfig +1 -1
index 96ce101..21d04f1 100644
@@ -5,7 +5,7 @@ config REMOTEPROC
 	tristate
 	depends on EXPERIMENTAL
 	depends on HAS_DMA
-	select FW_CONFIG
+	select FW_LOADER
 	select VIRTIO
 
 config OMAP_REMOTEPROC

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 45

Quoted 5 lines
drivers/remoteproc/Kconfig +2 -0
@@ -41,4 +41,28 @@ config STE_MODEM_RPROC
 	  This can be either built-in or a loadable module.
 	  If unsure say N.
 
+config DA8XX_REMOTEPROC
+	tristate "DA830/OMAPL137 & DA850/OMAPL138 remoteproc support

(EXPERIMENTAL)"

Quoted 6 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 49

Quoted 4 lines
drivers/remoteproc/Kconfig +4 -0
+	depends on ARCH_DAVINCI_DA8XX
+	select REMOTEPROC
+	select RPMSG
+	select CMA

Its nice to keep the selects sorted. It helps avoid duplicates.

Will fix.

Quoted 4 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 50

Quoted 2 lines
drivers/remoteproc/Kconfig +1 -0
+	default n

No need of this I think, it should default to no already.

OK.

Quoted 16 lines
Quoted 4 lines
drivers/remoteproc/Kconfig +3 -0
+	help
+	  Say y here to support DA830/OMAPL137 & DA850/OMAPL138 remote
+	  processors via the remote processor framework.

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 63

Quoted 10 lines
drivers/remoteproc/Kconfig +10 -0
+
+	  You want to say y here in order to enable AMP
+	  use-cases to run on your platform (multimedia codecs are
+	  offloaded to remote DSP processors using this framework).
+
+	  This module controls the name of the firmware file that gets
+	  loaded on the DSP.  This file must reside in the /lib/firmware
+	  directory.  It can be specified via the module parameter
+	  da8xx_fw_name=<filename>, and if not specified will default to
+	  "rproc-dsp-fw".

I hope running modinfo gives these details as well.

It will in the next patch :)

Quoted 7 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 66

Quoted 4 lines
drivers/remoteproc/Kconfig +3 -0
+
+	  It's safe to say n here if you're not interested in multimedia
+	  offloading or just want a bare minimum kernel.

I think this is misleading a bit since just selecting 'n' here will not result in a "bare minimum kernel" - better to just avoid mention of it.

Agreed, will drop.

Quoted 3 lines

Thanks,
Sekhar

Thanks & Regards,

- Rob

#6 lore raw

PATCH v8 3/7 ARM: davinci: Add support for configuringDA8XX_REMOTEPROC

Dear Sir,

Please don't send update emails to me

Whenever I need I can check from website

Thanks & Regards,
cstsai

----- Original Message -----
From: "Tivy, Robert" <[email protected]>
To: "Nori, Sekhar" <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Tuesday, March 12, 2013 4:26 AM
Subject: RE: [PATCH v8 3/7] ARM: davinci: Add support for configuringDA8XX_REMOTEPROC

Quoted 10 lines

-----Original Message-----
From: Nori, Sekhar
Sent: Monday, March 11, 2013 4:49 AM

Quoted 1 line · Robert Tivy

Also fix REMOTEPROC config to select FW_LOADER (instead of

FW_CONFIG).

It is preferable to have the patch description make sense standalone even when read without the subject line.

Will fix.

Quoted 8 lines
Quoted 3 lines

Please follow the subject line conventions of the subsystem the patch is
touching. This is not an ARM patch so the "ARM: davinci: " prefix in subject is surely wrong.

So even though it is a driver for just DA8XX, it should not get the "ARM:
davinci:" prefix?

Is that mandated by the fact that it's in a general "driver" subdirectory?

Quoted 3 lines

And I think I mentioned this once before but we want to see Kconfig/Makefile changes along with driver addition in the same patch.

Yeah, I was confusing Ohad's feedback about the "fix" to Kconfig being in a separate patch. I will therefore put the "fix" (FW_CONFIG -> FW_LOADER) into its own patch, and group the driver's Kconfig additions with the driver and its Makefile.

Quoted 25 lines
Quoted 19 lines
---
 drivers/remoteproc/Kconfig |   26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
drivers/remoteproc/Kconfig +1 -1
index 96ce101..21d04f1 100644
@@ -5,7 +5,7 @@ config REMOTEPROC
 tristate
 depends on EXPERIMENTAL
 depends on HAS_DMA
- select FW_CONFIG
+ select FW_LOADER
 select VIRTIO
 
 config OMAP_REMOTEPROC

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 45

Quoted 5 lines
drivers/remoteproc/Kconfig +2 -0
@@ -41,4 +41,28 @@ config STE_MODEM_RPROC
   This can be either built-in or a loadable module.
   If unsure say N.
 
+config DA8XX_REMOTEPROC
+ tristate "DA830/OMAPL137 & DA850/OMAPL138 remoteproc support

(EXPERIMENTAL)"

Quoted 6 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 49

Quoted 4 lines
drivers/remoteproc/Kconfig +4 -0
+ depends on ARCH_DAVINCI_DA8XX
+ select REMOTEPROC
+ select RPMSG
+ select CMA

Its nice to keep the selects sorted. It helps avoid duplicates.

Will fix.

Quoted 4 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 50

Quoted 2 lines
drivers/remoteproc/Kconfig +1 -0
+ default n

No need of this I think, it should default to no already.

OK.

Quoted 16 lines
Quoted 4 lines
drivers/remoteproc/Kconfig +3 -0
+ help
+   Say y here to support DA830/OMAPL137 & DA850/OMAPL138 remote
+   processors via the remote processor framework.

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 63

Quoted 10 lines
drivers/remoteproc/Kconfig +10 -0
+
+   You want to say y here in order to enable AMP
+   use-cases to run on your platform (multimedia codecs are
+   offloaded to remote DSP processors using this framework).
+
+   This module controls the name of the firmware file that gets
+   loaded on the DSP.  This file must reside in the /lib/firmware
+   directory.  It can be specified via the module parameter
+   da8xx_fw_name=<filename>, and if not specified will default to
+   "rproc-dsp-fw".

I hope running modinfo gives these details as well.

It will in the next patch :)

Quoted 7 lines

drivers/remoteproc/Kconfig config STE_MODEM_RPROC · line 66

Quoted 4 lines
drivers/remoteproc/Kconfig +3 -0
+
+   It's safe to say n here if you're not interested in multimedia
+   offloading or just want a bare minimum kernel.

I think this is misleading a bit since just selecting 'n' here will not result in a "bare minimum kernel" - better to just avoid mention of it.

Agreed, will drop.

Quoted 3 lines

Thanks,
Sekhar

Thanks & Regards,

- Rob

_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source at linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

====================================================================
This email may contain confidential information. Please do not use or disclose it in any way and delete it if you are not the intended recipient.