Skip to contentSkip to conversation

Do not attempt to output a NULL message

PATCH New Peter Rosin 1 participant 1 message Mar 10, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Do not attempt to output a NULL message

Prevent future problems, as noone calls exverror with a NULL msg at this time.

---
 src/error.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

I stumbled on this when reading the code... Or is msg only ever NULL when DEBUG is #defined?

Cheers,
Peter

src/error.c +1 -1
index 9d31989..5ab69c0 100644
@@ -151,8 +151,8 @@ exverror(int cond, const char *msg, va_list ap)
 		TRACE(("\") pid=%d\n", getpid()));
 	} else
 		TRACE(("exverror(%d, NULL) pid=%d\n", cond, getpid()));
-	if (msg)
 #endif
+	if (msg)
 		exvwarning(-1, msg, ap);
 
 	flushall();
Signature · 1 line
1.7.9