Skip to contentSkip to conversation

->[PATCH v2] kgdb: Removed kmalloc returned value cast

PATCH In review Alex Grad 2 participants 3 messages Mar 10, 2013 – Mar 11, 2013 PowerPC

lore
Share & tools
lore

Alex Grad

author
#0 lore raw

PATCH 1/1 ->[PATCH v2] kgdb: Removed kmalloc returned value cast

While at it, check kmalloc return value.

---
 arch/powerpc/kernel/kgdb.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/powerpc/kernel/kgdb.c +4 -1
index 5ca82cd..9e81dd8 100644
@@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
 	if (user_mode(regs))
 		return 0;
 
-	backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+	backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+	if (!backup_current_thread_info)
+		return -ENOMEM;
+
 	/*
 	 * On Book E and perhaps other processors, singlestep is handled on
 	 * the critical exception stack.  This causes current_thread_info()
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 12 lines · Alex Grad

While at it, check kmalloc return value.

---
  arch/powerpc/kernel/kgdb.c |    5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
arch/powerpc/kernel/kgdb.c +0 -0
index 5ca82cd..9e81dd8 100644

arch/powerpc/kernel/kgdb.c static int kgdb_singlestep(struct pt_regs *regs) · line 164

Quoted 7 lines
arch/powerpc/kernel/kgdb.c +3 -1
@@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
  	if (user_mode(regs))
  		return 0;
 
-	backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+	backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+	if (!backup_current_thread_info)
+		return -ENOMEM;

I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying the thread_info" to remove these stuff since its unnecessary to copy current thread_info now.

Tiejun

#2 lore raw
Quoted 16 lines · tiejun.chen
Quoted 15 lines · Alex Grad

While at it, check kmalloc return value.

---
  arch/powerpc/kernel/kgdb.c |    5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
arch/powerpc/kernel/kgdb.c +0 -0
index 5ca82cd..9e81dd8 100644
@@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
      if (user_mode(regs))
          return 0;
 
Quoted 10 lines

arch/powerpc/kernel/kgdb.c static int kgdb_singlestep(struct pt_regs *regs) · line 166

Quoted 6 lines
arch/powerpc/kernel/kgdb.c +3 -1
-    backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct
 thread_info), GFP_KERNEL);
+    backup_current_thread_info = kmalloc(sizeof(struct thread_info),
 GFP_KERNEL);
+    if (!backup_current_thread_info)
+        return -ENOMEM;

I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying the thread_info" to remove these stuff since its unnecessary to copy current thread_info now.

I guess that patchset needs to be reviewed with more time and I also think I can leave this copying to be compatible for other platforms in the future, but we really should fix this problem I introduced right now. So I'd like to fix this with DEFINE_PER_CPU.

I send a patch, "powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's thread_info", so please take a look at if that version is fine to every one.

Any comments are appreciated.

BTW, I will update that kgdb patchset with this change to resend.

Tiejun