Skip to contentSkip to conversation

wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup

PATCH In review Andrei Epure 2 participants 2 messages Mar 10, 2013 – Mar 11, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup

---
 drivers/net/wireless/rtlwifi/usb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/rtlwifi/usb.c +1 -2
index 156b527..b5c80b5 100644
@@ -224,10 +224,9 @@ static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
 	u8 *buffer;
 
 	wvalue = (u16)(addr & 0x0000ffff);
-	buffer = kmalloc(len, GFP_ATOMIC);
+	buffer = kmemdup(data, len, GFP_ATOMIC);
 	if (!buffer)
 		return;
-	memcpy(buffer, data, len);
 	usb_control_msg(udev, pipe, request, reqtype, wvalue,
 			index, buffer, len, 50);
 
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Andrei Epure
---
  drivers/net/wireless/rtlwifi/usb.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/rtlwifi/usb.c +0 -0
index 156b527..b5c80b5 100644

drivers/net/wireless/rtlwifi/usb.c static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data, · line 231

Quoted 10 lines
drivers/net/wireless/rtlwifi/usb.c +1 -2
@@ -224,10 +224,9 @@ static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
  	u8 *buffer;
 
  	wvalue = (u16)(addr & 0x0000ffff);
-	buffer = kmalloc(len, GFP_ATOMIC);
+	buffer = kmemdup(data, len, GFP_ATOMIC);
  	if (!buffer)
  		return;
-	memcpy(buffer, data, len);
  	usb_control_msg(udev, pipe, request, reqtype, wvalue,
  			index, buffer, len, 50);

Thanks,

Larry