Skip to contentSkip to conversation

EXYNOS: Correct ordering of SPL machine_params

PATCH New Rajeshwari Shinde 3 participants 3 messages Feb 19, 2013 – Mar 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EXYNOS: Correct ordering of SPL machine_params

From: Simon Glass <[email protected]>

The mem_manuf is not in the correct order according to the string table. This causes cros_bundle_firmware to get the BL2 settings in the wrong order. This patch fixes the same.

---
 arch/arm/include/asm/arch-exynos/spl.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-exynos/spl.h +2 -1
index 306b41d..46b25a6 100644
@@ -78,11 +78,12 @@ struct spl_machine_param {
 	 */
 	u32		uboot_size;
 	enum boot_mode	boot_source;	/* Boot device */
-	enum mem_manuf	mem_manuf;	/* Memory Manufacturer */
 	unsigned	frequency_mhz;	/* Frequency of memory in MHz */
 	unsigned	arm_freq_mhz;	/* ARM Frequency in MHz */
 	u32		serial_base;	/* Serial base address */
 	u32		i2c_base;	/* i2c base address */
+	u32		board_rev_gpios;	/* Board revision GPIOs */
+	enum mem_manuf	mem_manuf;	/* Memory Manufacturer */
 } __attribute__((__packed__));
 #endif
 
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/1 EXYNOS: Correct ordering of SPL machine_params

Quoted 8 lines · Rajeshwari Shinde

From: Simon Glass <[email protected]>

The mem_manuf is not in the correct order according to the string table. This causes cros_bundle_firmware to get the BL2 settings in the wrong order. This patch fixes the same.

Quoted 25 lines
---
 arch/arm/include/asm/arch-exynos/spl.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-exynos/spl.h +2 -2
index 306b41d..46b25a6 100644
@@ -78,11 +78,12 @@ struct spl_machine_param {
         */
        u32             uboot_size;
        enum boot_mode  boot_source;    /* Boot device */
-       enum mem_manuf  mem_manuf;      /* Memory Manufacturer */
        unsigned        frequency_mhz;  /* Frequency of memory in MHz */
        unsigned        arm_freq_mhz;   /* ARM Frequency in MHz */
        u32             serial_base;    /* Serial base address */
        u32             i2c_base;       /* i2c base address */
+       u32             board_rev_gpios;        /* Board revision GPIOs */
+       enum mem_manuf  mem_manuf;      /* Memory Manufacturer */
 } __attribute__((__packed__));
 #endif
 
--

1.7.4.4

#2 lore raw

PATCH 1/1 EXYNOS: Correct ordering of SPL machine_params

In reply to Rajeshwari Shinde
Quoted 21 lines · Rajeshwari Shinde

From: Simon Glass <[email protected]>

The mem_manuf is not in the correct order according to the string table. This causes cros_bundle_firmware to get the BL2 settings in the wrong order. This patch fixes the same.

---
 arch/arm/include/asm/arch-exynos/spl.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-exynos/spl.h +0 -0
index 306b41d..46b25a6 100644
@@ -78,11 +78,12 @@ struct spl_machine_param {
 	 */
 	u32		uboot_size;
 	enum boot_mode	boot_source;	/* Boot device */

arch/arm/include/asm/arch-exynos/spl.h struct spl_machine_param { · line 89

Quoted 10 lines
arch/arm/include/asm/arch-exynos/spl.h +2 -1
-	enum mem_manuf	mem_manuf;	/* Memory Manufacturer */
 	unsigned	frequency_mhz;	/* Frequency of memory in MHz */
 	unsigned	arm_freq_mhz;	/* ARM Frequency in MHz */
 	u32		serial_base;	/* Serial base address */
 	u32		i2c_base;	/* i2c base address */
+	u32		board_rev_gpios;	/* Board revision GPIOs */
+	enum mem_manuf	mem_manuf;	/* Memory Manufacturer */
 } __attribute__((__packed__));
 #endif
 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.