Skip to contentSkip to conversation

xfs_repair: remove unconditional ASSERT(0)

PATCH In review Eric Sandeen 2 participants 2 messages Mar 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_repair: remove unconditional ASSERT(0)

I don't know what I was thinking in 7e8e3cc, but I added an ASSERT(0) in the main path. Obviously this isn't right.

Just remove it.

---

Really sorry, no idea what is up w/ my brain lately. Trying to do too many things at once, too quickly.

repair/scan.c +1 -2
index 6a62dff..76bb7f1 100644
@@ -1076,8 +1076,7 @@ scan_freelist(
 				  "freelist scan\n"), i);
 			return;
 		}
-	} else /* should have been fixed in verify_set_agf() */
-		ASSERT(0);
+	}
 
 	count = 0;
 	for (;;) {

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Eric Sandeen

I don't know what I was thinking in 7e8e3cc, but I added an ASSERT(0) in the main path. Obviously this isn't right.

Just remove it.

---

Really sorry, no idea what is up w/ my brain lately. Trying to do too many things at once, too quickly.

I can relate. Thanks for the quick fix.

Looks good:

This has been committed.

Thanks
--Rich

commit b326e067f1005d584bd8ad21bb9f3e2700230e29

Author: Eric Sandeen <[email protected]>
Date:   Tue Mar 12 14:50:21 2013 +0000

xfsprogs xfs_repair: remove unconditional ASSERT(0)

I don't know what I was thinking in 7e8e3cc, but I added an ASSERT(0) in the main path. Obviously this isn't right.

Just remove it.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs