add a function to find non-zero content in a buffer
RFC PATCH 2/9 add a function to find non-zero content in a buffer
Signed-off-by Peter Lieven <[email protected]>
--- include/qemu-common.h | 1 + util/cutils.c | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+)
include/qemu-common.h +1 -0
@@ -362,6 +362,7 @@ size_t qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset,size_t qemu_iovec_memset (QEMUIOVector *qiov,size_t offset,int fillc,size_t bytes); +size_t buffer_find_nonzero_offset (const void *buf,size_t len);bool buffer_is_zero (const void *buf,size_t len);void qemu_progress_init (int enabled,float min_skip);
util/cutils.c +30 -0
@@ -143,6 +143,36 @@ int qemu_fdatasync(int fd) }/* +* Searches for an area with non-zero content in a buffer +* +* Attention! The len must be a multiple of 8 * sizeof(VECTYPE) +* and addr must bedue to restriction of optimizations in this function. +* +* The return value is the offset of the non-zero area rounded +* down to 8 * sizeof(VECTYPE). If the buffer is all zero +* the return value is equal to len. +*/ + +size_t buffer_find_nonzero_offset (const void *buf,size_t len) +{ +VECTYPE *p = (VECTYPE *)buf; +VECTYPE zero =ZERO_SPLAT ; +size_t i; +for (i =0 ; i < len /sizeof (VECTYPE ); i +=8 ) { +VECTYPE tmp0 = p[i+0 ] | p[i+1 ]; +VECTYPE tmp1 = p[i+2 ] | p[i+3 ]; +VECTYPE tmp2 = p[i+4 ] | p[i+5 ]; +VECTYPE tmp3 = p[i+6 ] | p[i+7 ]; +VECTYPE tmp01 = tmp0 | tmp1; +VECTYPE tmp23 = tmp2 | tmp3; +if (!ALL_EQ (tmp01 | tmp23, zero)) { +break ; + } + } +return i *sizeof (VECTYPE ); +} + +/* * Checks if a buffer is all zeroes * * Attention! The len must be a multiple of 4 * sizeof(long) due to
Signature · 1 line
1.7.9.5
Quoted 8 lines · Peter Lieven
Signed-off-by Peter Lieven <[email protected]>--- include/qemu-common.h | 1 + util/cutils.c | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+)
Quoted 5 lines
/*
+ * Searches for an area with non-zero content in a buffer
+ *
+ * Attention! The len must be a multiple of 8 * sizeof(VECTYPE)
+ * and addr must bedue to restriction of optimizations in this function.
s/bedue/be XXX due/
don't know what XXX is supposed to be. Instead of stating this in a comment...
util/cutils.c int qemu_fdatasync(int fd) · line 157
Quoted 8 lines
+ *
+ * The return value is the offset of the non-zero area rounded
+ * down to 8 * sizeof(VECTYPE). If the buffer is all zero
+ * the return value is equal to len.
+ */util/cutils.c +3
-0+ +size_t buffer_find_nonzero_offset (const void *buf,size_t len) +{
...why not instead assert() it as part of the contract?
Quoted 11 lines
util/cutils.c +11
-0+VECTYPE *p = (VECTYPE *)buf; +VECTYPE zero =ZERO_SPLAT ; +size_t i; +for (i =0 ; i < len /sizeof (VECTYPE ); i +=8 ) { +VECTYPE tmp0 = p[i+0 ] | p[i+1 ]; +VECTYPE tmp1 = p[i+2 ] | p[i+3 ]; +VECTYPE tmp2 = p[i+4 ] | p[i+5 ]; +VECTYPE tmp3 = p[i+6 ] | p[i+7 ]; +VECTYPE tmp01 = tmp0 | tmp1; +VECTYPE tmp23 = tmp2 | tmp3; +if (!ALL_EQ (tmp01 | tmp23, zero)) {
util/cutils.c int qemu_fdatasync(int fd) · line 178
Quoted 10 lines
util/cutils.c +7
-0+break ; + } + } +return i *sizeof (VECTYPE ); +} + +/* * Checks if a buffer is all zeroes * * Attention! The len must be a multiple of 4 * sizeof(long) due to
oh, probably because of copy and paste.
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org