Skip to contentSkip to conversation

migration: use XBZRLE only after bulk stage

RFC PATCH In review Peter Lieven 2 participants 2 messages Mar 12, 2013

lore
Share & tools
lore
#0 lore raw

RFC PATCH 6/9 migration: use XBZRLE only after bulk stage

at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed.

currently all these pages are copied to the page cache regardless if there are frequently updated or not. this doesn't make sense since most of these pages are never transferred again.

this patch changes the XBZRLE transfer to only be used after the bulk stage has been completed. that means a page is added to the page cache the second time it is transferred and XBZRLE can benefit from the third time of transfer.

since the page cache is likely smaller than the number of pages its also likely that in the second round the page is missing in the cache due to collisions in the bulk phase.

on the other hand a lot of unneccssary mallocs, memdups and frees are saved.

---
 arch_init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch_init.c +1 -1
index 3d09327..04c82e4 100644
@@ -451,7 +451,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
                                             RAM_SAVE_FLAG_COMPRESS);
                 qemu_put_byte(f, *p);
                 bytes_sent += 1;
-            } else if (migrate_use_xbzrle()) {
+            } else if (!ram_bulk_stage && migrate_use_xbzrle()) {
                 current_addr = block->offset + offset;
                 bytes_sent = save_xbzrle_page(f, p, current_addr, block,
                                               offset, cont, last_stage);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 12 lines · Peter Lieven

at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed.

currently all these pages are copied to the page cache regardless if there are frequently updated or not. this doesn't make sense since most of these pages are never transferred again.

this patch changes the XBZRLE transfer to only be used after the bulk stage has been completed. that means a page is added to the page cache the second time it is transferred and XBZRLE can benefit from the third time of transfer.

Quoted 5 lines

since the page cache is likely smaller than the number of pages its also likely that in the second round the page is missing in the cache due to collisions in the bulk phase.

on the other hand a lot of unneccssary mallocs, memdups and frees

s/unneccssary/unnecessary/

Quoted 1 line

are saved.

Earlier, I asked you for some benchmark numbers, and you provided some.
Mentioning them in the commit message will make an even stronger
argument for including this patch.

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org