Add a LOADADDR= option when building uImage
RFC PATCH 1/1 Add a LOADADDR= option when building uImage
From: Julien Boibessot <[email protected]>
This seems mandatory in recent Linux kernels configured with ARCH_MULTIPLATFORM (well at least on ARM/i.MX).
If LOADADDR variable is not set when building multi-arch uImage then a dummy loadaddr is used, that prevent this image to boot in U-Boot (2012.04 in my case).
Anyone else who need the same fix ?
--- linux/Config.in | 8 ++++++++ linux/linux.mk | 4 ++++ 2 files changed, 12 insertions(+), 0 deletions(-)
linux/Config.in +8 -0
@@ -213,6 +213,14 @@ config BR2_LINUX_KERNEL_IMAGE_TARGET_NAME Specify the kernel make target to build the kernel that you need. +config BR2_LINUX_KERNEL_UIMAGE_LOADADDR + string "loadaddr for uImage" + depends on BR2_LINUX_KERNEL_UIMAGE || BR2_LINUX_KERNEL_APPENDED_UIMAGE + help + When configured for multi-arch support, it is mandatory to define + LOADADDR=0x... when asking recent kernels to generate a uImage. + Let this option empty if your kernel is single-arch only. + config BR2_LINUX_KERNEL_DTS_SUPPORT bool "Device tree support" help
linux/linux.mk +4 -0
@@ -95,6 +95,10 @@ LINUX_IMAGE_NAME=vmlinuz endif endif +ifeq ($(LINUX_IMAGE_NAME),uImage) +LINUX_MAKE_FLAGS+=LOADADDR=$(call qstrip,$(BR2_LINUX_KERNEL_UIMAGE_LOADADDR)) +endif + ifeq ($(BR2_LINUX_KERNEL_APPENDED_DTB),y) LINUX_IMAGE_TARGET=zImage else
Signature · 1 line
1.7.5.4
RFC PATCH 1/1 Add a LOADADDR= option when building uImage
Julien,
I would appreciate this patch because I spent a lot of time discovering LOADADDR and this would have really helped me. My suggestions:
1) Should this variable be exposed only for ARM for now? ("depends on BR2_arm || BR2_armeb")
2) Should this variable only be exposed for linux versions >= 3.7? 3.7 is when CONFIG_ARCH_MULTIPLATFORM appears.
3) The description in the help text might not help someone new to this topic (like me). I would suggest something like:
"If your ARM system's kernel is configured via the new (3.7+) multi-architecture support (CONFIG_ARCH_MULTIPLATFORM=y in your linux kernel .config), then it is necessary to specify a kernel load address for the uImage. This should be a hexadecimal string beginning with 0x. Example setting: 0x00008000."
Thanks and best of luck,
-dp
Quoted 52 lines · On Mon, Mar 11, 2013 at 3:35 AM, <[email protected]> wrote:
From: Julien Boibessot <[email protected]>
This seems mandatory in recent Linux kernels configured with
ARCH_MULTIPLATFORM(well at least on ARM/i.MX).
If LOADADDR variable is not set when building multi-arch uImage then a dummy loadaddr is used, that prevent this image to boot in U-Boot (2012.04 in my case).
Anyone else who need the same fix ?Signed-off-by Julien Boibessot <[email protected]>--- linux/Config.in | 8 ++++++++ linux/linux.mk | 4 ++++ 2 files changed, 12 insertions(+), 0 deletions(-)linux/Config.in +8
-0@@ -213,6 +213,14 @@ config BR2_LINUX_KERNEL_IMAGE_TARGET_NAME Specify the kernel make target to build the kernel that you need. +config BR2_LINUX_KERNEL_UIMAGE_LOADADDR + string "loadaddr for uImage" + depends on BR2_LINUX_KERNEL_UIMAGE || BR2_LINUX_KERNEL_APPENDED_UIMAGE + help + When configured for multi-arch support, it is mandatory to define + LOADADDR=0x... when asking recent kernels to generate a uImage. + Let this option empty if your kernel is single-arch only. + config BR2_LINUX_KERNEL_DTS_SUPPORT bool "Device tree support" helplinux/linux.mk +4
-1@@ -95,6 +95,10 @@ LINUX_IMAGE_NAME=vmlinuz endif endif +ifeq ($(LINUX_IMAGE_NAME),uImage) +LINUX_MAKE_FLAGS+=LOADADDR=$(call qstrip,$(BR2_LINUX_KERNEL_UIMAGE_LOADADDR)) +endif + ifeq ($(BR2_LINUX_KERNEL_APPENDED_DTB),y) LINUX_IMAGE_TARGET=zImage else --1.7.5.4
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
--
Daniel.Price at gmail.com; Twitter: @danielbprice
RFC PATCH 1/1 Add a LOADADDR= option when building uImage
Hello Daniel,
Quoted 5 lines · Daniel Price
Julien,
I would appreciate this patch because I spent a lot of time discovering LOADADDR and this would have really helped me. My suggestions:
thanks for your feedback !
Quoted 2 lines
1) Should this variable be exposed only for ARM for now? ("depends on
BR2_arm||BR2_armeb")
yes, I will do
Quoted 2 lines
2) Should this variable only be exposed for linux versions >= 3.7? 3.7 is when
CONFIG_ARCH_MULTIPLATFORMappears.
yes, but I don't know how to do that.
any idea ?
Quoted 8 lines
3) The description in the help text might not help someone new to this topic (like me). I would suggest something like:
"If your ARM system's kernel is configured via the new (3.7+) multi-architecture support (
CONFIG_ARCH_MULTIPLATFORM=yin your linux kernel .config), then it is necessary to specify a kernel load address for the uImage. This should be a hexadecimal string beginning with 0x. Example setting:0x00008000."
yes that's better than mine.
I'm just trying to figure out how to depend from CONFIG_ARCH_MULTIPLATFORM and then I will send a new version of my patch.
Thanks !
Regards,
Julien
RFC PATCH 1/1 Add a LOADADDR= option when building uImage
Quoted 4 lines · Julien Boibessot
Hello Daniel,
Quoted 1 line · Daniel Price
Julien,
[snip]
Quoted 5 lines
Quoted 2 lines
2) Should this variable only be exposed for linux versions >= 3.7? 3.7 is when
CONFIG_ARCH_MULTIPLATFORMappears.yes, but I don't know how to do that.
any idea ?
That's not currently possible in buildroot. It's impossible to derive
that automatically at configure time.
Quoted 9 lines
Quoted 8 lines
3) The description in the help text might not help someone new to this topic (like me). I would suggest something like:
"If your ARM system's kernel is configured via the new (3.7+) multi-architecture support (
CONFIG_ARCH_MULTIPLATFORM=yin your linux kernel .config), then it is necessary to specify a kernel load address for the uImage. This should be a hexadecimal string beginning with 0x. Example setting:0x00008000."
Quoted 3 lines
yes that's better than mine.
I'm just trying to figure out how to depend fromCONFIG_ARCH_MULTIPLATFORMand then I will send a new version of my patch.
Also not possible, because the kernel configuration is separate from
the buildroot configuration.
Having an extensive help text is generally considered sufficient.
Perhaps the prompt could be a bit more explicit still, e.g. "load
address (for multi-platform image)" (note that the reference to U-Boot is redundant since it's already a dependency).
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F