ARM: dts: tegra: add the PM configurations of PMC
Subsystems (2)
PATCH v2 9/9 ARM: dts: tegra: add the PM configurations of PMC
Adding the PM configuration of PMC when the platform support suspend function.
---
V2:
* no change
--- arch/arm/boot/dts/tegra20-harmony.dts | 6 ++++++ arch/arm/boot/dts/tegra20-paz00.dts | 7 +++++++ arch/arm/boot/dts/tegra20-seaboard.dts | 6 ++++++ arch/arm/boot/dts/tegra20-trimslice.dts | 9 +++++++++ arch/arm/boot/dts/tegra20-ventana.dts | 6 ++++++ arch/arm/boot/dts/tegra20-whistler.dts | 8 ++++++++ arch/arm/boot/dts/tegra30-beaver.dts | 7 +++++++ arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++ 8 files changed, 56 insertions(+)
arch/arm/boot/dts/tegra20-harmony.dts +6 -0
@@ -416,6 +416,12 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>; + nvidia,cpu-pwr-off-time = <5000>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <3875>; + nvidia,sys-clock-req-active-high; }; usb at c5000000 {
arch/arm/boot/dts/tegra20-paz00.dts +7 -0
@@ -415,6 +415,13 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>; + nvidia,cpu-pwr-off-time = <5000>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <3875>; + nvidia,sys-clock-req-active-high; + nvidia,combined-power-req; }; usb at c5000000 {
arch/arm/boot/dts/tegra20-seaboard.dts +6 -0
@@ -517,6 +517,12 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>; + nvidia,cpu-pwr-off-time = <5000>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <3875>; + nvidia,sys-clock-req-active-high; }; memory-controller at 7000f400 {
arch/arm/boot/dts/tegra20-trimslice.dts +9 -0
@@ -300,6 +300,15 @@ }; }; + pmc { + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>; + nvidia,cpu-pwr-off-time = <5000>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <3875>; + nvidia,sys-clock-req-active-high; + }; + usb at c5000000 { status = "okay"; nvidia,vbus-gpio = <&gpio 170 0>; /* gpio PV2 */
arch/arm/boot/dts/tegra20-ventana.dts +6 -0
@@ -493,6 +493,12 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <2000>; + nvidia,cpu-pwr-off-time = <100>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <458>; + nvidia,sys-clock-req-active-high; }; usb at c5000000 {
arch/arm/boot/dts/tegra20-whistler.dts +8 -0
@@ -496,6 +496,14 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <2000>; + nvidia,cpu-pwr-off-time = <1000>; + nvidia,core-pwr-good-time = <0 3845>; + nvidia,core-pwr-off-time = <93727>; + nvidia,core-power-req-active-high; + nvidia,sys-clock-req-active-high; + nvidia,combined-power-req; }; usb at c5000000 {
arch/arm/boot/dts/tegra30-beaver.dts +7 -0
@@ -253,6 +253,13 @@ pmc { status = "okay"; nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <2000>; + nvidia,cpu-pwr-off-time = <200>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <0>; + nvidia,core-power-req-active-high; + nvidia,sys-clock-req-active-high; }; sdhci at 78000000 {
arch/arm/boot/dts/tegra30-cardhu.dtsi +7 -0
@@ -307,6 +307,13 @@ pmc { status = "okay"; nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <2000>; + nvidia,cpu-pwr-off-time = <200>; + nvidia,core-pwr-good-time = <3845 3845>; + nvidia,core-pwr-off-time = <0>; + nvidia,core-power-req-active-high; + nvidia,sys-clock-req-active-high; }; sdhci at 78000000 {
Signature · 1 line
1.8.1.5
PATCH v2 9/9 ARM: dts: tegra: add the PM configurations of PMC
Joseph,
Am Dienstag, 12. M?rz 2013, 12:04:03 schrieb Joseph Lo:
Quoted 25 lines
Adding the PM configuration of PMC when the platform support suspend function.
Signed-off-by Joseph Lo <[email protected]>---
V2:
* no change--- arch/arm/boot/dts/tegra20-harmony.dts | 6 ++++++ arch/arm/boot/dts/tegra20-paz00.dts | 7 +++++++ arch/arm/boot/dts/tegra20-seaboard.dts | 6 ++++++ arch/arm/boot/dts/tegra20-trimslice.dts | 9 +++++++++ arch/arm/boot/dts/tegra20-ventana.dts | 6 ++++++ arch/arm/boot/dts/tegra20-whistler.dts | 8 ++++++++ arch/arm/boot/dts/tegra30-beaver.dts | 7 +++++++ arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++ 8 files changed, 56 insertions(+)[...]
(quoted diff) +0
-0
b/arch/arm/boot/dts/tegra20-paz00.dtsindex 41e82e3..cd8e798 100644
arch/arm/boot/dts/tegra20-paz00.dts line 419
Quoted 5 lines
arch/arm/boot/dts/tegra20-paz00.dts +2
-0@@ -415,6 +415,13 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>;
should be 2000
arch/arm/boot/dts/tegra20-paz00.dts line 420
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,cpu-pwr-off-time = <5000>;
should be 0
arch/arm/boot/dts/tegra20-paz00.dts line 421
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,core-pwr-good-time = <3845 3845>;
mmh, no idea here. original source [1] shows 0x7e7e ticks which translates to 1 sec?
arch/arm/boot/dts/tegra20-paz00.dts line 422
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,core-pwr-off-time = <3875>;
should be 0
arch/arm/boot/dts/tegra20-paz00.dts line 424
Quoted 2 lines
arch/arm/boot/dts/tegra20-paz00.dts +2
-0+ nvidia,sys-clock-req-active-high; + nvidia,combined-power-req;
paz00 has no combined power req.
arch/arm/boot/dts/tegra20-paz00.dts line 427
Quoted 3 lines
arch/arm/boot/dts/tegra20-paz00.dts +0
-0}; usb at c5000000 {
Marc
PATCH v2 9/9 ARM: dts: tegra: add the PM configurations of PMC
Hi Marc,
Quoted 34 lines · Marc Dietrich
Am Dienstag, 12. M?rz 2013, 12:04:03 schrieb Joseph Lo:
Quoted 25 lines
Adding the PM configuration of PMC when the platform support suspend function.
Signed-off-by Joseph Lo <[email protected]>---
V2:
* no change--- arch/arm/boot/dts/tegra20-harmony.dts | 6 ++++++ arch/arm/boot/dts/tegra20-paz00.dts | 7 +++++++ arch/arm/boot/dts/tegra20-seaboard.dts | 6 ++++++ arch/arm/boot/dts/tegra20-trimslice.dts | 9 +++++++++ arch/arm/boot/dts/tegra20-ventana.dts | 6 ++++++ arch/arm/boot/dts/tegra20-whistler.dts | 8 ++++++++ arch/arm/boot/dts/tegra30-beaver.dts | 7 +++++++ arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++ 8 files changed, 56 insertions(+)[...]
(quoted diff) +0
-0
b/arch/arm/boot/dts/tegra20-paz00.dtsindex 41e82e3..cd8e798 100644arch/arm/boot/dts/tegra20-paz00.dts line 419
Quoted 5 lines
arch/arm/boot/dts/tegra20-paz00.dts +2
-0@@ -415,6 +415,13 @@ pmc { nvidia,invert-interrupt; + nvidia,suspend-mode = <2>; + nvidia,cpu-pwr-good-time = <5000>;should be 2000
Quoted 9 lines
arch/arm/boot/dts/tegra20-paz00.dts line 420
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,cpu-pwr-off-time = <5000>;should be 0
arch/arm/boot/dts/tegra20-paz00.dts line 421
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,core-pwr-good-time = <3845 3845>;mmh, no idea here. original source [1] shows
0x7e7eticks which translates to 1 sec?
The ticks was based on the 32KHz clock domain. I translate it to uS.
Quoted 9 lines
arch/arm/boot/dts/tegra20-paz00.dts line 422
Quoted 1 line
arch/arm/boot/dts/tegra20-paz00.dts +1
-0+ nvidia,core-pwr-off-time = <3875>;should be 0
arch/arm/boot/dts/tegra20-paz00.dts line 424
Quoted 2 lines
arch/arm/boot/dts/tegra20-paz00.dts +2
-0+ nvidia,sys-clock-req-active-high; + nvidia,combined-power-req;paz00 has no combined power req.
Quoted 6 lines
arch/arm/boot/dts/tegra20-paz00.dts line 427
Quoted 3 lines
arch/arm/boot/dts/tegra20-paz00.dts +0
-0}; usb at c5000000 {
Thanks for your review and point me out the detail information about paz00 board.
Joseph
PATCH v2 9/9 ARM: dts: tegra: add the PM configurations of PMC
Quoted 7 lines · Joseph Lo
Hi Marc,
Quoted 3 lines · Marc Dietrich
Am Dienstag, 12. M?rz 2013, 12:04:03 schrieb Joseph Lo:
Quoted 2 lines
Adding the PM configuration of PMC when the platform support suspend function.
Quoted 8 lines
Quoted 5 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ nvidia,core-pwr-good-time = <3845 3845>;mmh, no idea here. original source [1] shows
0x7e7eticks which translates to 1 sec?The ticks was based on the 32KHz clock domain. I translate it to uS.
Quoted 1 line
Quoted 1 line
0x7e7e* (1.0/32000) * 1000000
1011937.4999999999
Oh, I suppose perhaps the 0x7e7e value is both values packed together, so this should be:
Quoted 1 line
Quoted 1 line
Quoted 1 line
0x7e* (1.0/32000) * 1000000
3937.5
PATCH v2 9/9 ARM: dts: tegra: add the PM configurations of PMC
Quoted 15 lines · Stephen Warren
Quoted 13 lines · Joseph Lo
Hi Marc,
Quoted 9 lines · Marc Dietrich
Am Dienstag, 12. M?rz 2013, 12:04:03 schrieb Joseph Lo:
Review
Quoted 4 lines
Adding the PM configuration of PMC when the platform support suspend function.
(quoted diff) +1
-0+ nvidia,core-pwr-good-time = <3845 3845>;mmh, no idea here. original source [1] shows
0x7e7eticks which translates to 1 sec?The ticks was based on the 32KHz clock domain. I translate it to uS.
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
0x7e7e* (1.0/32000) * 10000001011937.4999999999
Oh, I suppose perhaps the
0x7e7evalue is both values packed together, so this should be:Quoted 1 line
Quoted 1 line
Quoted 1 line
0x7e* (1.0/32000) * 10000003937.5
Yes.
0x7e * (1.0/32768) * 1000000 = 3845
Thanks,
Joseph