net_sched: don't do precise pkt_len computation for untrusted packets
Subsystems (2)
PATCH 1/2 net_sched: don't do precise pkt_len computation for untrusted packets
Commit 1def9238d4aa2 (net_sched: more precise pkt_len computation) tries to do precise packet len computation for GSO packets, but it does not check whether the packets were from untrusted source. This is wrong since: we haven't done header check before so both gso_segs and headers may not be correct. So this patch just bypass the precise pkt_len computation for packet from untrusted source (SKB_GSO_DODGY).
--- net/core/dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/core/dev.c +1 -1
@@ -2586,7 +2586,7 @@ static void qdisc_pkt_len_init(struct sk_buff *skb)/* To get more precise estimation of bytes sent on wire, * we add to pkt_len the headers size of all segments */ -if (shinfo->gso_size) { +if (shinfo->gso_size && !(shinfo->gso_type &SKB_GSO_DODGY )) {unsigned int hdr_len;/* mac layer + network layer */
Signature · 1 line
1.7.1
PATCH 2/2 net: reset transport header if it was not set before transmission
Some drivers depends on transport_header to do packet transmission, but it was unset in some cases (one example is macvtap driver which build skbs from userspace and generate CHECKSUM_NONE packets). The driver may crash in those cases since the transport_header was not valid. The problem becomes more obvious since commit fda55eca5a33f33ffcd4192c6b2d75179714a52c (net: introduce skb_transport_header_was_set()) since it initializes transport_header to ~0U.
So before passing the skb to driver, this patch reset the transport_header if it was not set to avoid such crash such as:
hp-z800-04.qe.lab.eng.nay.redhat.com login: BUG: unable to handle kernel paging request at ffff8805166f760c
IP: [<ffffffffa035a5d0>] ixgbe_xmit_frame_ring+0x220/0x5e0 [ixgbe] PGD 1ece067 PUD 0
Oops: 0000 [#1] SMP Modules linked in: vhost_net tun nfsv3 nfs_acl nfsv4 auth_rpcgss nfs fscache
lockd autofs4 sunrpc openvswitch ipv6 iTCO_wdt iTCO_vendor_support hp_wmi sparse_keymap rfkill acpi_cpufreq freq_table mperf coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode serio_raw pcspkr sg lpc_ich mfd_core tg3 snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm snd_timer snd soundcore snd_page_alloc i7core_edac edac_core ixgbe dca ptp pps_core mdio ext4(F) mbcache(F) jbd2(F) sd_mod(F) crc_t10dif(F) sr_mod(F) cdrom(F) firewire_ohci(F) firewire_core(F) crc_itu_t(F) aesni_intel(F) ablk_helper(F) cryptd(F) lrw(F) aes_x86_64(F) xts(F) gf128mul(F) floppy(F) mptsas(F) mptscsih(F) mptbase(F) scsi_transport_sas(F) ahci(F) libahci(F) nouveau(F) ttm(F) drm_kms_helper(F) drm(F) i2c_algo_bit(F) i2c_core(F) mxm_wmi(F) video(F) wmi(F) dm_mirror(F) dm_region_hash(F) dm_log(F) dm_mod(F) [last unloaded: tun]
CPU 6
Pid: 17337, comm: vhost-17317 Tainted: GF 3.9.0-rc1+ #7 Hewlett-Packard HP Z800 Workstation/0AECh
RIP: 0010:[<ffffffffa035a5d0>] [<ffffffffa035a5d0>] ixgbe_xmit_frame_ring+0x220/0x5e0 [ixgbe] RSP: 0018:ffff880222cddb18 EFLAGS: 00010286 RAX: 00000000ffffffff RBX: ffff880416b4b000 RCX: ffff8805166f75ff RDX: 0000000000000008 RSI: ffff8804166f760e RDI: 0000000000000007 RBP: ffff880222cddb68 R08: 0000000000000008 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffffc90009dce120 R13: ffff880416b4b300 R14: 0000000000000000 R15: ffff8804118f0800 FS: 0000000000000000(0000) GS:ffff88042fc40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: ffff8805166f760c CR3: 000000041e98c000 CR4: 00000000000027e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process vhost-17317 (pid: 17337, threadinfo ffff880222cdc000, task ffff8802211d4040) Stack: 00000000ffffffff 0000000000000180 ffff880222cddbb7 0000000000000180 ffff880222cddb48 ffff88040d5dd1c0 ffff8804118f0000 0000000000000036 ffff8804118f0000 ffff8804165d7a9c ffff880222cddb88 ffffffffa035a9d3 Call Trace: [<ffffffffa035a9d3>] ixgbe_xmit_frame+0x43/0x90 [ixgbe] [<ffffffff8149d54a>] dev_hard_start_xmit+0x12a/0x570 [<ffffffff814bd8da>] sch_direct_xmit+0xfa/0x1d0 [<ffffffff8149db28>] dev_queue_xmit+0x198/0x4c0 [<ffffffff813d23fa>] macvlan_start_xmit+0x6a/0x170 [<ffffffff813d3974>] macvtap_get_user+0x404/0x4e0 [<ffffffff813d3a7b>] macvtap_sendmsg+0x2b/0x30 [<ffffffffa06d9efa>] handle_tx+0x34a/0x680 [vhost_net] [<ffffffffa06da265>] handle_tx_kick+0x15/0x20 [vhost_net] [<ffffffffa06d7dfc>] vhost_worker+0x10c/0x1c0 [vhost_net] [<ffffffffa06d7cf0>] ? vhost_attach_cgroups_work+0x30/0x30 [vhost_net] [<ffffffffa06d7cf0>] ? vhost_attach_cgroups_work+0x30/0x30 [vhost_net] [<ffffffff8107b77e>] kthread+0xce/0xe0 [<ffffffff8107b6b0>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff815749ec>] ret_from_fork+0x7c/0xb0 [<ffffffff8107b6b0>] ? kthread_freezable_should_stop+0x70/0x70 Code: 34 31 0f 84 d3 01 00 00 66 83 fa 08 0f 85 b9 00 00 00 80 7e 09 06 0f 85 af
00 00 00 8b 80 cc 00 00 00 48 01 c1 0f 84 a0 00 00 00 <0f> b6 41 0d a8 01 0f 85 94 00 00 00 a8 02 75 0a 41 3a 7d 5c 0f
RIP [<ffffffffa035a5d0>] ixgbe_xmit_frame_ring+0x220/0x5e0 [ixgbe] RSP <ffff880222cddb18>
CR2: ffff8805166f760c
--- net/core/dev.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
net/core/dev.c +3 -0
@@ -2525,6 +2525,9 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, } } +if (!skb_transport_header_was_set (skb)) +skb_reset_transport_header (skb); +if (!list_empty (&ptype_all))dev_queue_xmit_nit (skb, dev);
Signature · 1 line
1.7.1
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 85 lines · Jason Wang
Some drivers depends on
transport_headerto do packet transmission, but it was unset in some cases (one example is macvtap driver which build skbs from userspace and generateCHECKSUM_NONEpackets). The driver may crash in those cases since thetransport_headerwas not valid. The problem becomes more obvious since commitfda55eca5a33f33ffcd4192c6b2d75179714a52c(net: introduceskb_transport_header_was_set()) since it initializestransport_headerto ~0U.So before passing the skb to driver, this patch reset the
transport_headerif it was not set to avoid such crash such as:hp-z800-04.qe.lab.eng.nay.redhat.com login: BUG: unable to handle kernel paging request at
ffff8805166f760c
IP: [<ffffffffa035a5d0>]ixgbe_xmit_frame_ring+0x220/0x5e0[ixgbe] PGD 1ece067 PUD 0Oops: 0000 [#1] SMP Modules linked in: vhost_net tun nfsv3 nfs_acl nfsv4 auth_rpcgss nfs fscachelockd autofs4 sunrpc openvswitch ipv6
iTCO_wdtiTCO_vendor_supporthp_wmisparse_keymaprfkillacpi_cpufreqfreq_tablemperf coretempkvm_intelkvmcrc32c_intelghash_clmulni_intelmicrocodeserio_rawpcspkr sglpc_ichmfd_coretg3snd_hda_codec_realteksnd_hda_intelsnd_hda_codecsnd_hwdepsnd_seqsnd_seq_devicesnd_pcmsnd_timersnd soundcoresnd_page_alloci7core_edacedac_coreixgbe dca ptppps_coremdio ext4(F) mbcache(F) jbd2(F)sd_mod(F)crc_t10dif(F)sr_mod(F)cdrom(F)firewire_ohci(F)firewire_core(F)crc_itu_t(F)aesni_intel(F)ablk_helper(F)cryptd(F) lrw(F)aes_x86_64(F)xts(F) gf128mul(F) floppy(F) mptsas(F) mptscsih(F) mptbase(F)scsi_transport_sas(F)ahci(F) libahci(F) nouveau(F) ttm(F)drm_kms_helper(F)drm(F)i2c_algo_bit(F)i2c_core(F)mxm_wmi(F)video(F) wmi(F)dm_mirror(F)dm_region_hash(F)dm_log(F)dm_mod(F)[last unloaded: tun]
CPU 6
Pid: 17337, comm: vhost-17317 Tainted: GF 3.9.0-rc1+ #7
Hewlett-Packard HP Z800 Workstation/0AEChRIP: 0010:[<ffffffffa035a5d0>] [<ffffffffa035a5d0>] ixgbe_xmit_frame_ring+0x220/0x5e0 [ixgbe] RSP: 0018:ffff880222cddb18 EFLAGS: 00010286 RAX: 00000000ffffffff RBX: ffff880416b4b000 RCX: ffff8805166f75ff RDX: 0000000000000008 RSI: ffff8804166f760e RDI: 0000000000000007 RBP: ffff880222cddb68 R08: 0000000000000008 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffffc90009dce120 R13: ffff880416b4b300 R14: 0000000000000000 R15: ffff8804118f0800 FS: 0000000000000000(0000) GS:ffff88042fc40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: ffff8805166f760c CR3: 000000041e98c000 CR4: 00000000000027e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process vhost-17317 (pid: 17337, threadinfo ffff880222cdc000, task ffff8802211d4040) Stack: 00000000ffffffff 0000000000000180 ffff880222cddbb7 0000000000000180 ffff880222cddb48 ffff88040d5dd1c0 ffff8804118f0000 0000000000000036 ffff8804118f0000 ffff8804165d7a9c ffff880222cddb88 ffffffffa035a9d3 Call Trace: [<ffffffffa035a9d3>] ixgbe_xmit_frame+0x43/0x90 [ixgbe] [<ffffffff8149d54a>] dev_hard_start_xmit+0x12a/0x570 [<ffffffff814bd8da>] sch_direct_xmit+0xfa/0x1d0 [<ffffffff8149db28>] dev_queue_xmit+0x198/0x4c0 [<ffffffff813d23fa>] macvlan_start_xmit+0x6a/0x170 [<ffffffff813d3974>] macvtap_get_user+0x404/0x4e0 [<ffffffff813d3a7b>] macvtap_sendmsg+0x2b/0x30 [<ffffffffa06d9efa>] handle_tx+0x34a/0x680 [vhost_net] [<ffffffffa06da265>] handle_tx_kick+0x15/0x20 [vhost_net] [<ffffffffa06d7dfc>] vhost_worker+0x10c/0x1c0 [vhost_net] [<ffffffffa06d7cf0>] ? vhost_attach_cgroups_work+0x30/0x30 [vhost_net] [<ffffffffa06d7cf0>] ? vhost_attach_cgroups_work+0x30/0x30 [vhost_net] [<ffffffff8107b77e>] kthread+0xce/0xe0 [<ffffffff8107b6b0>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff815749ec>] ret_from_fork+0x7c/0xb0 [<ffffffff8107b6b0>] ? kthread_freezable_should_stop+0x70/0x70 Code: 34 31 0f 84 d3 01 00 00 66 83 fa 08 0f 85 b9 00 00 00 80 7e 09 06 0f 85 af00 00 00 8b 80 cc 00 00 00 48 01 c1 0f 84 a0 00 00 00 <0f> b6 41 0d a8 01 0f 85 94 00 00 00 a8 02 75 0a 41 3a 7d 5c 0f
RIP [<ffffffffa035a5d0>]ixgbe_xmit_frame_ring+0x220/0x5e0[ixgbe]
RSP <ffff880222cddb18>
CR2:ffff8805166f760cCc Eric Dumazet <[email protected]>Signed-off-by Jason Wang <[email protected]>--- net/core/dev.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)net/core/dev.c +0
-0
net/core/dev.c int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, · line 2533
Quoted 9 lines
net/core/dev.c +3
-0@@ -2525,6 +2525,9 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, } } +if (!skb_transport_header_was_set (skb)) +skb_reset_transport_header (skb); +if (!list_empty (&ptype_all))dev_queue_xmit_nit (skb, dev);
Hmm... This really looks strange.
Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?
David Miller
maintainerRe: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
From: Eric Dumazet <[email protected]>
Date: Fri, 15 Mar 2013 19:10:51 -0700
Quoted 2 lines
Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?
Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed packets to the rest of the stack.
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 8 lines · David Miller
From: Eric Dumazet <[email protected]>
Date: Fri, 15 Mar 2013 19:10:51 -0700Quoted 2 lines
Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?
Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed packets to the rest of the stack.
Ok, haven't checked all other possibility but looks like packet needs to be fixed also.
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 4 lines · Jason Wang
Quoted 3 lines · David Miller
From: Eric Dumazet <[email protected]>
Date: Fri, 15 Mar 2013 19:10:51 -0700
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?
Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed packets to the rest of the stack.
Ok, haven't checked all other possibility but looks like packet needs to be fixed also.
Daniel, could you post your patches if ready ?
Jason, I believe you could reuse existing flow dissector once Daniel patches are in.
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 7 lines · Eric Dumazet
Quoted 6 lines · Jason Wang
Quoted 5 lines · David Miller
From: Eric Dumazet <[email protected]>
Date: Fri, 15 Mar 2013 19:10:51 -0700Quoted 2 lines
Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed packets to the rest of the stack.
Ok, haven't checked all other possibility but looks like packet needs to be fixed also.
Daniel, could you post your patches if ready ?
Yes, will post them in a couple of minutes.
Quoted 2 lines
Jason, I believe you could reuse existing flow dissector once Daniel patches are in.
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 2 lines · Daniel Borkmann
Yes, will post them in a couple of minutes.
Please target net tree for the first patch (adding thoff into struct flow_keys), so that Jason or me can fix DODGY providers.
Thanks
Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Quoted 6 lines · Eric Dumazet
Quoted 1 line · Daniel Borkmann
Yes, will post them in a couple of minutes.
Please target net tree for the first patch (adding thoff into struct
flow_keys), so that Jason or me can fix DODGY providers.
Sorry, I received this too late. The patch set is already out, but we can put a note into the ``[PATCH net-next 1/4] flow_keys: include thoff into flow_keys for later'' thread to let Dave know.
David Miller
maintainerFrom: Jason Wang <[email protected]>
Date: Fri, 15 Mar 2013 15:41:44 +0800
Quoted 9 lines
Commit
1def9238d4aa2(net_sched: more precisepkt_lencomputation) tries to do precise packet len computation for GSO packets, but it does not check whether the packets were from untrusted source. This is wrong since: we haven't done header check before so bothgso_segsand headers may not be correct. So this patch just bypass the precisepkt_lencomputation for packet from untrusted source (SKB_GSO_DODGY).Cc Eric Dumazet <[email protected]>Signed-off-by Jason Wang <[email protected]>
I do not think this is appropriate or even necessary.
All the user can do by reporting an incorrect header size or GSO segs is hurt himself, by making his traffic take more packet scheduler quota.
When we do precise accounting, it increases, never decreases, the amount that a packet "costs" as far as the packet scheduler is concerned.
Quoted 10 lines · David Miller
From: Jason Wang <[email protected]>
Date: Fri, 15 Mar 2013 15:41:44 +0800Quoted 7 lines
Commit
1def9238d4aa2(net_sched: more precisepkt_lencomputation) tries to do precise packet len computation for GSO packets, but it does not check whether the packets were from untrusted source. This is wrong since: we haven't done header check before so bothgso_segsand headers may not be correct. So this patch just bypass the precisepkt_lencomputation for packet from untrusted source (SKB_GSO_DODGY).
Quoted 7 lines
Quoted 2 lines
Cc Eric Dumazet <[email protected]>Signed-off-by Jason Wang <[email protected]>I do not think this is appropriate or even necessary.
All the user can do by reporting an incorrect header size or GSO segs is hurt himself, by making his traffic take more packet scheduler quota.
I believe before doing header check for untrusted packets, the only thing we can trust is skb->len and that's we've used before 1def9238d4aa2. But after that, we're trying to use unchecked or meaningless value (e.g gso_segs were reset to zero in tun/macvtap/packet), and guest then can utilize this to result a very huge (-1U) pkt_len by filling evil value in the header. Can all kinds of packet scheduler survive this kinds of possible DOS?
Quoted 8 lines
When we do precise accounting, it increases, never decreases, the amount that a packet "costs" as far as the packet scheduler is concerned.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Jason Wang
I believe before doing header check for untrusted packets, the only thing we can trust is
skb->lenand that's we've used before1def9238d4aa2. But after that, we're trying to use unchecked or meaningless value (e.ggso_segswere reset to zero in tun/macvtap/packet), and guest then can utilize this to result a very huge (-1U)pkt_lenby filling evil value in the header. Can all kinds of packet scheduler survive this kinds of possible DOS?
I would use the flow dissector to fix the transport header from all DODGY providers.
Daniel Borkmann is working on a patch serie adding nhoff into flow_keys, and adding __skb_get_poff(const struct sk_buff *skb), for a BPF extension we talked about in Copenhagen / Netfilter Workshop.
You could then set the transport header offset to the right value.
(and drop evil packets before they go further in the stack)
if (gso_packet(skb)) {
u32 poff = __skb_get_poff(skb);
if (!poff) {
drop_evil_packet(skb);
} else {
skb_set_transport_header(skb, poff);
...
}
}Quoted 21 lines · Eric Dumazet
Quoted 7 lines · Jason Wang
I believe before doing header check for untrusted packets, the only thing we can trust is
skb->lenand that's we've used before1def9238d4aa2. But after that, we're trying to use unchecked or meaningless value (e.ggso_segswere reset to zero in tun/macvtap/packet), and guest then can utilize this to result a very huge (-1U)pkt_lenby filling evil value in the header. Can all kinds of packet scheduler survive this kinds of possible DOS?I would use the flow dissector to fix the transport header from all DODGY providers.
Daniel Borkmann is working on a patch serie adding nhoff into
flow_keys, and adding__skb_get_poff(const struct sk_buff *skb), for a BPF extension we talked about in Copenhagen / Netfilter Workshop.You could then set the transport header offset to the right value.
(and drop evil packets before they go further in the stack)
Quoted 10 lines
if (gso_packet(skb)) {
u32 poff = __skb_get_poff(skb);
if (!poff) {
drop_evil_packet(skb);
} else {
skb_set_transport_header(skb, poff);
...
}
}Oh well, no need to use __skb_get_poff() but plain skb_flow_dissect() (once patched to include thoff in struct flow_keys)
struct flow_keys keys;
if (!skb_flow_dissect(skb, &keys))
goto drop;
if ((gso_type & (SKB_GSO_TCPV4|SKB_GSO_TCPV6)) &&
keys.ip_proto != IP_PROTO_TCP) goto drop;
skb_set_transport_header(skb, keys.thoff);
Quoted 37 lines · Eric Dumazet
Quoted 20 lines · Eric Dumazet
Quoted 7 lines · Jason Wang
I believe before doing header check for untrusted packets, the only thing we can trust is
skb->lenand that's we've used before1def9238d4aa2. But after that, we're trying to use unchecked or meaningless value (e.ggso_segswere reset to zero in tun/macvtap/packet), and guest then can utilize this to result a very huge (-1U)pkt_lenby filling evil value in the header. Can all kinds of packet scheduler survive this kinds of possible DOS?I would use the flow dissector to fix the transport header from all DODGY providers.
Daniel Borkmann is working on a patch serie adding nhoff into
flow_keys, and adding__skb_get_poff(const struct sk_buff *skb), for a BPF extension we talked about in Copenhagen / Netfilter Workshop.You could then set the transport header offset to the right value.
(and drop evil packets before they go further in the stack)
Quoted 10 lines
if (gso_packet(skb)) { u32 poff = __skb_get_poff(skb); if (!poff) { drop_evil_packet(skb); } else { skb_set_transport_header(skb, poff); ... } }Oh well, no need to use
__skb_get_poff()but plainskb_flow_dissect()(once patched to include thoff in structflow_keys)struct
flow_keyskeys;
Quoted 8 lines
if (!skb_flow_dissect(skb, &keys))
goto drop;if ((
gso_type& (SKB_GSO_TCPV4|SKB_GSO_TCPV6)) &&keys.ip_proto != IP_PROTO_TCP) goto drop;
skb_set_transport_header(skb, keys.thoff);
I was consider a just skb_reset_transport_header() here. Consider the transport header maybe checked and reset during header check for packets of gso or partial checksum. And bypass precise pkt len computation.
Some problems with skb_flow_dissect():
- it can only recognizes a subset of all ethernet protocols. The may blocks guest who may want to use other protocol such as IPX.
- almost no check in the validity of the L4 protocol header which may be used by qdisc_pkt_len_init(), which may still give a chance to evil guest to use
- gso_segs were untouched (still zero)
Another method is doing header check here which needs more work.
Quoted 6 lines
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Jason Wang
I was consider a just
skb_reset_transport_header()here. Consider the transport header maybe checked and reset during header check for packets of gso or partial checksum. And bypass precise pkt len computation.Some problems with
skb_flow_dissect():- it can only recognizes a subset of all ethernet protocols. The may blocks guest who may want to use other protocol such as IPX.
Oh yes IPX
Quoted 6 lines
- almost no check in the validity of the L4 protocol header which may be used by
qdisc_pkt_len_init(), which may still give a chance to evil guest to use
-gso_segswere untouched (still zero)Another method is doing header check here which needs more work.
Most uses are caught by the helper.
So in the case dissection fails, just reset transport header instead of dropping as I suggested.
Otherwise, set the transport header to the right value
-> precise qdisc pkt lengths.
Instead of pretending DODGY packets have no headers, at least try to do the right thing.