cpuidle / kirkwood: remove redundant Kconfig option
Subsystems (2)
PATCH 1/2 cpuidle / kirkwood: remove redundant Kconfig option
When the CPU_IDLE and the ARCH_KIRKWOOD options are set it is pointless to define a new option CPU_IDLE_KIRKWOOD because it is redundant.
The Makefile drivers directory contains a condition to compile the cpuidle drivers:
obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if CPU_IDLE is not set we won't enter this directory.
This patch removes the useless Kconfig option and replaces the condition in the Makefile by CONFIG_ARCH_KIRKWOOD.
--- arch/arm/configs/kirkwood_defconfig | 1 - drivers/cpuidle/Kconfig | 6 ------ drivers/cpuidle/Makefile | 2 +- 3 files changed, 1 insertion(+), 8 deletions(-)
arch/arm/configs/kirkwood_defconfig +0 -1
@@ -56,7 +56,6 @@ CONFIG_AEABI=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CPU_IDLE=y -CONFIG_CPU_IDLE_KIRKWOOD=y CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y
drivers/cpuidle/Kconfig +0 -6
@@ -39,10 +39,4 @@ config CPU_IDLE_CALXEDA help Select this to enable cpuidle on Calxeda processors. -config CPU_IDLE_KIRKWOOD - bool "CPU Idle Driver for Kirkwood processors" - depends on ARCH_KIRKWOOD - help - Select this to enable cpuidle on Kirkwood processors. - endif
drivers/cpuidle/Makefile +1 -1
@@ -6,4 +6,4 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o -obj-$(CONFIG_CPU_IDLE_KIRKWOOD) += cpuidle-kirkwood.o +obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
Signature · 1 line
1.7.9.5
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
When the CPU_IDLE and the ARCH_HIGHBANK options are set it is pointless to define a new option CPU_IDLE_CALXEDA because it is redundant.
The Makefile drivers directory contains a condition to compile the cpuidle drivers:
obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if CPU_IDLE is not set we won't enter this directory.
This patch removes the useless Kconfig option and replaces the condition in the Makefile by CONFIG_ARCH_HIGHBANK.
--- drivers/cpuidle/Kconfig | 10 ---------- drivers/cpuidle/Makefile | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)
drivers/cpuidle/Kconfig +0 -10
@@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU config ARCH_NEEDS_CPU_IDLE_COUPLED def_bool n - -if CPU_IDLE - -config CPU_IDLE_CALXEDA - bool "CPU Idle Driver for Calxeda processors" - depends on ARCH_HIGHBANK - help - Select this to enable cpuidle on Calxeda processors. - -endif
drivers/cpuidle/Makefile +1 -1
@@ -5,5 +5,5 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
Signature · 1 line
1.7.9.5
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
Quoted 9 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_HIGHBANKoptions are set it is pointless to define a new optionCPU_IDLE_CALXEDAbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:obj-$(CONFIG_CPU_IDLE) += cpuidle/
Quoted 7 lines
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_HIGHBANK.Signed-off-by Daniel Lezcano <[email protected]>---
Hi Rob,
sorry I missed to add you in Cc for this patch.
Regards
-- Daniel
Quoted 34 lines
drivers/cpuidle/Kconfig | 10 ---------- drivers/cpuidle/Makefile | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)drivers/cpuidle/Kconfig +0
-10@@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU config ARCH_NEEDS_CPU_IDLE_COUPLED def_bool n - -if CPU_IDLE - -config CPU_IDLE_CALXEDA - bool "CPU Idle Driver for Calxeda processors" - depends on ARCH_HIGHBANK - help - Select this to enable cpuidle on Calxeda processors. - -endifdrivers/cpuidle/Makefile +1
-1@@ -5,5 +5,5 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
Signature · 5 lines
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
In reply to Daniel LezcanoQuoted 7 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_HIGHBANKoptions are set it is pointless to define a new optionCPU_IDLE_CALXEDAbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:
Quoted 6 lines
obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_HIGHBANK.
If I have multiple platforms including highbank compiled in, but want to disable cpuidle just for highbank, then you can't disable it at compile time.
Also, with my PSCI support patches for highbank, it is no longer dependent on ARCH_HIGHBANK which gives us better compile test coverage.
Rob
Quoted 37 lines
Signed-off-by Daniel Lezcano <[email protected]>--- drivers/cpuidle/Kconfig | 10 ---------- drivers/cpuidle/Makefile | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)drivers/cpuidle/Kconfig +0
-10@@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU config ARCH_NEEDS_CPU_IDLE_COUPLED def_bool n - -if CPU_IDLE - -config CPU_IDLE_CALXEDA - bool "CPU Idle Driver for Calxeda processors" - depends on ARCH_HIGHBANK - help - Select this to enable cpuidle on Calxeda processors. - -endifdrivers/cpuidle/Makefile +1
-1@@ -5,5 +5,5 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
Quoted 10 lines · Rob Herring
Quoted 9 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_HIGHBANKoptions are set it is pointless to define a new optionCPU_IDLE_CALXEDAbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:obj-$(CONFIG_CPU_IDLE) += cpuidle/
Quoted 8 lines
Quoted 4 lines
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_HIGHBANK.If I have multiple platforms including highbank compiled in, but want to disable cpuidle just for highbank, then you can't disable it at compile time.
Could you elaborate a bit ? Is it today possible to have multiple platforms in a single kernel ?
Quoted 43 lines
Also, with my PSCI support patches for highbank, it is no longer dependent on
ARCH_HIGHBANKwhich gives us better compile test coverage.Quoted 36 lines
Signed-off-by Daniel Lezcano <[email protected]>--- drivers/cpuidle/Kconfig | 10 ---------- drivers/cpuidle/Makefile | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)drivers/cpuidle/Kconfig +0
-10@@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU config ARCH_NEEDS_CPU_IDLE_COUPLED def_bool n - -if CPU_IDLE - -config CPU_IDLE_CALXEDA - bool "CPU Idle Driver for Calxeda processors" - depends on ARCH_HIGHBANK - help - Select this to enable cpuidle on Calxeda processors. - -endifdrivers/cpuidle/Makefile +1
-1@@ -5,5 +5,5 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
Signature · 5 lines
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
Quoted 16 lines · Daniel Lezcano
Quoted 15 lines · Rob Herring
Quoted 13 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_HIGHBANKoptions are set it is pointless to define a new optionCPU_IDLE_CALXEDAbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_HIGHBANK.
Quoted 6 lines
Quoted 3 lines
If I have multiple platforms including highbank compiled in, but want to disable cpuidle just for highbank, then you can't disable it at compile time.
Could you elaborate a bit ? Is it today possible to have multiple platforms in a single kernel ?
You've heard of single zImage, right? Vexpress, mvebu, highbank, imx, omap2+, socfpga, vt8500 off the top of my head as of 3.8.
Rob
PATCH 2/2 cpuidle / calxeda: remove redundant Kconfig option
Quoted 21 lines · Rob Herring
Quoted 20 lines · Daniel Lezcano
Quoted 18 lines · Rob Herring
Quoted 7 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_HIGHBANKoptions are set it is pointless to define a new optionCPU_IDLE_CALXEDAbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:Quoted 6 lines
obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_HIGHBANK.If I have multiple platforms including highbank compiled in, but want to disable cpuidle just for highbank, then you can't disable it at compile time.
Quoted 5 lines
Quoted 2 lines
Could you elaborate a bit ? Is it today possible to have multiple platforms in a single kernel ?
You've heard of single zImage, right? Vexpress, mvebu, highbank, imx, omap2+, socfpga, vt8500 off the top of my head as of 3.8.
Yes, I have heard of single zImage but I am not aware of the status.
IIUC, the approach would be the same as cpufreq, right ?
I am not sure the cpuidle drivers are ready for that.
We can keep the current Makefile but I am in favor of removing this Kconfig option for now, unify as much as possible all the drivers, create a common driver for all and then address the single zImage for all these drivers at the same time.
Signature · 5 lines
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
PATCH 1/2 cpuidle / kirkwood: remove redundant Kconfig option
In reply to Daniel LezcanoQuoted 14 lines · Daniel Lezcano
When the
CPU_IDLEand theARCH_KIRKWOODoptions are set it is pointless to define a new optionCPU_IDLE_KIRKWOODbecause it is redundant.The
Makefiledrivers directory contains a condition to compile the cpuidle drivers:obj-$(CONFIG_CPU_IDLE) += cpuidle/
Hence, if
CPU_IDLEis not set we won't enter this directory.This patch removes the useless
Kconfigoption and replaces the condition in theMakefilebyCONFIG_ARCH_KIRKWOOD.
Quoted 6 lines
Signed-off-by Daniel Lezcano <[email protected]>--- arch/arm/configs/kirkwood_defconfig | 1 - drivers/cpuidle/Kconfig | 6 ------ drivers/cpuidle/Makefile | 2 +- 3 files changed, 1 insertion(+), 8 deletions(-)
Quoted 46 lines
arch/arm/configs/kirkwood_defconfig +0
-1@@ -56,7 +56,6 @@ CONFIG_AEABI=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CPU_IDLE=y -CONFIG_CPU_IDLE_KIRKWOOD=y CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=ydrivers/cpuidle/Kconfig +0
-6@@ -39,10 +39,4 @@ config CPU_IDLE_CALXEDA help Select this to enable cpuidle on Calxeda processors. -config CPU_IDLE_KIRKWOOD - bool "CPU Idle Driver for Kirkwood processors" - depends on ARCH_KIRKWOOD - help - Select this to enable cpuidle on Kirkwood processors. - endifdrivers/cpuidle/Makefile +1
-1@@ -6,4 +6,4 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o -obj-$(CONFIG_CPU_IDLE_KIRKWOOD) += cpuidle-kirkwood.o +obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.oSignature · 7 lines
1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel