Skip to contentSkip to conversation

pinctrl: mvebu: fix checking for SoC specific controls

PATCH New Simon Guinot 3 participants 3 messages Mar 19, 2013 – Mar 21, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mvebu: fix checking for SoC specific controls

This patch fixes a minor bug (probably due to a typo) while checking the SoC specific controls in mvebu_pinctrl_probe().

---
 drivers/pinctrl/mvebu/pinctrl-mvebu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mvebu/pinctrl-mvebu.c +1 -1
index c689c04..2d2f0a4 100644
@@ -620,7 +620,7 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
 
 		/* special soc specific control */
 		if (ctrl->mpp_get || ctrl->mpp_set) {
-			if (!ctrl->name || !ctrl->mpp_set || !ctrl->mpp_set) {
+			if (!ctrl->name || !ctrl->mpp_get || !ctrl->mpp_set) {
 				dev_err(&pdev->dev, "wrong soc control info\n");
 				return -EINVAL;
 			}
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 pinctrl: mvebu: fix checking for SoC specific controls

Quoted 4 lines · Simon Guinot

This patch fixes a minor bug (probably due to a typo) while checking the SoC specific controls in mvebu_pinctrl_probe().

Simon,

good catch! The patch looks sane to me, so

Quoted 17 lines
---
  drivers/pinctrl/mvebu/pinctrl-mvebu.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mvebu/pinctrl-mvebu.c +1 -1
index c689c04..2d2f0a4 100644
@@ -620,7 +620,7 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
 
  		/* special soc specific control */
  		if (ctrl->mpp_get || ctrl->mpp_set) {
-			if (!ctrl->name || !ctrl->mpp_set || !ctrl->mpp_set) {
+			if (!ctrl->name || !ctrl->mpp_get || !ctrl->mpp_set) {
  				dev_err(&pdev->dev, "wrong soc control info\n");
  				return -EINVAL;
  			}
#2 lore raw

PATCH 1/1 pinctrl: mvebu: fix checking for SoC specific controls

In reply to Simon Guinot
Quoted 4 lines · Simon Guinot

This patch fixes a minor bug (probably due to a typo) while checking the SoC specific controls in mvebu_pinctrl_probe().

Patch applied with Sebastian's ACK, thanks!

Yours,
Linus Walleij