Skip to contentSkip to conversation

Add Allwinner H6 Mali Midgard GPU

PATCH Superseded Clément Péron 4 participants 21 messages Apr 11, 2019

Subsystems (4)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add Allwinner H6 Mali Midgard GPU

Hi,

The Allwinner H6 has a Mali-T720 MP2. The drivers are out-of-tree so this series only introduce the dt-bindings.

The first patch is from Neil Amstrong and has been already merged in linux-amlogic. It is required for this series.

The second patch is from Icenowy Zheng where I changed the order has required by Rob Herring.
See: https://patchwork.kernel.org/patch/10699829/

The GPU opp table was taken from Jernej Škrabec's patch on LibreELEC.tv.

Thanks,
Clement

Changes in v2 (Thanks to Maxime Ripard):
- Drop GPU OPP Table
- Add clocks and clock-names in required

Clément Péron (7):
dt-bindings: gpu: add bus clock for Mali Midgard GPUs
dt-bindings: gpu: mali-midgard: Add h6 mali gpu compatible
arm64: dts: allwinner: Add ARM Mali GPU node for H6
arm64: dts: allwinner: Add mali GPU supply for Pine H64
arm64: dts: allwinner: Add mali GPU supply for Beelink GS1
arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards
arm64: dts: allwinner: Add mali GPU supply for OrangePi 3

Neil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property

 .../bindings/gpu/arm,mali-midgard.txt         | 27 +++++++++++++++++++
 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   |  5 ++++
 .../dts/allwinner/sun50i-h6-orangepi-3.dts    |  5 ++++
 .../dts/allwinner/sun50i-h6-orangepi.dtsi     |  5 ++++
 .../boot/dts/allwinner/sun50i-h6-pine-h64.dts |  5 ++++
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  | 14 ++++++++++
 6 files changed, 61 insertions(+)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/8 dt-bindings: gpu: mali-midgard: Add resets property

From: Neil Armstrong <[email protected]>

The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.

---
 .../devicetree/bindings/gpu/arm,mali-midgard.txt   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +14 -0
index 18a2cde2e5f3..1b1a74129141 100644
@@ -37,6 +37,20 @@ Optional properties:
 - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
   for details.
 
+- resets : Phandle of the GPU reset line.
+
+Vendor-specific bindings
+------------------------
+
+The Mali GPU is integrated very differently from one SoC to
+another. In order to accomodate those differences, you have the option
+to specify one more vendor-specific compatible, among:
+
+- "amlogic,meson-gxm-mali"
+  Required properties:
+  - resets : Should contain phandles of :
+    + GPU reset line
+    + GPU APB glue reset line
 
 Example for a Mali-T760:
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/8 dt-bindings: gpu: add bus clock for Mali Midgard GPUs

In reply to Clément Péron

Some SoCs adds a bus clock gate to the Mali Midgard GPU.

Add the binding for the bus clock.

---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +6 -0
index 1b1a74129141..2e8bbce35695 100644
@@ -31,6 +31,12 @@ Optional properties:
 
 - clocks : Phandle to clock for the Mali Midgard device.
 
+- clock-names : Specify the names of the clocks specified in clocks
+  when multiple clocks are present.
+    * core: clock driving the GPU itself (When only one clock is present,
+      assume it's this clock.)
+    * bus: bus clock for the GPU
+
 - mali-supply : Phandle to regulator for the Mali device. Refer to
   Documentation/devicetree/bindings/regulator/regulator.txt for details.
 
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH v2 2/8] dt-bindings: gpu: add bus clock for Mali Midgard GPUs

Quoted 6 lines · Clément Péron

Some SoCs adds a bus clock gate to the Mali Midgard GPU.

Add the binding for the bus clock.

I'm not quite sure what you did there. If Icenowy is the author and you're sending that commit on her behalf, then she should have the authorship of that commit.

If you're the author of that commit, then we Icenowy's SoB is there?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

Re: [PATCH v2 2/8] dt-bindings: gpu: add bus clock for Mali Midgard GPUs

Hi,

Quoted 4 lines · Maxime Ripard
Quoted 2 lines · Clément Péron

Some SoCs adds a bus clock gate to the Mali Midgard GPU.

Quoted 8 lines
Quoted 4 lines

Add the binding for the bus clock.

I'm not quite sure what you did there. If Icenowy is the author and you're sending that commit on her behalf, then she should have the authorship of that commit.

Indeed bad cherry pick, I will change the author sorry for that.

Clément

Quoted 9 lines

If you're the author of that commit, then we Icenowy's SoB is there?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#5 lore raw

PATCH v2 3/8 dt-bindings: gpu: mali-midgard: Add h6 mali gpu compatible

In reply to Clément Péron

This add the H6 mali compatible in the dt-bindings to later support specific implementation.

---
 .../devicetree/bindings/gpu/arm,mali-midgard.txt         | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +8 -1
index 2e8bbce35695..0000ec4a9f44 100644
@@ -15,6 +15,7 @@ Required properties:
     + "arm,mali-t860"
     + "arm,mali-t880"
   * which must be preceded by one of the following vendor specifics:
+    + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"
@@ -49,9 +50,15 @@ Vendor-specific bindings
 ------------------------
 
 The Mali GPU is integrated very differently from one SoC to
-another. In order to accomodate those differences, you have the option
+another. In order to accommodate those differences, you have the option
 to specify one more vendor-specific compatible, among:
 
+- "allwinner,sun50i-h6-mali"
+  Required properties:
+  - clocks : phandles to core and bus clocks
+  - clock-names : must contain "core" and "bus"
+  - resets: phandle to GPU reset line
+
 - "amlogic,meson-gxm-mali"
   Required properties:
   - resets : Should contain phandles of :
Signature · 1 line
2.17.1
#6 lore raw

PATCH v2 4/8 arm64: dts: allwinner: Add ARM Mali GPU node for H6

In reply to Clément Péron

Add the mali gpu node to the H6 device-tree.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +14 -0
index e0dc4a05c1ba..196753110434 100644
@@ -157,6 +157,20 @@
 			allwinner,sram = <&ve_sram 1>;
 		};
 
+		gpu: gpu@1800000 {
+			compatible = "allwinner,sun50i-h6-mali",
+				     "arm,mali-t720";
+			reg = <0x01800000 0x4000>;
+			interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+			clock-names = "core", "bus";
+			resets = <&ccu RST_BUS_GPU>;
+			status = "disabled";
+		};
+
 		syscon: syscon@3000000 {
 			compatible = "allwinner,sun50i-h6-system-control",
 				     "allwinner,sun50i-a64-system-control";
Signature · 1 line
2.17.1
#7 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):

Quoted 13 lines

Add the mali gpu node to the H6 device-tree.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 164

Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 			allwinner,sram = <&ve_sram 1>;
 		};
 
+		gpu: gpu@1800000 {
+			compatible = "allwinner,sun50i-h6-mali",
+				     "arm,mali-t720";
+			reg = <0x01800000 0x4000>;
+			interrupts = <GIC_SPI 84 

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 165

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+				     <GIC_SPI 85 

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+				     <GIC_SPI 83 

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 171

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+			clock-names = "core", "bus";
+			resets = <&ccu RST_BUS_GPU>;
+			status = "disabled";

Usually self sufficient peripherals are enabled by default in DTSI.

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi

Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +2 -0
+		};
+
 		syscon: syscon@3000000 {
 			compatible = "allwinner,sun50i-h6-system-

control",

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 176

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0 -0
 				     "allwinner,sun50i-a64-

system-control";

#8 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Hi,

Quoted 27 lines · Jernej Škrabec

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):

Quoted 13 lines

Add the mali gpu node to the H6 device-tree.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 164

Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
                      allwinner,sram = <&ve_sram 1>;
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 165

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83
Quoted 8 lines

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 171

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

Clement

Quoted 12 lines

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +2 -0
+             };
+
              syscon: syscon@3000000 {
                      compatible = "allwinner,sun50i-h6-system-

control",

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 176

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0 -0
                                   "allwinner,sun50i-a64-

system-control";

#9 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):

Quoted 3 lines

Hi,

On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <[email protected]>

Quoted 42 lines · wrote:
Quoted 42 lines

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):

Quoted 14 lines

Add the mali gpu node to the H6 device-tree.

---

 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 
                      allwinner,sram = <&ve_sram 1>;
 
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 167

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 168

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83

IRQ_TYPE_LEVEL_HIGH>;

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";
Quoted 5 lines
Quoted 1 line

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set).

Best regards,
Jernej

Quoted 14 lines

Clement

Quoted 12 lines
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +2 -0
+             };
+
 

syscon: syscon@3000000 {

compatible = "allwinner,sun50i-h6-system-

control",

Quoted 1 line
                                   "allwinner,sun50i-a64-

system-control";

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit https://groups.google.com/d/optout.
#10 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Quoted 47 lines · Jernej Škrabec

Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):

Quoted 3 lines

Hi,

On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <[email protected]>

Quoted 42 lines · wrote:
Quoted 42 lines

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):

Quoted 14 lines

Add the mali gpu node to the H6 device-tree.

---

 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 
                      allwinner,sram = <&ve_sram 1>;
 
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 167

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 168

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83

IRQ_TYPE_LEVEL_HIGH>;

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set).

I asked myself the same question, but the H6 seems to have a supply wired to the GPU, while the H3 and H5 do not. So I'm not sure we want to enable it on all the boards, even though some might have left out the GPU supply which will result in a non-working GPU (I assume?)

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit https://groups.google.com/d/optout.
#11 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Dne četrtek, 11. april 2019 ob 17:27:52 CEST je Maxime Ripard napisal(a):

Quoted 8 lines · Jernej Škrabec
Quoted 7 lines

Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):

Quoted 3 lines

Hi,

On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <[email protected]>

Quoted 1 line · wrote:
Quoted 1 line

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron

napisal(a):

Quoted 46 lines
Quoted 46 lines
Quoted 45 lines
Quoted 35 lines
Quoted 14 lines

Add the mali gpu node to the H6 device-tree.

---

 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 
                      allwinner,sram = <&ve_sram 1>;
 
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 167

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 168

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83

IRQ_TYPE_LEVEL_HIGH>;

Quoted 7 lines

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 171

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

Quoted 7 lines
Quoted 2 lines

I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set).

I asked myself the same question, but the H6 seems to have a supply wired to the GPU, while the H3 and H5 do not. So I'm not sure we want to enable it on all the boards, even though some might have left out the GPU supply which will result in a non-working GPU (I assume?)

It's true that GPU doesn't work at all without power supply. Even worse, ARM kernel driver just hangs whole SoC if it tries to use unpowered GPU.

I checked few datasheets and almost none of them have GPU power supply, except H5, where GPU is enabled by default in DTSI.

Yeah, I guess it's more safe to explicitly enable it in board DT.

Jernej

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit https://groups.google.com/d/optout.
#12 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

Quoted 64 lines · Jernej Škrabec

Dne četrtek, 11. april 2019 ob 17:27:52 CEST je Maxime Ripard napisal(a):

Quoted 8 lines · Jernej Škrabec
Quoted 7 lines

Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):

Quoted 3 lines

Hi,

On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <[email protected]>

Quoted 1 line · wrote:
Quoted 1 line

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron

napisal(a):

Quoted 46 lines
Quoted 46 lines
Quoted 45 lines
Quoted 35 lines
Quoted 14 lines

Add the mali gpu node to the H6 device-tree.

---

 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 
                      allwinner,sram = <&ve_sram 1>;
 
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 167

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 168

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83

IRQ_TYPE_LEVEL_HIGH>;

Quoted 7 lines

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 171

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

Quoted 7 lines
Quoted 2 lines

I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set).

I asked myself the same question, but the H6 seems to have a supply wired to the GPU, while the H3 and H5 do not. So I'm not sure we want to enable it on all the boards, even though some might have left out the GPU supply which will result in a non-working GPU (I assume?)

Quoted 5 lines

It's true that GPU doesn't work at all without power supply. Even worse, ARM kernel driver just hangs whole SoC if it tries to use unpowered GPU.

I checked few datasheets and almost none of them have GPU power supply, except H5, where GPU is enabled by default in DTSI.

I guess we should fix that then.

Quoted 1 line

Yeah, I guess it's more safe to explicitly enable it in board DT.

It's also something we do for the CPU, even though the CPU should be obviously be powered before starting Linux...

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit https://groups.google.com/d/optout.
#13 lore raw

Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6

In reply to Maxime Ripard
Quoted 54 lines · Maxime Ripard
Quoted 52 lines · Jernej Škrabec

Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):

Quoted 3 lines

Hi,

On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <[email protected]>

Quoted 46 lines · wrote:
Quoted 36 lines

Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):

Quoted 14 lines

Add the mali gpu node to the H6 device-tree.

---

 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index e0dc4a05c1ba..196753110434 100644

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 166

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
@@ -157,6 +157,20 @@
 
                      allwinner,sram = <&ve_sram 1>;
 
              };
 
+             gpu: gpu@1800000 {
+                     compatible = "allwinner,sun50i-h6-mali",
+                                  "arm,mali-t720";
+                     reg = <0x01800000 0x4000>;
+                     interrupts = <GIC_SPI 84

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 167

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 85

IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 168

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -0
+                                  <GIC_SPI 83

IRQ_TYPE_LEVEL_HIGH>;

Quoted 7 lines

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 171

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +5 -0
+                     interrupt-names = "job", "mmu", "gpu";
+                     clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
+                     clock-names = "core", "bus";
+                     resets = <&ccu RST_BUS_GPU>;
+                     status = "disabled";

Usually self sufficient peripherals are enabled by default in DTSI.

I follow the other Mali Midgard (rk3399, rk3288) syntax. But I think you're right here, will go for an update I think.

Quoted 7 lines
Quoted 2 lines

I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set).

I asked myself the same question, but the H6 seems to have a supply wired to the GPU, while the H3 and H5 do not. So I'm not sure we want to enable it on all the boards, even though some might have left out the GPU supply which will result in a non-working GPU (I assume?)

If the default state is enabled, then only devfreq will be disabled for panfrost, but it should otherwise work. I guess we could be smarter and just do frequency changes if all the OPP voltages are the same.

Rob

#14 lore raw

PATCH v2 5/8 arm64: dts: allwinner: Add mali GPU supply for Pine H64

In reply to Clément Péron

Enable and add supply to the Mali GPU node on the
Pine H64 board.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts +5 -0
index 4802902e128f..e16a8c6738f9 100644
@@ -85,6 +85,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&reg_dcdcc>;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
Signature · 1 line
2.17.1
#15 lore raw

PATCH v2 6/8 arm64: dts: allwinner: Add mali GPU supply for Beelink GS1

In reply to Clément Péron

Enable and add supply to the Mali GPU node on the
Beelink GS1 board.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts +5 -0
index 0dc33c90dd60..21440d572f0a 100644
@@ -70,6 +70,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&reg_dcdcc>;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
Signature · 1 line
2.17.1
#16 lore raw

PATCH v2 7/8 arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards

In reply to Clément Péron

Enable and add supply to the Mali GPU node on the
Orange Pi One Plus and Lite2 boards.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi +5 -0
index 62e27948a3fa..bd13297555ab 100644
@@ -55,6 +55,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&reg_dcdcc>;
+	status = "okay";
+};
+
 &mmc0 {
 	vmmc-supply = <&reg_cldo1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.17.1
#17 lore raw

PATCH v2 8/8 arm64: dts: allwinner: Add mali GPU supply for OrangePi 3

In reply to Clément Péron

Enable and add supply to the Mali GPU node on the
Orange Pi 3 board.

---
 arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts +5 -0
index 17d496990108..d4c989cc92a7 100644
@@ -58,6 +58,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&reg_dcdcc>;
+	status = "okay";
+};
+
 &mmc0 {
 	vmmc-supply = <&reg_cldo1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
Signature · 1 line
2.17.1
#18 lore raw
In reply to Clément Péron
Quoted 8 lines · Clément Péron

Hi,

The Allwinner H6 has a Mali-T720 MP2. The drivers are out-of-tree so this series only introduce the dt-bindings.

The first patch is from Neil Amstrong and has been already merged in linux-amlogic. It is required for this series.

Quoted 6 lines

The second patch is from Icenowy Zheng where I changed the order has required by Rob Herring.
See: https://patchwork.kernel.org/patch/10699829/

The GPU opp table was taken from Jernej Škrabec's patch on LibreELEC.tv.

One valuable information here would be which stack did you use, panfrost and mesa or the ARM stack? If so, with which driver and which blob?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit https://groups.google.com/d/optout.
#19 lore raw

Hi!

Dne četrtek, 11. april 2019 ob 14:32:23 CEST je Maxime Ripard napisal(a):

Quoted 13 lines · Clément Péron
Quoted 12 lines

Hi,

The Allwinner H6 has a Mali-T720 MP2. The drivers are out-of-tree so this series only introduce the dt-bindings.

The first patch is from Neil Amstrong and has been already merged in linux-amlogic. It is required for this series.

The second patch is from Icenowy Zheng where I changed the order has required by Rob Herring.
See: https://patchwork.kernel.org/patch/10699829/

Quoted 6 lines
Quoted 2 lines

The GPU opp table was taken from Jernej Škrabec's patch on LibreELEC.tv.

One valuable information here would be which stack did you use, panfrost and mesa or the ARM stack? If so, with which driver and which blob?

I'm using similar binding (different clock and interrupt names, but otherwise same) for quiet some time now on LibreELEC with ARM proprietary userspace and kernel space driver (32-bit GBM version) and it works well.

It's true that I'm using OPP table, but most (if not all) of the time GPU is set to lowest setting as there is not much to do when rendering GUI.

Best regards,
Jernej

#20 lore raw

Hi,

Quoted 23 lines · Jernej Škrabec

Hi!

Dne četrtek, 11. april 2019 ob 14:32:23 CEST je Maxime Ripard napisal(a):

Quoted 19 lines · Clément Péron
Quoted 8 lines

Hi,

The Allwinner H6 has a Mali-T720 MP2. The drivers are out-of-tree so this series only introduce the dt-bindings.

The first patch is from Neil Amstrong and has been already merged in linux-amlogic. It is required for this series.

Quoted 6 lines

The second patch is from Icenowy Zheng where I changed the order has required by Rob Herring.
See: https://patchwork.kernel.org/patch/10699829/

The GPU opp table was taken from Jernej Škrabec's patch on LibreELEC.tv.

One valuable information here would be which stack did you use, panfrost and mesa or the ARM stack? If so, with which driver and which blob?

All of this work has be done by Jernej so he could answer better than me.

He uses the ARM stack r22p0-01rel0 + patches
https://github.com/LibreELEC/LibreELEC.tv/commit/5273f889964c42e88fe02289290c3c6cb6086770

Blob are also from Jernej too (taken from ???) :
https://github.com/jernejsk/H6-mali-userspace

Regards,
Clement

Quoted 5 lines

I'm using similar binding (different clock and interrupt names, but otherwise same) for quiet some time now on LibreELEC with ARM proprietary userspace and kernel space driver (32-bit GBM version) and it works well.

Quoted 7 lines

It's true that I'm using OPP table, but most (if not all) of the time GPU is set to lowest setting as there is not much to do when rendering GUI.

Best regards,
Jernej

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel