Skip to contentSkip to conversation

quota: util-linux libmount is needed to build mount

PATCH New Gilles Talis 2 participants 3 messages Mar 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 quota: util-linux libmount is needed to build mount

quota configuration explicitly selects util-linux mount package, but mount requires libmount to build.

Explicitly select libmount to fix this.

Fixes autobuild errors like:
http://autobuild.buildroot.org/results/2d2f37c292178f746a9a397146719e94f18c022b

---
 package/quota/Config.in |    3 +++
 1 file changed, 3 insertions(+)
package/quota/Config.in +3 -0
index f6341d3..25614f8 100644
@@ -3,8 +3,11 @@ config BR2_PACKAGE_QUOTA
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR
 	depends on BR2_USE_MMU # fork()
+	# libc lacks UTIME_NOW & UTIME_COMMIT for libmount
+	depends on !(BR2_microblazeel || BR2_microblazebe)
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_MOUNT
+	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 quota: util-linux libmount is needed to build mount

Quoted 4 lines · Gilles Talis

quota configuration explicitly selects util-linux mount package, but mount requires libmount to build.

Explicitly select libmount to fix this.

But it's not the proper fix realy, see line 92 of util-linux.mk - it won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES is set, hence it may pass in the autobuilders but you'll never get util-linux mount (and quota will cry when used).
The proper fix is the one i've sent before.
Regards.

#2 lore raw

PATCH 1/1 quota: util-linux libmount is needed to build mount

Hi Gustavo,

2013/3/20 Gustavo Zacarias <[email protected]>:

Quoted 5 lines · Gilles Talis
Quoted 4 lines

quota configuration explicitly selects util-linux mount package, but mount requires libmount to build.

Quoted 7 lines
Quoted 1 line

Explicitly select libmount to fix this.

But it's not the proper fix realy, see line 92 of util-linux.mk - it won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES is set, hence it may pass in the autobuilders but you'll never get util-linux mount (and quota will cry when used).
The proper fix is the one i've sent before.

I simply just missed the patch you have sent earlier on this issue. All apologies.
Thanks for pointing out.

regards
Gilles.