xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
PATCH 1/1 xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.
--- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
276 +1 -2
@@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev _require_btrfs inspect-internal _require_command "/usr/sbin/filefrag"
Signature · 1 line
1.7.10.4
Quoted 13 lines · Wang Sheng-Hui
_require_nobigloopfshas been removed.
We should use_require_no_large_scratch_devin the test script.Signed-off-by Wang Sheng-Hui <[email protected]>--- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)276 +0
-0
276 _need_to_be_root · line 64
Quoted 9 lines
276 +1
-2@@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev _require_btrfs inspect-internal _require_command "/usr/sbin/filefrag"
Does anyone notice this?
I use the upstream xfstests and failed this case for the already-removed function. I think someone patched in but mixed the old function.
I've send out this patch for days, but seems no one cares about it.
If I'm wrong, please let me know.
Thanks,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 20 lines · Wang Sheng-Hui
Quoted 19 lines · Wang Sheng-Hui
_require_nobigloopfshas been removed.
We should use_require_no_large_scratch_devin the test script.Signed-off-by Wang Sheng-Hui <[email protected]>--- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)276 +1
-2@@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev
Quoted 8 lines
276 _need_to_be_root · line 64
Quoted 3 lines
276 +0
-0_require_btrfs inspect-internal _require_command "/usr/sbin/filefrag"Does anyone notice this?
I use the upstream xfstests and failed this case for the already-removed function. I think someone patched in but mixed the old function.
I've send out this patch for days, but seems no one cares about it.
Noticed it, too. I'd just delete that line instead - the test doesn't depend on scratch dev size.
Thanks,
-Jan
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 13 lines · Wang Sheng-Hui
_require_nobigloopfshas been removed.
We should use_require_no_large_scratch_devin the test script.Signed-off-by Wang Sheng-Hui <[email protected]>--- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)276 +0
-0
276 _need_to_be_root · line 64
Quoted 9 lines
276 +1
-2@@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev _require_btrfs inspect-internal _require_command "/usr/sbin/filefrag"
Thanks for the patch.
Not sure what is wrong with your patch (trailing space maybe), but it could not be imported using git quiltimport.
The patch itself makes sense so I have committed the attached:
commit 07c1f8d7bae36f2c28ffee6f09c318b1142b6f90
Author: Wang Sheng-Hui <[email protected]> Date: Thu Mar 21 06:13:23 2013 +0000
xfstests 276: use _require_no_large_scratch_dev instead of the
removed _require_nobigloopfs
Quoted 1 line
From patchwork Thu Mar 21 06:13:23 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: xfstests 276: use _require_no_large_scratch_dev instead of the
removed _require_nobigloopfs
Date: Thu, 21 Mar 2013 06:13:23 -0000
From: Wang Sheng-Hui <[email protected]>
X-Patchwork-Id: 5083
Message-Id: <[email protected]>
To: Dave Chinner <[email protected]>, xfstests <[email protected]>,
[email protected]
_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.
--- 276 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
276 +1 -2
@@ -58,8 +58,7 @@ _need_to_be_root _supported_fs btrfs _supported_os Linux _require_scratch - -_require_nobigloopfs +_require_no_large_scratch_dev _require_btrfs inspect-internal _require_command "/usr/sbin/filefrag"
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs