Skip to contentSkip to conversation

clk: tegra: Fix periph_clk_to_bit macro

PATCH Applied Andrew Chew 6 participants 7 messages Mar 6, 2013 – Mar 22, 2013 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: tegra: Fix periph_clk_to_bit macro

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

---
 drivers/clk/tegra/clk-periph-gate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph-gate.c +1 -1
index 6dd5332..d87e1ce 100644
@@ -41,7 +41,7 @@ static DEFINE_SPINLOCK(periph_ref_lock);
 #define write_rst_clr(val, gate) \
 	writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
 
-#define periph_clk_to_bit(periph) (1 << (gate->clk_num % 32))
+#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
 
 /* Peripheral gate clock ops */
 static int clk_periph_is_enabled(struct clk_hw *hw)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 clk: tegra: Fix periph_clk_to_bit macro

Quoted 3 lines · Andrew Chew

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

Peter, Prashant, can I get an ack/reviewed-by please?

Note: I'm also CC'ing Mike and the LAKML mailing list; common clock driver changes should be sent to Mike as CCF maintainer, and any ARM-related changes should typically get sent to LAKML in the absence of any other specific subsystem list.

Quoted 19 lines
---
 drivers/clk/tegra/clk-periph-gate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph-gate.c +1 -1
index 6dd5332..d87e1ce 100644
@@ -41,7 +41,7 @@ static DEFINE_SPINLOCK(periph_ref_lock);
 #define write_rst_clr(val, gate) \
 	writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
 
-#define periph_clk_to_bit(periph) (1 << (gate->clk_num % 32))
+#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
 
 /* Peripheral gate clock ops */
 static int clk_periph_is_enabled(struct clk_hw *hw)
maintainer
#2 lore raw

PATCH 1/1 clk: tegra: Fix periph_clk_to_bit macro

Quoted 5 lines · Stephen Warren
Quoted 3 lines · Andrew Chew

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

Peter, Prashant, can I get an ack/reviewed-by please?

Thanks for the fix!!

Quoted 28 lines

Note: I'm also CC'ing Mike and the LAKML mailing list; common clock driver changes should be sent to Mike as CCF maintainer, and any ARM-related changes should typically get sent to LAKML in the absence of any other specific subsystem list.

Quoted 11 lines
---
  drivers/clk/tegra/clk-periph-gate.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph-gate.c +0 -0
index 6dd5332..d87e1ce 100644

drivers/clk/tegra/clk-periph-gate.c static DEFINE_SPINLOCK(periph_ref_lock); · line 47

Quoted 8 lines
drivers/clk/tegra/clk-periph-gate.c +1 -1
@@ -41,7 +41,7 @@ static DEFINE_SPINLOCK(periph_ref_lock);
  #define write_rst_clr(val, gate) \
  	writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
 
-#define periph_clk_to_bit(periph) (1 << (gate->clk_num % 32))
+#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
 
  /* Peripheral gate clock ops */
  static int clk_periph_is_enabled(struct clk_hw *hw)

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1362606444-19970-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

Reviewed-by
#4 lore raw
Quoted 15 lines · Andrew Chew

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

---
 drivers/clk/tegra/clk-periph-gate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph-gate.c +0 -0
index 6dd5332..d87e1ce 100644

drivers/clk/tegra/clk-periph-gate.c static DEFINE_SPINLOCK(periph_ref_lock); · line 47

Quoted 8 lines
drivers/clk/tegra/clk-periph-gate.c +1 -1
@@ -41,7 +41,7 @@ static DEFINE_SPINLOCK(periph_ref_lock);
 #define write_rst_clr(val, gate) \
 	writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
 
-#define periph_clk_to_bit(periph) (1 << (gate->clk_num % 32))
+#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
 
 /* Peripheral gate clock ops */
 static int clk_periph_is_enabled(struct clk_hw *hw)
#6 lore raw
In reply to a message not in the archive
Quoted 3 lines · Andrew Chew

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

Mike, could you please ack this so that I can take it through the Tegra tree with the rest of the Tegra clock changes for 3.10? Thanks.

Oh, I see this was never sent to Mike:-( Hence, I'm quoting the whole patch.

Quoted 19 lines
---
 drivers/clk/tegra/clk-periph-gate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph-gate.c +1 -1
index 6dd5332..d87e1ce 100644
@@ -41,7 +41,7 @@ static DEFINE_SPINLOCK(periph_ref_lock);
 #define write_rst_clr(val, gate) \
 	writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
 
-#define periph_clk_to_bit(periph) (1 << (gate->clk_num % 32))
+#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
 
 /* Peripheral gate clock ops */
 static int clk_periph_is_enabled(struct clk_hw *hw)

A message that is not in the archive (sent off-list or not yet received): 20130321212542.834.78153@quantum

#8 lore raw
Quoted 12 lines · Mike Turquette

Quoting Stephen Warren (2013-03-21 12:59:29)

Quoted 10 lines · Andrew Chew
Quoted 3 lines

The parameter name should be "gate", not "periph". This worked, however, because it happens that everywhere periph_clk_to_bit is called, "gate" was in the local scope.

Mike, could you please ack this so that I can take it through the Tegra tree with the rest of the Tegra clock changes for 3.10? Thanks.

Oh, I see this was never sent to Mike:-( Hence, I'm quoting the whole patch.

Quoted 6 lines

Thanks for looping me in to the original patch.

I'm still going through v7 of the tegra114 patches now, so acking this is is a bit out-of-sequence, but the change is trivial enough:

Thanks.

This is actually a fix for the previous existing clock drivers for Tegra20 and Tegra30, so I'll apply it before the Tegra114 CCF series.

Applied to Tegra's for-3.10/clk branch.