git-svn: Support custom tunnel schemes instead of SSH only
PATCH 1/1 git-svn: Support custom tunnel schemes instead of SSH only
This originates from an msysgit pull request, see:
https://github.com/msysgit/git/pull/58
--- perl/Git/SVN/Ra.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
perl/Git/SVN/Ra.pm +1 -1
@@ -295,7 +295,7 @@ sub gs_do_switch { my $full_url = add_path_to_url( $self->url, $path ); my ($ra, $reparented); - if ($old_url =~ m#^svn(\+ssh)?://# || + if ($old_url =~ m#^svn(\+\w+)?://# || ($full_url =~ m#^https?://# && canonicalize_url($full_url) ne $full_url)) { $_[0] = undef;
Signature · 1 line
1.8.1.msysgit.1
Quoted 6 lines · Sebastian Schuberth
This originates from an msysgit pull request, see:
https://github.com/msysgit/git/pull/58
Signed-off-by Eric Wieser <[email protected]>Signed-off-by Sebastian Schuberth <[email protected]>
Thanks, looks obviously correct.
Quoted 6 lines
perl/Git/SVN/Ra.pm +0
-0
perl/Git/SVN/Ra.pm sub gs_do_switch { · line 301
Quoted 8 lines
perl/Git/SVN/Ra.pm +1
-1@@ -295,7 +295,7 @@ sub gs_do_switch { my $full_url = add_path_to_url( $self->url, $path ); my ($ra, $reparented); - if ($old_url =~ m#^svn(\+ssh)?://# || + if ($old_url =~ m#^svn(\+\w+)?://# || ($full_url =~ m#^https?://# && canonicalize_url($full_url) ne $full_url)) { $_[0] = undef;
Junio:
The following changes since commit 2bba2f0e6542d541e9f27653d8c9d5fc8d0e679c:
More topics from the second batch for 1.8.3 (2013-03-26 13:16:11 -0700)
are available in the git repository at:
git://git.bogomips.org/git-svn.git master
for you to fetch changes up to 3747c015704399dea1aa7ae6569a507e5727e20b:
git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)
----------------------------------------------------------------
Sebastian Schuberth (1):
git-svn: Support custom tunnel schemes instead of SSH only
perl/Git/SVN/Ra.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 19 lines · Eric Wong
Quoted 6 lines · Sebastian Schuberth
This originates from an msysgit pull request, see:
https://github.com/msysgit/git/pull/58
Signed-off-by Eric Wieser <[email protected]>Signed-off-by Sebastian Schuberth <[email protected]>Thanks, looks obviously correct.
Signed-off-by Eric Wong <[email protected]>...
Junio:
The following changes since commit
2bba2f0e6542d541e9f27653d8c9d5fc8d0e679c:More topics from the second batch for 1.8.3 (2013-03-26 13:16:11 -0700)
Quoted 7 lines
are available in the git repository at:
git://git.bogomips.org/git-svn.gitmasterfor you to fetch changes up to
3747c015704399dea1aa7ae6569a507e5727e20b:git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)
Thanks. Will pull.
By the way, did nobody in the patch chain find the log message problematic? It does not give any information other than a URL to an external site, and if you look at the URL it refers to, it only says
"git svn fetch" failed while talking to svn+xyz:// at Git/SVN/Ra.pm line 307
which could easily have been written in the log message itself with fewer words.
Quoted 11 lines · Junio C Hamano
Quoted 2 lines · Eric Wong
git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)
Thanks. Will pull.
By the way, did nobody in the patch chain find the log message problematic? It does not give any information other than a URL to an external site, and if you look at the URL it refers to, it only says
Quoted 4 lines
"git svn fetch" failed while talking to svn+xyz:// at Git/SVN/Ra.pm line 307
which could easily have been written in the log message itself with fewer words.
Oops, I wasn't happy with the log message, either, but remained silent since I thought the subject/title for an obvious one-line change was sufficient. In other words, I think an empty log message (+S-o-b) would suffice, too.