Skip to contentSkip to conversation

s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

PATCH New Prasanna Kumar 3 participants 3 messages Mar 26, 2013 – Mar 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

From: Prasanna Kumar <[email protected]>

According to Common Clock framework , modified the method of getting clock for MFC Block.

---
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +1 -1
index 6aa38a5..b8ac8f6 100644
@@ -50,7 +50,7 @@ int s5p_mfc_init_pm(struct s5p_mfc_dev *dev)
 		goto err_p_ip_clk;
 	}
 
-	pm->clock = clk_get(&dev->plat_dev->dev, dev->variant->mclk_name);
+	pm->clock = clk_get_parent(pm->clock_gate);
 	if (IS_ERR(pm->clock)) {
 		mfc_err("Failed to get MFC clock\n");
 		ret = PTR_ERR(pm->clock);
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

Quoting Prasanna Kumar (2013-03-25 22:20:51)

Quoted 15 lines

From: Prasanna Kumar <[email protected]>

According to Common Clock framework , modified the method of getting clock for MFC Block.

---
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +0 -0
index 6aa38a5..b8ac8f6 100644

drivers/media/platform/s5p-mfc/s5p_mfc_pm.c int s5p_mfc_init_pm(struct s5p_mfc_dev *dev) · line 53

Quoted 5 lines
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +1 -1
@@ -50,7 +50,7 @@ int s5p_mfc_init_pm(struct s5p_mfc_dev *dev)
                goto err_p_ip_clk;
        }
 
-       pm->clock = clk_get(&dev->plat_dev->dev, dev->variant->mclk_name);
+       pm->clock = clk_get_parent(pm->clock_gate);

Ok, I'll bite. Why make this change? Was there an issue using clkdev/clk_get to get the clock you needed?

Regards,
Mike

Quoted 11 lines
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +0 -0
        if (IS_ERR(pm->clock)) {
                mfc_err("Failed to get MFC clock\n");
                ret = PTR_ERR(pm->clock);
Signature · 7 lines
1.7.5.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 1/1 s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

Quoted 4 lines · Mike Turquette

Quoting Prasanna Kumar (2013-03-25 22:20:51)

Quoted 3 lines

From: Prasanna Kumar <[email protected]>

According to Common Clock framework , modified the method of getting

Huh ? Could you explain in detail what exactly in this patch is related to the Common Clock Framework ? I guess you mean the new clocks driver ?

Quoted 15 lines
Quoted 15 lines

clock for MFC Block.

---
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +0 -0
index 6aa38a5..b8ac8f6 100644
@@ -50,7 +50,7 @@ int s5p_mfc_init_pm(struct s5p_mfc_dev *dev)
                goto err_p_ip_clk;
        }
 
Quoted 5 lines

drivers/media/platform/s5p-mfc/s5p_mfc_pm.c int s5p_mfc_init_pm(struct s5p_mfc_dev *dev) · line 53

Quoted 2 lines
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c +1 -1
-       pm->clock = clk_get(&dev->plat_dev->dev, dev->variant->mclk_name);
+       pm->clock = clk_get_parent(pm->clock_gate);

Ok, I'll bite. Why make this change? Was there an issue using clkdev/clk_get to get the clock you needed?

Yes, this appears a pretty mysterious change to me... I wonder, have you altered anything at the clock tree definition to make it work ? What platforms has this change been tested on ? For Exynos4, I've changed the sclk_mfc clock definition, so it is possible to assign it to the MFC IP by listing it in the codec DT node clocks property. I suppose something similar is needed for Exynos5, if this is the platform you needed that change for.

BTW, I think the mclk_name field should be removed from struct s5p_mfc_variant, an the driver should use fixed name for the second clock. Now there is "mfc", "sclk_mfc" used for Exynos4 and "mfc", "aclk_133" for Exynos5. Drivers are not really supposed to care about differences like this. Such differences could be easily handled in the device tree. The DT binding documentation just needs to specify the meaning of each clock name.

[1] http://www.spinics.net/lists/arm-kernel/msg233521.html

Regards,

Signature · 2 lines
Sylwester Nawrocki
Samsung Poland R&D Center