Skip to contentSkip to conversation

Fix typo

PATCH New arved at arved.at 3 participants 12 messages Mar 25, 2013 – Mar 31, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Fix typo

From: Tilman Keskin?z <[email protected]>

---
 docs/manual/contribute.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/contribute.txt +1 -1
index 9425eff..0106df0 100644
@@ -1,7 +1,7 @@
 // -*- mode:doc; -*-
 // vim: set syntax=asciidoc:
 
-Contibuting to Buildroot
+Contributing to Buildroot
 ========================
 
 If you want to contribute to Buildroot, you will need a git view of
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/4 Support .dotfiles in / being copied to the TARGET

From: Tilman Keskin?z <[email protected]>

An example is .init_enable_core, to enable coredumps in busybox

---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index f1c98aa..62311ed 100644
@@ -431,7 +431,7 @@ $(BUILD_DIR)/.root:
 	mkdir -p $(TARGET_DIR)
 	if ! [ -d "$(TARGET_DIR)/bin" ]; then \
 		if [ -d "$(TARGET_SKELETON)" ]; then \
-			cp -fa $(TARGET_SKELETON)/* $(TARGET_DIR)/; \
+			rsync -au $(TARGET_SKELETON)/ $(TARGET_DIR)/; \
 		fi; \
 	fi
 	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/4 Support .dotfiles in / being copied to the TARGET

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"arved" == arved <[email protected]> writes:

arved> From: Tilman Keskin?z <[email protected]>
arved> An example is .init_enable_core, to enable coredumps in busybox arved> Signed-off-by: Tilman Keskin?z <[email protected]> arved> ---

 arved>  Makefile |    2 +-

arved> 1 file changed, 1 insertion(+), 1 deletion(-)

arved> diff --git a/Makefile b/Makefile
arved> index f1c98aa..62311ed 100644
arved> --- a/Makefile
arved> +++ b/Makefile
arved> @@ -431,7 +431,7 @@ $(BUILD_DIR)/.root:

 arved>  	mkdir -p $(TARGET_DIR)
 arved>  	if ! [ -d "$(TARGET_DIR)/bin" ]; then \
 arved>  		if [ -d "$(TARGET_SKELETON)" ]; then \

arved> - cp -fa $(TARGET_SKELETON)/* $(TARGET_DIR)/; \
arved> + rsync -au $(TARGET_SKELETON)/ $(TARGET_DIR)/; \

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 3/4 Fix path to pidfile

In reply to arved at arved.at

From: Tilman Keskin?z <[email protected]>

---
 package/busybox/S01logging |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/busybox/S01logging +2 -2
index edece39..37a2c11 100644
@@ -6,13 +6,13 @@
 case "$1" in
   start)
 	echo -n "Starting logging: "
-	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
+	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
 	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
 	echo "OK"
 	;;
   stop)
 	echo -n "Stopping logging: "
-	start-stop-daemon -K -q -p /var/run/syslog.pid
+	start-stop-daemon -K -q -p /var/run/syslogd.pid
 	start-stop-daemon -K -q -p /var/run/klogd.pid
 	echo "OK"
 	;;
Signature · 1 line
1.7.10.4
#4 lore raw

PATCH 3/4 Fix path to pidfile

Quoted 4 lines · arved at arved.at

From: Tilman Keskin?z <[email protected]>

(untested)

Regards,
Arnout

Quoted 25 lines
---
  package/busybox/S01logging |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
package/busybox/S01logging +2 -2
index edece39..37a2c11 100644
@@ -6,13 +6,13 @@
  case "$1" in
    start)
  	echo -n "Starting logging: "
-	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
+	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
  	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
  	echo "OK"
  	;;
    stop)
  	echo -n "Stopping logging: "
-	start-stop-daemon -K -q -p /var/run/syslog.pid
+	start-stop-daemon -K -q -p /var/run/syslogd.pid
  	start-stop-daemon -K -q -p /var/run/klogd.pid
  	echo "OK"
  	;;
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw

PATCH 4/4 Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

In reply to arved at arved.at

From: Tilman Keskin?z <[email protected]>

---
 package/busybox/busybox-1.20.x.config |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/busybox/busybox-1.20.x.config +1 -1
index 5525434..d199996 100644
@@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y
 CONFIG_FEATURE_CLEAN_UP=y
 CONFIG_FEATURE_UTMP=y
 CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y
 CONFIG_FEATURE_SUID=y
 # CONFIG_FEATURE_SUID_CONFIG is not set
 # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
Signature · 1 line
1.7.10.4
#7 lore raw

PATCH 4/4 Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

Hi Tilman,

Quoted 13 lines · arved at arved.at

From: Tilman Keskin?z <[email protected]>

---
  package/busybox/busybox-1.20.x.config |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/busybox/busybox-1.20.x.config +0 -0
index 5525434..d199996 100644

package/busybox/busybox-1.20.x.config CONFIG_FEATURE_DEVPTS=y · line 44

Quoted 5 lines
package/busybox/busybox-1.20.x.config +1 -1
@@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y
  CONFIG_FEATURE_CLEAN_UP=y
  CONFIG_FEATURE_UTMP=y
  CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y

Since we care very much about the size of busybox, could you evaluate
what the size difference is before and after this change? One smallish architecture (e.g. ARM) is enough.

Could you also make this change to the other busybox versions as well?
The different busybox configs should only differ because of features added/removed in that particular version.

Regards,
Arnout

Quoted 4 lines
package/busybox/busybox-1.20.x.config +0 -0
  CONFIG_FEATURE_SUID=y
  # CONFIG_FEATURE_SUID_CONFIG is not set
  # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#8 lore raw

PATCH 4/4 Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

Hi Arnout,

Quoted 10 lines · Arnout Vandecappelle

package/busybox/busybox-1.20.x.config CONFIG_FEATURE_DEVPTS=y · line 44

Quoted 2 lines
package/busybox/busybox-1.20.x.config +1 -1
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y

Since we care very much about the size of busybox, could you evaluate
what the size difference is before and after this change? One smallish architecture (e.g. ARM) is enough.

Could you also make this change to the other busybox versions as well?
The different busybox configs should only differ because of features added/removed in that particular version.

On ARM the difference is 64 Bytes. (gcc 4.6.x)

If you don't want to enable this feature, another option would be to use start-stop-daemon -p in the syslog init script.

What do you think?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130328/2b2c60b7/attachment.asc>

#9 lore raw

PATCH 4/4 Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

Quoted 10 lines · Tilman Keskin?z

Hi Arnout,

Quoted 7 lines · Arnout Vandecappelle

package/busybox/busybox-1.20.x.config CONFIG_FEATURE_DEVPTS=y · line 44

Quoted 2 lines
package/busybox/busybox-1.20.x.config +1 -1
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y

Since we care very much about the size of busybox, could you evaluate
what the size difference is before and after this change? One smallish architecture (e.g. ARM) is enough.

Quoted 5 lines
Quoted 3 lines

Could you also make this change to the other busybox versions as well?
The different busybox configs should only differ because of features added/removed in that particular version.

On ARM the difference is 64 Bytes. (gcc 4.6.x)

Great, then it is a good idea to enable it by default. Can you do it
for all busybox versions?

Question to the list: do we really need to keep several busybox
versions? For U-Boot or kernel it may make some kind of sense, because you have custom patches on top of a specific version. But for busybox?

Quoted 2 lines

If you don't want to enable this feature, another option would be to use start-stop-daemon -p in the syslog init script.

It is already using the -p option, no?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#10 lore raw

PATCH 4/4 Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

Quoted 4 lines · Arnout Vandecappelle
Quoted 2 lines

If you don't want to enable this feature, another option would be to use start-stop-daemon -p in the syslog init script.

It is already using the -p option, no?

Sorry, i meant -m, e.g. let start-stop-daemon handle the pidfile creation.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130328/12366c96/attachment.asc>