Skip to contentSkip to conversation

ARM: tegra: keep power on to SD slot on Dalmore

PATCH New Stephen Warren 2 participants 4 messages Mar 28, 2013 – Mar 29, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: keep power on to SD slot on Dalmore

From: Stephen Warren <[email protected]>

Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards work. This used to work, since this regulator is on by default, but was broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that didn't specify always-on for this regulator.

In the long run, the regulators should all be hooked up to the SDHCI device nodes. However, we haven't done that for any of the Tegra boards yet, so to be consistent, this patch simply forces the regulator on, rather than hooking it up and making it work differently to other boards.

---
 arch/arm/boot/dts/tegra114-dalmore.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/tegra114-dalmore.dts +1 -0
index 2ef9f0e..0d8ceda 100644
@@ -807,6 +807,7 @@
 
 				fet6 {
 					regulator-name = "vdd-sd-slot";
+					regulator-always-on;
 					regulator-boot-on;
 				};
 
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: tegra: keep power on to SD slot on Dalmore

Quoted 12 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards work. This used to work, since this regulator is on by default, but was broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that didn't specify always-on for this regulator.

In the long run, the regulators should all be hooked up to the SDHCI device nodes. However, we haven't done that for any of the Tegra boards yet, so to be consistent, this patch simply forces the regulator on, rather than hooking it up and making it work differently to other boards.

Quoted 4 lines

---

This means we should keep sd slot rails always ON when we populate the power tree for any Tegra board?

#2 lore raw

PATCH 1/1 ARM: tegra: keep power on to SD slot on Dalmore

Quoted 18 lines · Laxman Dewangan
Quoted 12 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards work. This used to work, since this regulator is on by default, but was broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that didn't specify always-on for this regulator.

In the long run, the regulators should all be hooked up to the SDHCI device nodes. However, we haven't done that for any of the Tegra boards yet, so to be consistent, this patch simply forces the regulator on, rather than hooking it up and making it work differently to other boards.

Quoted 4 lines

---

Quoted 4 lines

This means we should keep sd slot rails always ON when we populate the power tree for any Tegra board?

For now yes.

Ideally, our DTs would include the appropriate supply properties in each SDHCI/MMC node, and then everything would work out as it's supposed to. However, that requires verification, and might be interdependent with our SDHCI driver correctly supporting various HS modes that actively require non-default voltages. We have a bug filed to fully flesh out and validate the Tegra MMC driver upstream. It's assigned to Pavan. However, I haven't seen any movement in the Tegra MMC driver area for eons:-( Perhaps you can push on him if he's at the same site?

author Applied
#3 lore raw

PATCH 1/1 ARM: tegra: keep power on to SD slot on Dalmore

In reply to Stephen Warren
Quoted 8 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards work. This used to work, since this regulator is on by default, but was broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that didn't specify always-on for this regulator.

Quoted 5 lines

In the long run, the regulators should all be hooked up to the SDHCI device nodes. However, we haven't done that for any of the Tegra boards yet, so to be consistent, this patch simply forces the regulator on, rather than hooking it up and making it work differently to other boards.

Applied to Tegra's for-3.10/dt branch.