Skip to contentSkip to conversation

Add initial support for mx6slevk board

PATCH New Fabio Estevam 3 participants 7 messages Mar 30, 2013 – Apr 2, 2013

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 Add initial support for mx6slevk board

From: Fabio Estevam <[email protected]>

mx6slevk board is a development board from Freescale based on the mx6 solo lite processor.

For details about mx6slevk, please refer to:
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=IMX6SLEVK&parentCode=i.MX6SL&fpsp=1

---
 MAINTAINERS                                |    1 +
 arch/arm/cpu/armv7/mx6/clock.c             |   38 +-
 arch/arm/include/asm/arch-mx6/crm_regs.h   |    1 +
 arch/arm/include/asm/arch-mx6/imx-regs.h   |   63 +-
 arch/arm/include/asm/arch-mx6/mx6-pins.h   |    4 +
 arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 1374 ++++++++++++++++++++++++++++
 board/freescale/mx6slevk/Makefile          |   28 +
 board/freescale/mx6slevk/imximage.cfg      |  118 +++
 board/freescale/mx6slevk/mx6slevk.c        |  102 +++
 boards.cfg                                 |    1 +
 include/configs/mx6slevk.h                 |  189 ++++
 11 files changed, 1916 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-mx6/mx6sl_pins.h
 create mode 100644 board/freescale/mx6slevk/Makefile
 create mode 100644 board/freescale/mx6slevk/imximage.cfg
 create mode 100644 board/freescale/mx6slevk/mx6slevk.c
 create mode 100644 include/configs/mx6slevk.h
MAINTAINERS +1 -0
index 0f19078..723a316 100644
@@ -665,6 +665,7 @@ Fabio Estevam <[email protected]>
 	mx6qsabresd	i.MX6Q
 	mx6qsabreauto	i.MX6Q
 	wandboard	i.MX6DL/S
+	mx6slevk	i.MX6SL
 
 Daniel Gorsulowski <[email protected]>
 
arch/arm/cpu/armv7/mx6/clock.c +36 -2
index a50db70..8cba4fd 100644
@@ -186,12 +186,16 @@ static u32 get_ipg_per_clk(void)
 static u32 get_uart_clk(void)
 {
 	u32 reg, uart_podf;
-
+	u32 freq = PLL3_80M;
 	reg = __raw_readl(&imx_ccm->cscdr1);
+#ifdef CONFIG_MX6SL
+	if (reg & MXC_CCM_CSCDR1_UART_CLK_SEL)
+		freq = MXC_HCLK;
+#endif
 	reg &= MXC_CCM_CSCDR1_UART_CLK_PODF_MASK;
 	uart_podf = reg >> MXC_CCM_CSCDR1_UART_CLK_PODF_OFFSET;
 
-	return PLL3_80M / (uart_podf + 1);
+	return freq / (uart_podf + 1);
 }
 
 static u32 get_cspi_clk(void)
@@ -252,6 +256,35 @@ static u32 get_emi_slow_clk(void)
 	return root_freq / (emi_slow_pof + 1);
 }
 
+#ifdef CONFIG_MX6SL
+static u32 get_mmdc_ch0_clk(void)
+{
+	u32 cbcmr = __raw_readl(&imx_ccm->cbcmr);
+	u32 cbcdr = __raw_readl(&imx_ccm->cbcdr);
+	u32 freq, podf;
+
+	podf = (cbcdr & MXC_CCM_CBCDR_MMDC_CH1_PODF_MASK) \
+			>> MXC_CCM_CBCDR_MMDC_CH1_PODF_OFFSET;
+
+	switch ((cbcmr & MXC_CCM_CBCMR_PRE_PERIPH2_CLK_SEL_MASK) >>
+		MXC_CCM_CBCMR_PRE_PERIPH2_CLK_SEL_OFFSET) {
+	case 0:
+		freq = decode_pll(PLL_BUS, MXC_HCLK);
+		break;
+	case 1:
+		freq = PLL2_PFD2_FREQ;
+		break;
+	case 2:
+		freq = PLL2_PFD0_FREQ;
+		break;
+	case 3:
+		freq = PLL2_PFD2_DIV_FREQ;
+	}
+
+	return freq / (podf + 1);
+
+}
+#else
 static u32 get_mmdc_ch0_clk(void)
 {
 	u32 cbcdr = __raw_readl(&imx_ccm->cbcdr);
@@ -260,6 +293,7 @@ static u32 get_mmdc_ch0_clk(void)
 
 	return get_periph_clk() / (mmdc_ch0_podf + 1);
 }
+#endif
 
 static u32 get_usdhc_clk(u32 port)
 {
arch/arm/include/asm/arch-mx6/crm_regs.h +1 -0
index 7676457..ede384d 100644
@@ -246,6 +246,7 @@ struct mxc_ccm_reg {
 #define MXC_CCM_CSCDR1_USBOH3_CLK_PODF_MASK		(0x3 << 6)
 #define MXC_CCM_CSCDR1_UART_CLK_PODF_MASK		0x3F
 #define MXC_CCM_CSCDR1_UART_CLK_PODF_OFFSET		0
+#define MXC_CCM_CSCDR1_UART_CLK_SEL			(1 << 6)
 
 /* Define the bits in register CS1CDR */
 #define MXC_CCM_CS1CDR_ESAI_CLK_PODF_MASK		(0x3F << 25)
arch/arm/include/asm/arch-mx6/imx-regs.h +62 -1

136 lines not on this page · raw message

arch/arm/include/asm/arch-mx6/mx6-pins.h +4 -0
index 63f4856..ce865a6 100644
@@ -24,7 +24,11 @@
 #if defined(CONFIG_MX6DL) || defined(CONFIG_MX6S)
 #include "mx6dl_pins.h"
 #else
+#if defined(CONFIG_MX6SL)
+#include "mx6sl_pins.h"
+#else
 #error "Please select cpu"
+#endif	/* CONFIG_MX6SL */
 #endif	/* CONFIG_MX6DL or CONFIG_MX6S */
 #endif	/* CONFIG_MX6Q */
 
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +1374 -0

1,374 lines not on this page · raw message

board/freescale/mx6slevk/Makefile new file +28 -0
new file mode 100644
index 0000000..43af351
@@ -0,0 +1,28 @@
+# (C) Copyright 2013 Freescale Semiconductor, Inc.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB    = $(obj)lib$(BOARD).o
+
+COBJS  := mx6slevk.o
+
+SRCS   := $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+
+$(LIB):        $(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/freescale/mx6slevk/imximage.cfg new file +118 -0

118 lines not on this page · raw message

board/freescale/mx6slevk/mx6slevk.c new file +102 -0

102 lines not on this page · raw message

boards.cfg +1 -0
index 199fcfa..2844712 100644
@@ -256,6 +256,7 @@ mx6qarm2                     arm         armv7       mx6qarm2            freesca
 mx6qsabreauto                arm         armv7       mx6qsabreauto       freescale      mx6		mx6qsabreauto:IMX_CONFIG=board/freescale/mx6qsabreauto/imximage.cfg
 mx6qsabrelite                arm         armv7       mx6qsabrelite       freescale      mx6		mx6qsabrelite:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg
 mx6qsabresd                  arm         armv7       mx6qsabresd         freescale      mx6		mx6qsabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg
+mx6slevk                     arm         armv7       mx6slevk            freescale      mx6		mx6slevk:IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL
 eco5pk                       arm         armv7       eco5pk              8dtech         omap3
 nitrogen6dl                  arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024
 nitrogen6dl2g                arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl2g.cfg,MX6DL,DDR_MB=2048
include/configs/mx6slevk.h new file +189 -0

189 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Add initial support for mx6slevk board

Hi Fabio,

Am 30.03.2013 22:08, schrieb Fabio Estevam:

Quoted 8 lines

From: Fabio Estevam <[email protected]>

mx6slevk board is a development board from Freescale based on the mx6 solo lite processor.

For details about mx6slevk, please refer to:
http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=IMX6SLEVK&parentCode=i.MX6SL&fpsp=1

Quoted 8 lines
---
  MAINTAINERS                                |    1 +
  arch/arm/cpu/armv7/mx6/clock.c             |   38 +-
  arch/arm/include/asm/arch-mx6/crm_regs.h   |    1 +
  arch/arm/include/asm/arch-mx6/imx-regs.h   |   63 +-
  arch/arm/include/asm/arch-mx6/mx6-pins.h   |    4 +
  arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 1374 ++++++++++++++++++++++++++++

Would it make sense to split this patch into two parts? One general "add i.MX6 SoloLite support" and then the "add mx6slevk board board support"?

Quoted 12 lines
  board/freescale/mx6slevk/Makefile          |   28 +
  board/freescale/mx6slevk/imximage.cfg      |  118 +++
  board/freescale/mx6slevk/mx6slevk.c        |  102 +++
  boards.cfg                                 |    1 +
  include/configs/mx6slevk.h                 |  189 ++++
  11 files changed, 1916 insertions(+), 3 deletions(-)

create mode 100644 arch/arm/include/asm/arch-mx6/mx6sl_pins.h create mode 100644 board/freescale/mx6slevk/Makefile create mode 100644 board/freescale/mx6slevk/imximage.cfg create mode 100644 board/freescale/mx6slevk/mx6slevk.c create mode 100644 include/configs/mx6slevk.h

...

Quoted 42 lines
(quoted diff) +1 -0
+#########################################################################
board/freescale/mx6slevk/imximage.cfg new file +35 -0
new file mode 100644
index 0000000..df39a16
@@ -0,0 +1,118 @@
+/*
+ * Copyright (C) 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License or (at your option) any later version.
+ *
+ * Refer docs/README.imxmage for more details about how-to configure
+ * and create imximage boot image
+ *
+ * The syntax is taken as close as possible with the kwbimage
+ */
+
+/* image version */
+
+IMAGE_VERSION 2
+
+/*
+ * Boot Device : one of
+ * spi, sd (the board has no nand neither onenand)
+ */
+
+BOOT_FROM	sd
+
+/*
+ * Device Configuration Data (DCD)
+ *
+ * Each entry must have the format:
+ * Addr-type           Address        Value
+ *
+ * where:
+ *	Addr-type register length (1,2 or 4 bytes)
+ *	Address	  absolute address of the register
+ *	value	  value to be stored in the register

board/freescale/mx6slevk/imximage.cfg line 45

Quoted 10 lines
board/freescale/mx6slevk/imximage.cfg new file +10 -0
+ */
+DATA 4 0x020c4018 0x00260324
+
+DATA 4 0x020c4068 0xffffffff
+DATA 4 0x020c406c 0xffffffff
+DATA 4 0x020c4070 0xffffffff
+DATA 4 0x020c4074 0xffffffff
+DATA 4 0x020c4078 0xffffffff
+DATA 4 0x020c407c 0xffffffff
+DATA 4 0x020c4080 0xffffffff

I haven't looked into the manual, but are these the clock registers? If so, is it necessary to set them to 0xffffffff? Or are these already the default reset values?

...

Quoted 18 lines
include/configs/mx6slevk.h new file +12 -0
new file mode 100644
index 0000000..67b63f4
@@ -0,0 +1,189 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * Configuration settings for the Freescale i.MX6SL EVK board.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ */
+
+#ifndef __CONFIG_H

include/configs/mx6slevk.h line 22

Quoted 10 lines
include/configs/mx6slevk.h new file +10 -0
+#define __CONFIG_H
+
+#include <asm/arch/imx-regs.h>
+#include <asm/sizes.h>
+
+#define CONFIG_MX6
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+
+#define MACH_TYPE_MX6SLEVK		4307

Below, you seem to boot with device tree. Is this necessary, then?

Quoted 39 lines
include/configs/mx6slevk.h new file +39 -0
+#define CONFIG_MACH_TYPE		MACH_TYPE_MX6SLEVK
+
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_INITRD_TAG
+#define CONFIG_REVISION_TAG
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(3 * SZ_1M)
+
+#define CONFIG_BOARD_EARLY_INIT_F
+#define CONFIG_MXC_GPIO
+
+#define CONFIG_MXC_UART
+#define CONFIG_MXC_UART_BASE		UART1_IPS_BASE_ADDR
+
+/* MMC Configs */
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR	0
+
+#define CONFIG_MMC
+#define CONFIG_CMD_MMC
+#define CONFIG_GENERIC_MMC
+#define CONFIG_CMD_FAT
+#define CONFIG_DOS_PARTITION
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+#define CONFIG_CONS_INDEX		1
+#define CONFIG_BAUDRATE			115200
+
+/* Command definition */
+#include <config_cmd_default.h>
+
+#undef CONFIG_CMD_IMLS
+
+#define CONFIG_BOOTDELAY		3
+

include/configs/mx6slevk.h line 71

Quoted 10 lines
include/configs/mx6slevk.h new file +10 -0
+#define CONFIG_LOADADDR			0x80800000
+#define CONFIG_SYS_TEXT_BASE		0x87800000
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"script=boot.scr\0" \
+	"uimage=uImage\0" \
+	"console=ttymxc0\0" \
+	"fdt_high=0xffffffff\0" \
+	"initrd_high=0xffffffff\0" \
+	"fdt_file=imx6sl-evk.dtb\0" \

Is a kernel patch for this already available anywhere?

Best regards

Dirk

author reviewer
#2 lore raw

PATCH 1/1 Add initial support for mx6slevk board

Hi Dirk,

Quoted 2 lines · Dirk Behme

Would it make sense to split this patch into two parts? One general "add i.MX6 SoloLite support" and then the "add mx6slevk board board support"?

Yes, I can split as suggested.

Quoted 6 lines
Quoted 6 lines
board/freescale/mx6slevk/imximage.cfg new file +6 -0
+DATA 4 0x020c4018 0x00260324
+
+DATA 4 0x020c4068 0xffffffff
+DATA 4 0x020c406c 0xffffffff
+DATA 4 0x020c4070 0xffffffff
+DATA 4 0x020c4074 0xffffffff
Quoted 8 lines

board/freescale/mx6slevk/imximage.cfg line 45

Quoted 3 lines
board/freescale/mx6slevk/imximage.cfg new file +3 -0
+DATA 4 0x020c4078 0xffffffff
+DATA 4 0x020c407c 0xffffffff
+DATA 4 0x020c4080 0xffffffff

I haven't looked into the manual, but are these the clock registers? If so, is it necessary to set them to 0xffffffff? Or are these already the default reset values?

Yes, these are the default values, so I can remove them indeed;

Quoted 4 lines
Quoted 1 line

+#define MACH_TYPE_MX6SLEVK 4307

Below, you seem to boot with device tree. Is this necessary, then?

Yes, we need to be able to boot a 3.0.35 kernel from Freescale, which is the only one available for solo-lite currently.

Quoted 10 lines

include/configs/mx6slevk.h line 71

Quoted 7 lines
include/configs/mx6slevk.h new file +7 -0
+#define CONFIG_EXTRA_ENV_SETTINGS \
+       "script=boot.scr\0" \
+       "uimage=uImage\0" \
+       "console=ttymxc0\0" \
+       "fdt_high=0xffffffff\0" \
+       "initrd_high=0xffffffff\0" \
+       "fdt_file=imx6sl-evk.dtb\0" \

Is a kernel patch for this already available anywhere?

Not yet. Only kernel 3.0.35 is available currently.

Regards,

Fabio Estevam

#3 lore raw

PATCH 1/1 Add initial support for mx6slevk board

In reply to Fabio Estevam
Quoted 1 line · Fabio Estevam

From: Fabio Estevam <[email protected]>

<snip>

Quoted 34 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +28 -0
new file mode 100644
index 0000000..cd974d8
@@ -0,0 +1,1374 @@
+/*
+ * Copyright (C) 2013 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#ifndef __ASM_ARCH_MX6_MX6SL_PINS_H__
+#define __ASM_ARCH_MX6_MX6SL_PINS_H__
+
+#include <asm/imx-common/iomux-v3.h>
+
+/* Use to set PAD control */
+#define PAD_CTL_HYS		(1 << 16)
+#define PAD_CTL_PUS_100K_DOWN	(0 << 14)
+#define PAD_CTL_PUS_47K_UP	(1 << 14)
+#define PAD_CTL_PUS_100K_UP	(2 << 14)
+#define PAD_CTL_PUS_22K_UP	(3 << 14)
+
+#define PAD_CTL_PUE		(1 << 13)
+#define PAD_CTL_PKE		(1 << 12)
+#define PAD_CTL_ODE		(1 << 11)
+#define PAD_CTL_SPEED_LOW	(1 << 6)
+#define PAD_CTL_SPEED_MED	(2 << 6)
+#define PAD_CTL_SPEED_HIGH	(3 << 6)
+#define PAD_CTL_DSE_DISABLE	(0 << 3)

arch/arm/include/asm/arch-mx6/mx6sl_pins.h line 38

Quoted 10 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +10 -0
+#define PAD_CTL_DSE_240ohm	(1 << 3)
+#define PAD_CTL_DSE_120ohm	(2 << 3)
+#define PAD_CTL_DSE_80ohm	(3 << 3)
+#define PAD_CTL_DSE_60ohm	(4 << 3)
+#define PAD_CTL_DSE_48ohm	(5 << 3)
+#define PAD_CTL_DSE_40ohm	(6 << 3)
+#define PAD_CTL_DSE_34ohm	(7 << 3)
+#define PAD_CTL_SRE_FAST	(1 << 0)
+#define PAD_CTL_SRE_SLOW	(0 << 0)
+

Is the above same for all the variants of i.Mx?
Can we put this into a common header file?

arch/arm/include/asm/arch-mx6/mx6sl_pins.h line 46

Quoted 8 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +8 -0
+#define IOMUX_CONFIG_SION 0x10
+#define NO_MUX_I                0
+#define NO_PAD_I                0
+enum {
+	MX6_PAD_AUD_MCLK__AUDMUX_AUDIO_CLK_OUT			= IOMUX_PAD(0x02A4, 0x004C, 0, 0x0000, 0, 0),
+	MX6_PAD_AUD_MCLK__PWM4_PWMO				= IOMUX_PAD(0x02A4, 0x004C, 1, 0x0000, 0, 0),
+	MX6_PAD_AUD_MCLK__ECSPI3_RDY				= IOMUX_PAD(0x02A4, 0x004C, 2, 0x06B4, 0, 0),
+	MX6_PAD_AUD_MCLK__FEC_MDC				= IOMUX_PAD(0x02A4, 0x004C, 3, 0x0000, 0, 0),

Is the mx6slevk using all the pins defined here?
If not please take off the unused IOMUX pins so that we don't add dead code.

Regards,
Vikram

author reviewer
#4 lore raw

PATCH 1/1 Add initial support for mx6slevk board

Quoted 2 lines · Vikram Narayanan

Is the above same for all the variants of i.Mx?
Can we put this into a common header file?

Ok, I can try to put this into a common location.

Quoted 7 lines
Quoted 7 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +5 -0
+#define IOMUX_CONFIG_SION 0x10
+#define NO_MUX_I                0
+#define NO_PAD_I                0
+enum {
+       MX6_PAD_AUD_MCLK__AUDMUX_AUDIO_CLK_OUT                  =

IOMUX_PAD(0x02A4, 0x004C, 0, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__PWM4_PWMO =

Quoted 8 lines
Quoted 5 lines

IOMUX_PAD(0x02A4, 0x004C, 1, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__ECSPI3_RDY =
IOMUX_PAD(0x02A4, 0x004C, 2, 0x06B4, 0, 0),
+ MX6_PAD_AUD_MCLK__FEC_MDC =
IOMUX_PAD(0x02A4, 0x004C, 3, 0x0000, 0, 0),

Is the mx6slevk using all the pins defined here?

No, I put all pins for completion.

Quoted 1 line

If not please take off the unused IOMUX pins so that we don't add dead code.

I thought it was common practice to provide the complete IOMUX pin file.

Stefano, please advise.

Regards,

Fabio Estevam

author reviewer
#5 lore raw

PATCH 1/1 Add initial support for mx6slevk board

Quoted 23 lines · Fabio Estevam
Quoted 2 lines · Vikram Narayanan

Is the above same for all the variants of i.Mx?
Can we put this into a common header file?

Ok, I can try to put this into a common location.

Quoted 7 lines
Quoted 7 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +5 -0
+#define IOMUX_CONFIG_SION 0x10
+#define NO_MUX_I                0
+#define NO_PAD_I                0
+enum {
+       MX6_PAD_AUD_MCLK__AUDMUX_AUDIO_CLK_OUT                  =

IOMUX_PAD(0x02A4, 0x004C, 0, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__PWM4_PWMO =

Quoted 8 lines
Quoted 5 lines

IOMUX_PAD(0x02A4, 0x004C, 1, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__ECSPI3_RDY =
IOMUX_PAD(0x02A4, 0x004C, 2, 0x06B4, 0, 0),
+ MX6_PAD_AUD_MCLK__FEC_MDC =
IOMUX_PAD(0x02A4, 0x004C, 3, 0x0000, 0, 0),

Is the mx6slevk using all the pins defined here?

Quoted 1 line

No, I put all pins for completion.

I meant completeness, here.

Quoted 3 lines
Quoted 1 line

If not please take off the unused IOMUX pins so that we don't add dead code.

I thought it was common practice to provide the complete IOMUX pin file.

Looking at mx6q_pins.h I see that the IOMUX table is complete, but mx6dl_pins.h is not, so just want to get a confirmation first before doing v2.

Regards,

Fabio Estevam

#6 lore raw

PATCH 1/1 Add initial support for mx6slevk board

Quoted 28 lines · Fabio Estevam
Quoted 23 lines · Fabio Estevam
Quoted 2 lines · Vikram Narayanan

Is the above same for all the variants of i.Mx?
Can we put this into a common header file?

Ok, I can try to put this into a common location.

Quoted 7 lines
Quoted 7 lines
arch/arm/include/asm/arch-mx6/mx6sl_pins.h new file +5 -0
+#define IOMUX_CONFIG_SION 0x10
+#define NO_MUX_I                0
+#define NO_PAD_I                0
+enum {
+       MX6_PAD_AUD_MCLK__AUDMUX_AUDIO_CLK_OUT                  =

IOMUX_PAD(0x02A4, 0x004C, 0, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__PWM4_PWMO =

Quoted 8 lines
Quoted 5 lines

IOMUX_PAD(0x02A4, 0x004C, 1, 0x0000, 0, 0),
+ MX6_PAD_AUD_MCLK__ECSPI3_RDY =
IOMUX_PAD(0x02A4, 0x004C, 2, 0x06B4, 0, 0),
+ MX6_PAD_AUD_MCLK__FEC_MDC =
IOMUX_PAD(0x02A4, 0x004C, 3, 0x0000, 0, 0),

Is the mx6slevk using all the pins defined here?

Quoted 1 line

No, I put all pins for completion.

I meant completeness, here.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

If not please take off the unused IOMUX pins so that we don't add dead code.

I thought it was common practice to provide the complete IOMUX pin file.

Looking at mx6q_pins.h I see that the IOMUX table is complete, but mx6dl_pins.h is not, so just want to get a confirmation first before doing v2.

Please refer the mx6dl discussion here.
http://www.mail-archive.com/u-boot at lists.denx.de/msg94194.html

It was Troy's idea, to include only the necessary pins.

Regards,
Vikram