Skip to contentSkip to conversation

ARM: EXYNOS: Use wfi macro in platform_do_lowpower

PATCH New Tushar Behera 1 participant 2 messages Mar 8, 2013 – Apr 2, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: EXYNOS: Use wfi macro in platform_do_lowpower

As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower."), wfi macro should be used instead of the hardcoded WFI instruction.

This fixes following oops when the kernel is compiled in Thumb-2 mode on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)

$ reboot
Disabling non-boot CPUs ...
IRQ153 no longer affine to CPU1
CPU1: shutdown
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
Modules linked in:
CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
PC is at 0xc065858e
LR is at exynos_cpu_die+0x53/0xc0
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
arch/arm/mach-exynos/hotplug.c +1 -7
index c3f825b..d9712fe 100644
@@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: EXYNOS: Use wfi macro in platform_do_lowpower

Ping !!!

Quoted 42 lines · Tushar Behera

As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower."), wfi macro should be used instead of the hardcoded WFI instruction.

This fixes following oops when the kernel is compiled in Thumb-2 mode on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)

$ reboot
Disabling non-boot CPUs ...
IRQ153 no longer affine to CPU1
CPU1: shutdown
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
Modules linked in:
CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
PC is at 0xc065858e
LR is at exynos_cpu_die+0x53/0xc0
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
arch/arm/mach-exynos/hotplug.c +1 -7
index c3f825b..d9712fe 100644
@@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
Signature · 1 line
Tushar Behera