Skip to contentSkip to conversation

video: omap2: dss: use PTR_RET function

PATCH In review Andrei Epure 2 participants 2 messages Mar 27, 2013 – Apr 2, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: omap2: dss: use PTR_RET function

Use PTR_RET function instead of IS_ERR + PTR_ERR.
Patch found using coccinelle.

---
 drivers/video/omap2/dss/core.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/omap2/dss/core.c +1 -4
index f8779d4..60cc6fe 100644
@@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
 	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
 			write, &dss_debug_fops);
 
-	if (IS_ERR(d))
-		return PTR_ERR(d);
-
-	return 0;
+	return PTR_RET(d);
 }
 #else /* CONFIG_OMAP2_DSS_DEBUGFS */
 static inline int dss_initialize_debugfs(void)
Signature · 1 line
1.7.9.5
#1 lore raw

Hi,

Quoted 15 lines · Andrei Epure

Use PTR_RET function instead of IS_ERR + PTR_ERR.
Patch found using coccinelle.

---
 drivers/video/omap2/dss/core.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/omap2/dss/core.c +0 -0
index f8779d4..60cc6fe 100644
@@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
 	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,

drivers/video/omap2/dss/core.c int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) · line 187

Quoted 10 lines
drivers/video/omap2/dss/core.c +1 -4
 			write, &dss_debug_fops);
 
-	if (IS_ERR(d))
-		return PTR_ERR(d);
-
-	return 0;
+	return PTR_RET(d);
 }
 #else /* CONFIG_OMAP2_DSS_DEBUGFS */
 static inline int dss_initialize_debugfs(void)

There's an identical patch from Alexandru Gheorghiu already queued.

Tomi