Skip to contentSkip to conversation

meta: update atom-pc-wifi.cfg for audit purposes

PATCH In review Hongxu Jia 2 participants 4 messages Apr 2, 2013 – Apr 3, 2013

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover meta: update atom-pc-wifi.cfg for audit purposes

The following changes since commit 0fac9380caa5eaf8038536413366511c48b579b0:

meta: Remove Cedartrail Machine (2013-02-10 23:54:01 -0500)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-atompc-kernel-warn
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-atompc-kernel-warn

Hongxu Jia (1):
meta: update atom-pc-wifi.cfg for audit purposes

 bsp/atom-pc/atom-pc-wifi.cfg |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 meta: update atom-pc-wifi.cfg for audit purposes

1, When do_kernel_configcheck(such as 3.8.1), it has the following warning:
log.do_kernel_configcheck:
NOTE: validating kernel config, see log.do_kernel_configcheck for details
DEBUG: [non-hardware (4)]: meta/cfg/standard/atom-pc/specified_non_hdw.cfg
This BSP sets config options that are possibly non-hardware related.

[invalid (1)]: meta/cfg/standard/atom-pc/invalid.cfg
This BSP sets config options that are not offered anywhere within this kernel

specified_non_hdw.cfg:
CONFIG_CRC_CCITT
CONFIG_STAGING
CONFIG_WEXT_PRIV
CONFIG_WIRELESS_EXT

invalid.cfg:
CONFIG_RT2860

2, CONFIG_RT2860 is invalid, because it is found in Linux kernels:
2.6.29–2.6.32, 2.6.33–2.6.39, and it is obsolete now. Use CONFIG_RT2800PCI instead. drivers/net/wireless/rt2x00/Kconfig:
56 config RT2800PCI
...
66 ---help---
67 This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
68 Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890, RT3052,
69 RT3090, RT3091 & RT3092

3, STAGING is the menuconfig of RT2860, The menuconfig of current RT2800PCI is RT2X00. Use CONFIG_RT2X00 instead of CONFIG_STAGING.

4, CONFIG_ATH9K_HW and CONFIG_ATH9K_COMMON could be removed, because ATH9K has selected them. drivers/net/wireless/ath/ath9k/Kconfig:
18 config ATH9K
...
21 select ATH9K_HW
...
25 select ATH9K_COMMON

5, CONFIG_CRC_CCITT could be removed, because RT2800PCI has selected it.
drivers/net/wireless/rt2x00/Kconfig:
56 config RT2800PCI
...
64 select CRC_CCITT

6, CONFIG_WIRELESS_EXT and CONFIG_WEXT_PRIV do nothing which means they don't exist in the configure file `.config', remove them.

http://cateee.net/lkddb/web-lkddb/RT2860.html
http://cateee.net/lkddb/web-lkddb/RT2800PCI.html
http://lxr.linux.no/linux/drivers/net/wireless/ath/ath9k/Kconfig
http://lxr.linux.no/linux/drivers/net/wireless/rt2x00/Kconfig

[YOCTO #3490]

---
 bsp/atom-pc/atom-pc-wifi.cfg |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
bsp/atom-pc/atom-pc-wifi.cfg +2 -9
index e6cbc95..7226c08 100644
@@ -1,11 +1,4 @@
-CONFIG_WIRELESS_EXT=y
-CONFIG_WEXT_PRIV=y
-
-CONFIG_ATH9K_HW=y
-CONFIG_ATH9K_COMMON=y
 CONFIG_ATH9K=y
 
-CONFIG_STAGING=y
-CONFIG_RT2860=y
-
-CONFIG_CRC_CCITT=y
+CONFIG_RT2X00=y
+CONFIG_RT2800PCI=y
Signature · 1 line
1.7.10.4
#2 lore raw
In reply to Hongxu Jia
Quoted 8 lines · Hongxu Jia

The following changes since commit 0fac9380caa5eaf8038536413366511c48b579b0:

meta: Remove Cedartrail Machine (2013-02-10 23:54:01 -0500)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-atompc-kernel-warn
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-atompc-kernel-warn

Thanks for the changes, they look good, but we have a couple of process items to fix!

- make sure to cc me directly on kernel config or kernel changes,
otherwise I may
miss them.

- cc [email protected] (you need to subscribe) instead of
oe-core, I'll
update oe-core once the changes are merged

- modify the linux-yocto-<version> meta branch, not the kernel cache
directly. I'll
merge changes to the kernel-cache when integrating the change to the release kernel.

Cheers,

Bruce

Quoted 7 lines

Hongxu Jia (1):
meta: update atom-pc-wifi.cfg for audit purposes

 bsp/atom-pc/atom-pc-wifi.cfg |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
Quoted 8 lines

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"

author
#3 lore raw
Quoted 16 lines · Bruce Ashfield
Quoted 8 lines · Hongxu Jia

The following changes since commit 0fac9380caa5eaf8038536413366511c48b579b0:

   meta: Remove Cedartrail Machine (2013-02-10 23:54:01 -0500)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-atompc-kernel-warn
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-atompc-kernel-warn

Thanks for the changes, they look good, but we have a couple of process items to fix!

- make sure to cc me directly on kernel config or kernel changes,
otherwise I may
miss them.

Quoted 8 lines

- cc [email protected] (you need to subscribe) instead of
oe-core, I'll
update oe-core once the changes are merged

- modify the linux-yocto-<version> meta branch, not the kernel cache
directly. I'll
merge changes to the kernel-cache when integrating the change to the release kernel.

Got it, I will resent the pull request.

Thanks,
Hongxu

Quoted 23 lines

Cheers,

Bruce

Quoted 6 lines

Hongxu Jia (1):
meta: update atom-pc-wifi.cfg for audit purposes

  bsp/atom-pc/atom-pc-wifi.cfg |   11 ++---------
  1 file changed, 2 insertions(+), 9 deletions(-)
Quoted 8 lines

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"