Tegra: Fix MSELECT clock divisors for T30/T114.
Subsystems (2)
PATCH 1/1 Tegra: Fix MSELECT clock divisors for T30/T114.
A comparison of registers between our internal NV U-Boot and u-boot-tegra/next showed some discrepancies in the MSELECT clock divisor programming. T20 doesn't have a MSELECT clk src reg.
Signed-off-by Tom Warren <[email protected]>
--- arch/arm/cpu/arm720t/tegra114/cpu.c | 10 ++++------ arch/arm/cpu/arm720t/tegra30/cpu.c | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-)
arch/arm/cpu/arm720t/tegra114/cpu.c +4 -6
@@ -170,15 +170,13 @@ void t114_init_clocks(void)clock_set_enable (PERIPH_ID_MC1 ,1 );clock_set_enable (PERIPH_ID_DVFS ,1 ); -/* Switch MSELECT clock to PLLP (00) */ -clock_ll_set_source (PERIPH_ID_MSELECT ,0 ); -/* -* Clock divider request for 102MHz would setup MSELECT clock as -* 102MHz for PLLP base 408MHz +* Set MSELECT clock source as PLLP (00), and ask for a clock +* divider that would set the MSELECT clock at 102MHz for a +* PLLP base of 408MHz. */ clock_ll_set_source_divisor (PERIPH_ID_MSELECT ,0 , - (NVBL_PLLP_KHZ /102000 )); +CLK_DIVIDER (NVBL_PLLP_KHZ ,102000 ));/* I2C5 (DVC) gets CLK_M and a divisor of 17 */ clock_ll_set_source_divisor (PERIPH_ID_I2C5 ,3 ,16 );
arch/arm/cpu/arm720t/tegra30/cpu.c +2 -2
@@ -110,8 +110,8 @@ void t30_init_clocks(void)reset_set_enable (PERIPH_ID_MSELECT ,1 );clock_set_enable (PERIPH_ID_MSELECT ,1 ); -/* Switch MSELECT clock to PLLP (00) */ -clock_ll_set_source (PERIPH_ID_MSELECT ,0 ); +/* Switch MSELECT clock to PLLP (00) and use a divisor of 2 */ +clock_ll_set_source_divisor (PERIPH_ID_MSELECT ,0 ,2 );/* * Our high-level clock routines are not available prior to
Signature · 1 line
1.8.1.5
PATCH 1/1 Tegra: Fix MSELECT clock divisors for T30/T114.
Quoted 3 lines · Tom Warren
A comparison of registers between our internal NV U-Boot and u-boot-tegra/next showed some discrepancies in the MSELECT clock divisor programming. T20 doesn't have a MSELECT clk src reg.
I'm not familiar with this code/HW, but it seems OK at a quick glance, so,
Reviewed-by Stephen Warren <[email protected]>