Skip to contentSkip to conversation

xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

PATCH In review Jeff Liu 2 participants 2 messages Apr 4, 2013 – Apr 8, 2013 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 1/1 xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

There is no more users of this Macro, so it's time to kill it dead.

---
 fs/xfs/xfs_log_priv.h |    1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_log_priv.h +0 -1
index 16d8d12..b9ea262 100644
@@ -468,7 +468,6 @@ struct xfs_cil {
  * threshold, yet give us plenty of space for aggregation on large logs.
  */
 #define XLOG_CIL_SPACE_LIMIT(log)	(log->l_logsize >> 3)
-#define XLOG_CIL_HARD_SPACE_LIMIT(log)	(3 * (log->l_logsize >> 4))
 
 /*
  * ticket grant locks, queues and accounting have their own cachlines
Signature · 6 lines
1.7.9.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Jeff Liu

There is no more users of this Macro, so it's time to kill it dead.

---
  fs/xfs/xfs_log_priv.h |    1 -
  1 file changed, 1 deletion(-)
fs/xfs/xfs_log_priv.h +0 -0
index 16d8d12..b9ea262 100644

fs/xfs/xfs_log_priv.h struct xfs_cil { · line 473

Quoted 7 lines
fs/xfs/xfs_log_priv.h +0 -1
@@ -468,7 +468,6 @@ struct xfs_cil {
   * threshold, yet give us plenty of space for aggregation on large logs.
   */
  #define XLOG_CIL_SPACE_LIMIT(log)	(log->l_logsize>>  3)
-#define XLOG_CIL_HARD_SPACE_LIMIT(log)	(3 * (log->l_logsize>>  4))
 
  /*
   * ticket grant locks, queues and accounting have their own cachlines

Removed in commit:

commit 4c2d542f2e786537db33b613d5199dc6d69a96da

Author: Dave Chinner <[email protected]>
Date:   Mon Apr 23 17:54:32 2012 +1000

xfs: Do background CIL flushes via a workqueue

Looks good.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs