Skip to contentSkip to conversation

xfs: Update xfs_log_commit_cil() comments

PATCH In review Jeff Liu 2 participants 2 messages Apr 4, 2013 – Apr 8, 2013 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 1/1 xfs: Update xfs_log_commit_cil() comments

xfs_log_commit_iclog() function has been removed by commits 93b8a585:
xfs: remove the deprecated nodelaylog option

Beginning from Linux 3.3, only delayed logging is supported so that we call xfs_log_commit_cil() at xfs_trans_commit() only, remove the useless comments so.

Signed-off-by Jie Liu <[email protected]>
---
 fs/xfs/xfs_log_cil.c |    4 ----
 1 file changed, 4 deletions(-)
fs/xfs/xfs_log_cil.c +0 -4
index ddc4529..e3d0b85 100644
@@ -668,10 +668,6 @@ xlog_cil_push_foreground(
  * transaction to the checkpoint context so we carry the busy extents through
  * to checkpoint completion, and then unlock all the items in the transaction.
  *
- * For more specific information about the order of operations in
- * xfs_log_commit_cil() please refer to the comments in
- * xfs_trans_commit_iclog().
- *
  * Called with the context lock already held in read mode to lock out
  * background commit, returns without it held once background commits are
  * allowed again.
Signature · 6 lines
1.7.9.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Jeff Liu

xfs_log_commit_iclog() function has been removed by commits 93b8a585:
xfs: remove the deprecated nodelaylog option

Beginning from Linux 3.3, only delayed logging is supported so that we call xfs_log_commit_cil() at xfs_trans_commit() only, remove the useless comments so.

Signed-off-by Jie Liu<[email protected]>
---
  fs/xfs/xfs_log_cil.c |    4 ----
  1 file changed, 4 deletions(-)
fs/xfs/xfs_log_cil.c +0 -0
index ddc4529..e3d0b85 100644

fs/xfs/xfs_log_cil.c xlog_cil_push_foreground( · line 673

Quoted 10 lines
fs/xfs/xfs_log_cil.c +0 -4
@@ -668,10 +668,6 @@ xlog_cil_push_foreground(
   * transaction to the checkpoint context so we carry the busy extents through
   * to checkpoint completion, and then unlock all the items in the transaction.
   *
- * For more specific information about the order of operations in
- * xfs_log_commit_cil() please refer to the comments in
- * xfs_trans_commit_iclog().
- *
   * Called with the context lock already held in read mode to lock out
   * background commit, returns without it held once background commits are
   * allowed again.

And the log is documented in Documents/filesystems/xfs-delayed-logging-design.txt.

Looks good.

Reviewed-by Mark Tinguely <[email protected]>

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs