Skip to contentSkip to conversation

drivers/gpu/drm/nouveau: remove erroneous semicolon

PATCH In review Chen Gang 4 participants 9 messages Mar 27, 2013 – Apr 7, 2013

Subsystems (3)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/gpu/drm/nouveau: remove erroneous semicolon

need remove semicolon, or always return true.

---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +1 -1
index 7f0e6c3..1ddc03e 100644
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
Signature · 1 line
1.7.7.6
author
#1 lore raw

Hello maintainers:

when you have time, please help to check this patch whether is OK.

thanks.

gchen.

Quoted 22 lines · Chen Gang

need remove semicolon, or always return true.

---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +1 -1
index 7f0e6c3..1ddc03e 100644
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
Signature · 3 lines
Chen Gang

Asianux Corporation
author
#2 lore raw

Hello Greg KH:

when you have time, can you help to check this patch whether OK ?

thanks.

gchen.

Quoted 34 lines · Chen Gang

Hello maintainers:

when you have time, please help to check this patch whether is OK.

thanks.

gchen.

Quoted 22 lines · Chen Gang

need remove semicolon, or always return true.

---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +1 -1
index 7f0e6c3..1ddc03e 100644
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
Signature · 3 lines
Chen Gang

Asianux Corporation
#3 lore raw
Quoted 3 lines · Chen Gang

Hello Greg KH:

when you have time, can you help to check this patch whether OK ?

No.

author
#4 lore raw
Quoted 8 lines · Greg KH
Quoted 3 lines · Chen Gang

Hello Greg KH:

when you have time, can you help to check this patch whether OK ?

No.

Why ? does it also need a test ??

Signature · 3 lines
Chen Gang

Asianux Corporation
#5 lore raw
Quoted 6 lines · Chen Gang
Quoted 4 lines · Greg KH
Quoted 2 lines · Chen Gang

Hello Greg KH:
when you have time, can you help to check this patch whether OK ?

No.

Why ? does it also need a test ??

Greg's not the nouveau maintainer/babysitter and
likely doesn't have the time/hardware/desire to
test it.

The patch should be simply be sent to David Airlie and dri-devel.

It is a pretty obvious typo though.

author
#6 lore raw

thank you very much for your reply, firstly.

Quoted 5 lines · Joe Perches
Quoted 4 lines · Chen Gang
Quoted 4 lines · Greg KH
Quoted 3 lines
Quoted 3 lines · Chen Gang
Quoted 2 lines
Quoted 2 lines

Hello Greg KH:
when you have time, can you help to check this patch whether OK ?

Quoted 9 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

No.

Why ? does it also need a test ??

Greg's not the nouveau maintainer/babysitter and
likely doesn't have the time/hardware/desire to
test it.

The patch should be simply be sent to David Airlie and dri-devel.

ok, thanks, it seems, I need a little more patience.

:-)

Quoted 2 lines

It is a pretty obvious typo though.

I guess so, too.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation
Acked-by on v1 1/1
#7 lore raw
In reply to Chen Gang

Dear Chen,

Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang:

Quoted 1 line

need remove semicolon, or always return true.

do you know if this cause any problems? Did you find this reading the code or by using some tools?

Quoted 10 lines
---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +0 -0
index 7f0e6c3..1ddc03e 100644

drivers/gpu/drm/nouveau/nv50_display.c nv50_display_flip_wait(void *data) · line 485

Quoted 8 lines
drivers/gpu/drm/nouveau/nv50_display.c +1 -1
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;

Thanks,

Paul

author
#8 lore raw
Quoted 2 lines · Paul Menzel

do you know if this cause any problems? Did you find this reading the code or by using some tools?

sorry, I do not know if this can cause any problems.

for this issue, I did not find it by reading code.

I find it by using compiler warnings with EXTRA_CFLAGS=-W

thanks.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation