Skip to contentSkip to conversation

kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

PATCH New Holger Brunck 4 participants 5 messages Jan 16, 2013 – Apr 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

From: Gerlando Falauto <[email protected]>

If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead of the 1-bit error correction code on the NAND device.

cc Valentin Longchamp <[email protected]>
cc Prafulla Wadaskar <[email protected]>
---
 drivers/mtd/nand/kirkwood_nand.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mtd/nand/kirkwood_nand.c +4 -0
index bdab5aa..0a99a10 100644
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int chip)
 int board_nand_init(struct nand_chip *nand)
 {
 	nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+#if defined(CONFIG_NAND_ECC_BCH)
+	nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
 	nand->ecc.mode = NAND_ECC_SOFT;
+#endif
 	nand->cmd_ctrl = kw_nand_hwcontrol;
 	nand->chip_delay = 40;
 	nand->select_chip = kw_nand_select_chip;
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

Quoted 41 lines

-----Original Message-----
From: Holger Brunck [mailto:holger.brunck at keymile.com]
Sent: 16 January 2013 14:04
To: u-boot at lists.denx.de
Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla Wadaskar
Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

From: Gerlando Falauto <[email protected]>

If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead of
the 1-bit error correction code on the NAND device.

cc Valentin Longchamp <[email protected]>
cc Prafulla Wadaskar <[email protected]>
---
 drivers/mtd/nand/kirkwood_nand.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mtd/nand/kirkwood_nand.c +4 -0
index bdab5aa..0a99a10 100644
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int
 chip)
 int board_nand_init(struct nand_chip *nand)
 {
 	nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+#if defined(CONFIG_NAND_ECC_BCH)
+	nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
 	nand->ecc.mode = NAND_ECC_SOFT;
+#endif
 	nand->cmd_ctrl = kw_nand_hwcontrol;
 	nand->chip_delay = 40;
Quoted 1 line

nand->select_chip = kw_nand_select_chip;

Will pull this latter.

Regards...
Prafulla . . .

Quoted 2 lines

--
1.7.1

#2 lore raw

PATCH 1/1 kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

Quoted 46 lines · Prafulla Wadaskar
Quoted 10 lines

-----Original Message-----
From: Holger Brunck [mailto:holger.brunck at keymile.com]
Sent: 16 January 2013 14:04
To: u-boot at lists.denx.de
Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla Wadaskar
Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

Quoted 3 lines

From: Gerlando Falauto <[email protected]>

If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code

instead

drivers/mtd/nand/kirkwood_nand.c void kw_nand_select_chip(struct mtd_info *mtd,

Quoted 17 lines

of
the 1-bit error correction code on the NAND device.

cc Valentin Longchamp <[email protected]>
cc Prafulla Wadaskar <[email protected]>
---
 drivers/mtd/nand/kirkwood_nand.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mtd/nand/kirkwood_nand.c +0 -0
index bdab5aa..0a99a10 100644
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd,  

int

Quoted 11 lines
drivers/mtd/nand/kirkwood_nand.c +4 -0
 chip)
 int board_nand_init(struct nand_chip *nand)
 {
 	nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+#if defined(CONFIG_NAND_ECC_BCH)
+	nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
 	nand->ecc.mode = NAND_ECC_SOFT;
+#endif
 	nand->cmd_ctrl = kw_nand_hwcontrol;
 	nand->chip_delay = 40;
Quoted 1 line

nand->select_chip = kw_nand_select_chip;

Quoted 1 line

Will pull this latter.

-Scott

#3 lore raw

PATCH 1/1 kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

In reply to Prafulla Wadaskar

Hi Prafulla,

could you please pull these before we hit 2013.04?

Namely:
http://patchwork.ozlabs.org/patch/212438/
http://patchwork.ozlabs.org/patch/212441/
http://patchwork.ozlabs.org/patch/212439/
http://patchwork.ozlabs.org/patch/212440/

Thanks!
Gerlando

Quoted 52 lines · Prafulla Wadaskar
Quoted 41 lines

-----Original Message-----
From: Holger Brunck [mailto:holger.brunck at keymile.com]
Sent: 16 January 2013 14:04
To: u-boot at lists.denx.de
Cc: Gerlando Falauto; Holger Brunck; Valentin Longchamp; Prafulla Wadaskar
Subject: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

From: Gerlando Falauto <[email protected]>

If CONFIG_NAND_ECC_BCH is set use 4-bit error correction code instead of
the 1-bit error correction code on the NAND device.

cc Valentin Longchamp <[email protected]>
cc Prafulla Wadaskar <[email protected]>
---
  drivers/mtd/nand/kirkwood_nand.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mtd/nand/kirkwood_nand.c +4 -0
index bdab5aa..0a99a10 100644
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct mtd_info *mtd, int
 chip)
  int board_nand_init(struct nand_chip *nand)
  {
  	nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+#if defined(CONFIG_NAND_ECC_BCH)
+	nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
  	nand->ecc.mode = NAND_ECC_SOFT;
+#endif
  	nand->cmd_ctrl = kw_nand_hwcontrol;
  	nand->chip_delay = 40;
Quoted 1 line
  	nand->select_chip = kw_nand_select_chip;

Will pull this latter.

Regards...
Prafulla . . .

Quoted 2 lines

--
1.7.1

#4 lore raw

PATCH 1/1 kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

Sure, I will check and do the needful, thanks.

Regards...
Prafulla . . .

Quoted 86 lines

-----Original Message-----
From: Gerlando Falauto [mailto:gerlando.falauto at keymile.com]
Sent: 08 April 2013 14:12
To: Prafulla Wadaskar
Cc: Brunck, Holger; u-boot at lists.denx.de; Longchamp, Valentin
Subject: Re: [PATCH] kirkwood_nand: allow usage of NAND_ECC_SOFT_BCH

Hi Prafulla,

could you please pull these before we hit 2013.04?

Namely:
http://patchwork.ozlabs.org/patch/212438/
http://patchwork.ozlabs.org/patch/212441/
http://patchwork.ozlabs.org/patch/212439/
http://patchwork.ozlabs.org/patch/212440/

Thanks!
Gerlando

Quoted 4 lines · Prafulla Wadaskar
Quoted 4 lines

-----Original Message-----
From: Holger Brunck

[mailto:holger.brunck at keymile.com]

Quoted 3 lines
Quoted 3 lines

Sent: 16 January 2013 14:04
To: u-boot at lists.denx.de
Cc: Gerlando Falauto; Holger Brunck; Valentin

Longchamp; Prafulla

Quoted 2 lines
Quoted 2 lines

Wadaskar
Subject: [PATCH] kirkwood_nand: allow usage of

NAND_ECC_SOFT_BCH

Quoted 2 lines
Quoted 2 lines

From: Gerlando Falauto

<[email protected]>

Quoted 2 lines
Quoted 2 lines

If CONFIG_NAND_ECC_BCH is set use 4-bit error

correction code instead

Quoted 4 lines
Quoted 4 lines

of
the 1-bit error correction code on the NAND device.

Signed-off-by Gerlando Falauto

<[email protected]>

Quoted 1 line
Quoted 1 line
Signed-off-by Holger Brunck

<[email protected]>

Quoted 1 line
Quoted 1 line
cc Valentin Longchamp

<[email protected]>

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c void kw_nand_select_chip(struct

Quoted 11 lines
cc Prafulla Wadaskar <[email protected]>
---
  drivers/mtd/nand/kirkwood_nand.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mtd/nand/kirkwood_nand.c +0 -0
index bdab5aa..0a99a10 100644
@@ -74,7 +74,11 @@ void kw_nand_select_chip(struct

mtd_info *mtd, int

Quoted 4 lines

drivers/mtd/nand/kirkwood_nand.c void kw_nand_select_chip(struct mtd_info *mtd, int chip)

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c +0 -0
 chip)
  int board_nand_init(struct nand_chip *nand)
  {
  	nand->options = NAND_COPYBACK | NAND_CACHEPRG |

NAND_NO_PADDING;

Quoted 18 lines
Quoted 8 lines
drivers/mtd/nand/kirkwood_nand.c +4 -0
+#if defined(CONFIG_NAND_ECC_BCH)
+	nand->ecc.mode = NAND_ECC_SOFT_BCH;
+#else
  	nand->ecc.mode = NAND_ECC_SOFT;
+#endif
  	nand->cmd_ctrl = kw_nand_hwcontrol;
  	nand->chip_delay = 40;
  	nand->select_chip = kw_nand_select_chip;

Will pull this latter.

Regards...
Prafulla . . .

Quoted 2 lines

--
1.7.1