nfsd: don't calculate mem's size in loop every time
Subsystems (2)
PATCH 1/1 nfsd: don't calculate mem's size in loop every time
Signed-off-by fanchaoting <[email protected]>
--- fs/nfsd/nfs4state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/nfsd/nfs4state.c +1 -1
@@ -716,8 +716,8 @@ static struct nfsd4_session *__alloc_session(int slotsize, int numslots)if (!new)return NULL ;/* allocate each struct nfsd4_slot and data cache in one piece */ + mem =sizeof (struct nfsd4_slot ) + slotsize;for (i =0 ; i < numslots; i++) { - mem =sizeof (struct nfsd4_slot ) + slotsize; new->se_slots[i] =kzalloc (mem,GFP_KERNEL );if (!new->se_slots[i]) goto out_free;
Signature · 1 line
1.7.1
Quoted 2 lines · fanchaoting
Signed-off-by fanchaoting <[email protected]>
Thanks, this makes sense, but meanwhile I've been rewriting that code--now pushed out to my for-3.10 branch. Let me know if you see anything that looks wrong there.
--b.
Quoted 24 lines
--- fs/nfsd/nfs4state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/nfsd/nfs4state.c +1
-1@@ -716,8 +716,8 @@ static struct nfsd4_session *__alloc_session(int slotsize, int numslots)if (!new)return NULL ;/* allocate each struct nfsd4_slot and data cache in one piece */ + mem =sizeof (struct nfsd4_slot ) + slotsize;for (i =0 ; i < numslots; i++) { - mem =sizeof (struct nfsd4_slot ) + slotsize; new->se_slots[i] =kzalloc (mem,GFP_KERNEL );if (!new->se_slots[i]) goto out_free;Signature · 5 lines
1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html