Remove SH2 and SH3 support
cover Remove SH2 and SH3 support
Hello,
Here is a set of two patches that remove support for SH2 and SH3. The retionale for the removal is part of the commit log of the second patch. The first patch is only a preliminary cleanup, it can be committed regardless of the decision for the second patch.
I've already removed the SH2 toolchain configuration from my autobuilders.
Thanks.
Thomas Petazzoni (2):
fs/jffs2: refactor endianess selection to use BR2_ENDIAN
arch: remove support for SuperH 2 and SuperH 3
arch/Config.in.sh | 18 ++------------ fs/jffs2/Config.in | 5 +--- package/flashbench/flashbench.mk | 4 +-- package/kexec/Config.in | 2 +- package/multimedia/mplayer/Config.in | 3 +-- toolchain/toolchain-external/Config.in | 40 ------------------------------ toolchain/toolchain-external/ext-tool.mk | 6 ----- toolchain/uClibc/uclibc.mk | 20 --------------- 8 files changed, 7 insertions(+), 91 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/2 fs/jffs2: refactor endianess selection to use BR2_ENDIAN
Instead of explicitly listing the sub-architectures or architectures that are big-endian, use BR2_ENDIAN directly.
--- fs/jffs2/Config.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
fs/jffs2/Config.in +1 -4
@@ -92,10 +92,7 @@ config BR2_TARGET_ROOTFS_JFFS2_PADSIZE choice prompt "Endianess" - default BR2_TARGET_ROOTFS_JFFS2_BE if BR2_armeb || \ - BR2_avr32 || BR2_m68k || BR2_mips || \ - BR2_powerpc || BR2_sh2 || BR2_sh2a || \ - BR2_sh3eb || BR2_sh4eb || BR2_sh4aeb || BR2_sparc + default BR2_TARGET_ROOTFS_JFFS2_BE if BR2_ENDIAN = "BIG" config BR2_TARGET_ROOTFS_JFFS2_LE bool "little-endian"
Signature · 1 line
1.7.9.5
PATCH 1/2 fs/jffs2: refactor endianess selection to use BR2_ENDIAN
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Thomas> Instead of explicitly listing the sub-architectures or architectures Thomas> that are big-endian, use BR2_ENDIAN directly.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/2 arch: remove support for SuperH 2 and SuperH 3
In reply to Thomas PetazzoniThe SuperH 2 architecture is a noMMU architecture from Renesas, and its Linux support is really poor. A number of packages fail to build, the kernel support is almost inexistant, we have never heard of any user of it.
I was originally the one who introduced support for SuperH 2, but the project switched to a different architecture due to the poor Linux support for SuperH 2.
Regarding SuperH 3, I've never heard of Linux support for it that is used in practice.
--- arch/Config.in.sh | 18 ++------------ package/flashbench/flashbench.mk | 4 +-- package/kexec/Config.in | 2 +- package/multimedia/mplayer/Config.in | 3 +-- toolchain/toolchain-external/Config.in | 40 ------------------------------ toolchain/toolchain-external/ext-tool.mk | 6 ----- toolchain/uClibc/uclibc.mk | 20 --------------- 7 files changed, 6 insertions(+), 87 deletions(-)
arch/Config.in.sh +2 -16
@@ -5,14 +5,6 @@ choice help Specific CPU variant to use -config BR2_sh2 - bool "sh2 (SH2 big endian)" -config BR2_sh2a - bool "sh2a (SH2A big endian)" -config BR2_sh3 - bool "sh3 (SH3 little endian)" -config BR2_sh3eb - bool "sh3eb (SH3 big endian)" config BR2_sh4 bool "sh4 (SH4 little endian)" config BR2_sh4eb
@@ -24,10 +16,6 @@ config BR2_sh4aeb endchoice config BR2_ARCH - default "sh2" if BR2_sh2 - default "sh2a" if BR2_sh2a - default "sh3" if BR2_sh3 - default "sh3eb" if BR2_sh3eb default "sh4" if BR2_sh4 default "sh4eb" if BR2_sh4eb default "sh4a" if BR2_sh4a
@@ -35,7 +23,5 @@ config BR2_ARCH default "sh64" if BR2_sh64 config BR2_ENDIAN - default "LITTLE" if BR2_sh3 || BR2_sh4 || BR2_sh4a || \ - BR2_x86_64 || BR2_sh64 - default "BIG" if BR2_sh2 || BR2_sh2a || BR2_sh3eb || \ - BR2_sh4eb || BR2_sh4aeb + default "LITTLE" if BR2_sh4 || BR2_sh4a || BR2_sh64 + default "BIG" if BR2_sh4eb || BR2_sh4aeb
package/flashbench/flashbench.mk +2 -2
@@ -11,8 +11,8 @@ FLASHBENCH_LICENSE_FILES = COPYING FLASHBENCH_CFLAGS = $(TARGET_CFLAGS) -ifeq ($(BR2_microblaze)$(BR2_sh2a),y) -# microblaze and sh2a toolchains only provide LLONG_MAX when used with gnu99 dialect +ifeq ($(BR2_microblaze),y) +# microblaze toolchains only provide LLONG_MAX when used with gnu99 dialect FLASHBENCH_CFLAGS += -std=gnu99 endif
package/kexec/Config.in +1 -1
@@ -2,7 +2,7 @@ config BR2_PACKAGE_KEXEC bool "kexec" depends on BR2_i386 || BR2_x86_64 || BR2_arm || BR2_armeb || \ BR2_mips || BR2_mips64 || BR2_mipsel || BR2_mips64el || \ - BR2_powerpc || BR2_sh4 || BR2_sh4a || BR2_sh3 + BR2_powerpc || BR2_sh4 || BR2_sh4a help Kexec is a user space utiltity for loading another kernel and asking the currently running kernel to do something with it.
package/multimedia/mplayer/Config.in +1 -2
@@ -1,8 +1,7 @@ config BR2_PACKAGE_MPLAYER bool "mplayer" # Those architectures are not supported by MPlayer - depends on !(BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ - || BR2_microblaze || BR2_aarch64) + depends on !(BR2_sh4a || BR2_sh4aeb || BR2_microblaze || BR2_aarch64) depends on BR2_LARGEFILE help MPlayer is a movie player which runs on many systems and supports
toolchain/toolchain-external/Config.in +0 -40
@@ -471,44 +471,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201103 - SH4A, uClibc, big endian Not usable in Buildroot yet. -config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103 - bool "Sourcery CodeBench SH 2011.03" - depends on BR2_sh2a - depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" - select BR2_TOOLCHAIN_EXTERNAL_UCLIBC - select BR2_LARGEFILE - select BR2_TOOLCHAIN_HAS_NATIVE_RPC - select BR2_USE_WCHAR - select BR2_TOOLCHAIN_HAS_THREADS - select BR2_TOOLCHAIN_HAS_THREADS_DEBUG - select BR2_INSTALL_LIBSTDCPP - select BR2_HOSTARCH_NEEDS_IA32_LIBS - help - Sourcery CodeBench toolchain for the SuperH architecture, - from Mentor Graphics. It uses gcc 4.5.2, binutils 2.20, - uClibc 0.9.30, gdb 7.2.50 and kernel headers 2.6.38. It has - support for the following variants: - - SH2A, uClibc, big endian - -config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009 - bool "Sourcery CodeBench SH 2010.09" - depends on BR2_sh2a - depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" - select BR2_TOOLCHAIN_EXTERNAL_UCLIBC - select BR2_LARGEFILE - select BR2_TOOLCHAIN_HAS_NATIVE_RPC - select BR2_USE_WCHAR - select BR2_TOOLCHAIN_HAS_THREADS - select BR2_TOOLCHAIN_HAS_THREADS_DEBUG - select BR2_INSTALL_LIBSTDCPP - select BR2_HOSTARCH_NEEDS_IA32_LIBS - help - Sourcery CodeBench toolchain for the SuperH architecture, - from Mentor Graphics. It uses gcc 4.5.1, binutils 2.20, - uClibc 0.9.30, gdb 7.2.50 and kernel headers 2.6.35.2. It - has support for the following variants: - - SH2A, uClibc, big endian - config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209 bool "Sourcery CodeBench x86/x86_64 2012.09" depends on BR2_i386 || BR2_x86_64
@@ -779,8 +741,6 @@ config BR2_TOOLCHAIN_EXTERNAL_PREFIX default "sh-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201103 default "sh-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201203 default "sh-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201209 - default "sh-uclinux" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009 - default "sh-uclinux" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103 default "i686-pc-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109 default "i686-pc-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201203 default "i686-pc-linux-gnu" if BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209
toolchain/toolchain-external/ext-tool.mk +0 -6
@@ -225,12 +225,6 @@ TOOLCHAIN_EXTERNAL_SOURCE=renesas-2012.03-35-sh-linux-gnu-i686-pc-linux-gnu.tar. else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201209),y) TOOLCHAIN_EXTERNAL_SITE=https://sourcery.mentor.com/public/gnu_toolchain/sh-linux-gnu/ TOOLCHAIN_EXTERNAL_SOURCE=renesas-2012.09-61-sh-linux-gnu-i686-pc-linux-gnu.tar.bz2 -else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009),y) -TOOLCHAIN_EXTERNAL_SITE=http://sourcery.mentor.com/public/gnu_toolchain/sh-uclinux/ -TOOLCHAIN_EXTERNAL_SOURCE=renesas-2010.09-60-sh-uclinux-i686-pc-linux-gnu.tar.bz2 -else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103),y) -TOOLCHAIN_EXTERNAL_SITE=http://sourcery.mentor.com/public/gnu_toolchain/sh-uclinux/ -TOOLCHAIN_EXTERNAL_SOURCE=renesas-2011.03-36-sh-uclinux-i686-pc-linux-gnu.tar.bz2 else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109),y) TOOLCHAIN_EXTERNAL_SITE=https://sourcery.mentor.com/public/gnu_toolchain/i686-pc-linux-gnu/ TOOLCHAIN_EXTERNAL_SOURCE=ia32-2011.09-24-i686-pc-linux-gnu-i386-linux.tar.bz2
toolchain/uClibc/uclibc.mk +0 -20
@@ -181,26 +181,6 @@ ifeq ($(UCLIBC_TARGET_ARCH),sh) /bin/echo "# CONFIG_SH2 is not set" >> $(UCLIBC_DIR)/.oldconfig /bin/echo "# CONFIG_SH3 is not set" >> $(UCLIBC_DIR)/.oldconfig /bin/echo "# CONFIG_SH4 is not set" >> $(UCLIBC_DIR)/.oldconfig -ifeq ($(BR2_sh2a),y) - $(SED) 's,# CONFIG_SH2A is not set,CONFIG_SH2A=y,g' $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FDPIC_ELF is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FLAT is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FLAT_SEP_DATA is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_SHARED_FLAT is not set" >> $(UCLIBC_DIR)/.oldconfig -endif -ifeq ($(BR2_sh2),y) - $(SED) 's,# CONFIG_SH2 is not set,CONFIG_SH2=y,g' $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FDPIC_ELF is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FLAT is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_FLAT_SEP_DATA is not set" >> $(UCLIBC_DIR)/.oldconfig - /bin/echo "# UCLIBC_FORMAT_SHARED_FLAT is not set" >> $(UCLIBC_DIR)/.oldconfig -endif -ifeq ($(BR2_sh3eb),y) - $(SED) 's,# CONFIG_SH3 is not set,CONFIG_SH3=y,g' $(UCLIBC_DIR)/.oldconfig -endif -ifeq ($(BR2_sh3),y) - $(SED) 's,# CONFIG_SH3 is not set,CONFIG_SH3=y,g' $(UCLIBC_DIR)/.oldconfig -endif ifeq ($(BR2_sh4eb),y) $(SED) 's,# CONFIG_SH4 is not set,CONFIG_SH4=y,g' $(UCLIBC_DIR)/.oldconfig endif
Signature · 1 line
1.7.9.5
PATCH 2/2 arch: remove support for SuperH 2 and SuperH 3
Quoted 13 lines · Thomas Petazzoni
The SuperH 2 architecture is a noMMU architecture from Renesas, and its Linux support is really poor. A number of packages fail to build, the kernel support is almost inexistant, we have never heard of any user of it.
I was originally the one who introduced support for SuperH 2, but the project switched to a different architecture due to the poor Linux support for SuperH 2.
Regarding SuperH 3, I've never heard of Linux support for it that is used in practice.
Signed-off-by Thomas Petazzoni<[email protected]>
Quoted 9 lines
--- arch/Config.in.sh | 18 ++------------ package/flashbench/flashbench.mk | 4 +-- package/kexec/Config.in | 2 +- package/multimedia/mplayer/Config.in | 3 +-- toolchain/toolchain-external/Config.in | 40 ------------------------------ toolchain/toolchain-external/ext-tool.mk | 6 ----- toolchain/uClibc/uclibc.mk | 20 --------------- 7 files changed, 6 insertions(+), 87 deletions(-)
git grep 'sh[23]' tells me:
- some comments in qemu.mk can be removed;
- package/binutils/binutils-*/120-sh-conf.patch can probably be removed (I think the target name is always sh-x-y for sh4).
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 2/2 arch: remove support for SuperH 2 and SuperH 3
In reply to Thomas PetazzoniHi Thomas,
Quoted 8 lines
The SuperH 2 architecture is a noMMU architecture from Renesas, and its Linux support is really poor. A number of packages fail to build, the kernel support is almost inexistant, we have never heard of any user of it.
I was originally the one who introduced support for SuperH 2, but the project switched to a different architecture due to the poor Linux support for SuperH 2.
Actually, there are a couple of sh2a devices that are supported in the upstream Linux kernel, the sh7264 and sh7269 devices. Though they lack a number of upstream drivers, the basics are there, and there are a number of out-of-tree drivers. I also know of a number of customers using these devices with Buildroot, mostly in Japan.
The main reason that most packages fail to build is the noMMU architecture. That, of course, is a problem. However, I have found that it is useful to use Buildroot to build the busybox and a few packages at least. One of the main reasons for using Buildroot is that it is the one of the few tools that can build for noMMU devices.
Quoted 2 lines
Regarding SuperH 3, I've never heard of Linux support for it that is used in practice.
Regarding the other Renesas families that are removed by this patch, I would agree that there are any users.
So, can we keep sh2a?
Regards
Phil
PATCH 2/2 arch: remove support for SuperH 2 and SuperH 3
Hello,
Quoted 1 line · phil.edworthy at renesas.com
So, can we keep sh2a?
Ok, sure. I'll change the patch to remove only SH3. I'll try to contact you separately whenever we have SH2 related build issues, when they are not stricly noMMU related.
I presume you actually have real hardware to test the systems generated by Buildroot?
Thanks for your feedback!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 2/2 arch: remove support for SuperH 2 and SuperH 3
Hi Thomas,
Quoted 5 lines
Quoted 1 line
So, can we keep sh2a?
Ok, sure. I'll change the patch to remove only SH3. I'll try to contact you separately whenever we have SH2 related build issues, when they are not stricly noMMU related.
Ok, thanks!
Quoted 2 lines
I presume you actually have real hardware to test the systems generated by Buildroot?
Yes, I have a sh7264 and sh7269 board I can use.
Thanks
Phil