Skip to contentSkip to conversation

ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

PATCH New Sylwester Nawrocki 3 participants 3 messages Apr 8, 2013 – Apr 9, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt storm and the system hang as soon as any external interrupt is requested.

---

This patch is for _3.9_. I'm going to send a similar patch for 3.10-rc2 for drivers/irqchip/irq-s3c24xx.c.

---
 arch/arm/mach-s3c24xx/irq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-s3c24xx/irq.c +1 -1
index cb9f5e0..d8ba9be 100644
@@ -500,7 +500,7 @@ struct s3c_irq_intc *s3c24xx_init_intc(struct device_node *np,
 		base = (void *)0xfd000000;
 
 		intc->reg_mask = base + 0xa4;
-		intc->reg_pending = base + 0x08;
+		intc->reg_pending = base + 0xa8;
 		irq_num = 20;
 		irq_start = S3C2410_IRQ(32);
 		irq_offset = 4;

--
1.7.4.1

#1 lore raw

PATCH 1/1 ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

Am Montag, 8. April 2013, 21:53:07 schrieb Sylwester Nawrocki:

Quoted 6 lines

The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt storm and the system hang as soon as any external interrupt is requested.

yep, I unintentionally introduced a typo there and the register really is 0xa8, so thanks (again) for the fix

Quoted 28 lines

---

This patch is for _3.9_. I'm going to send a similar patch for 3.10-rc2 for drivers/irqchip/irq-s3c24xx.c.

---
 arch/arm/mach-s3c24xx/irq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-s3c24xx/irq.c +1 -2
index cb9f5e0..d8ba9be 100644
@@ -500,7 +500,7 @@ struct s3c_irq_intc *s3c24xx_init_intc(struct
 device_node *np, base = (void *)0xfd000000;
 
 		intc->reg_mask = base + 0xa4;
-		intc->reg_pending = base + 0x08;
+		intc->reg_pending = base + 0xa8;
 		irq_num = 20;
 		irq_start = S3C2410_IRQ(32);
 		irq_offset = 4;
--

1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw

PATCH 1/1 ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

Quoted 6 lines · Heiko St?bner

Am Montag, 8. April 2013, 21:53:07 schrieb Sylwester Nawrocki:

Quoted 5 lines

The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt storm and the system hang as soon as any external interrupt is requested.

Quoted 6 lines
Quoted 1 line

yep, I unintentionally introduced a typo there and the register really is 0xa8, so thanks (again) for the fix

Applied into fixes for v3.9.

Thanks.

- Kukjin